Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svalin impl #11

Closed
wants to merge 37 commits into from
Closed

Svalin impl #11

wants to merge 37 commits into from

Commits on Jul 28, 2024

  1. Export from Game Files

    LocalIdentity committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    e13a2f8 View commit details
    Browse the repository at this point in the history
  2. Update Query Mods

    LocalIdentity committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    4fcbdc3 View commit details
    Browse the repository at this point in the history
  3. Update Skill Tree

    LocalIdentity committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    f123a97 View commit details
    Browse the repository at this point in the history
  4. Update Glorious Vanity

    LocalIdentity committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    7de14fd View commit details
    Browse the repository at this point in the history
  5. Export Rune Enchants

    LocalIdentity committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    0dcc062 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    90d95c7 View commit details
    Browse the repository at this point in the history
  7. Update CalcPerform.lua (PathOfBuildingCommunity#7967)

    fix quality for tinctures
    nexus671 authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    37c59d2 View commit details
    Browse the repository at this point in the history
  8. Fix DoT Multi when using Maligaro's Virtuosity and Perfect Agony (Pat…

    …hOfBuildingCommunity#7965)
    
    * fixed modifiers to "..." with melee skills not working for DoT
    
    * Added support for Ambush skill
    
    * Lowered the CritMult override value by 100 in the Perfect Agony
    
    * Update CalcOffence.lua
    
    ---------
    
    Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
    DieMango and LocalIdentity authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    22b7691 View commit details
    Browse the repository at this point in the history
  9. Add support for Warcries to affect minions (PathOfBuildingCommunity#7960

    )
    
    * make warcry a buff type and handle it with buffs
    
    * make it work with minions
    
    * Scaling Precision
    
    * Fix Rallying Cry
    
    ---------
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    Regisle and LocalIdentity authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    9870da3 View commit details
    Browse the repository at this point in the history
  10. Add support for Echoes of Creation (PathOfBuildingCommunity#7999)

    Adds support for the 2 mods on Echoes of Creation
    Leverages the code from  Overexertion for the damage mod
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    5ee3aeb View commit details
    Browse the repository at this point in the history
  11. Fix Ravenous Passion helmet not granting Spell damage (PathOfBuilding…

    …Community#7936)
    
    The condition check was wrong and the mod was also using the wrong ModFlag
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    79f38ed View commit details
    Browse the repository at this point in the history
  12. Fix Rallying Cry Exerted damage mod working with Autoexertion (PathOf…

    …BuildingCommunity#8001)
    
    Confirmed with GGG that the mod does not work
    `If the skill is prevented from granting buffs to allies, then it cannot be affecting allies, therefore it doesn't get the bonus`
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    e36f82e View commit details
    Browse the repository at this point in the history
  13. Implement trigger from the Svalinn unique (PathOfBuildingCommunity#8000)

    * FEAT: implement Svalinn trigger
    
    * TEST: add tests for Svalling trigger
    
    * FIX: add mod cache to pass tests
    
    * ModCache
    
    ---------
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    Paliak and LocalIdentity authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    e640c41 View commit details
    Browse the repository at this point in the history
  14. Improve Militant Faith Notable Protection (PathOfBuildingCommunity#7990)

    * Fix Militant Faith Notable Protection to actually work and keep the protected nodes as Devotion
    
    * updates
    
    * do not allow replace for protected nodes
    
    * Adjust wording
    
    ---------
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    Peechey and LocalIdentity authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    7836f86 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Add support for new 3.25 Uniques (PathOfBuildingCommunity#7993)

    * New Uniques
    
    * added rest of known uniques
    
    * spelling
    
    * Add support for mods
    
    ---------
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    Nostrademous and LocalIdentity authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    cc90523 View commit details
    Browse the repository at this point in the history
  2. Add Scorch chance on crit for Warden's Oath (PathOfBuildingCommunity#…

    …7975)
    
    Implemented a condition to set "ScorchChanceOnCrit" to 100% when "IgniteCanScorch" flag is active. This ensures the Scorch ailment is applied on critical hits when using the Warden's Oath of Summer.
    ConnorThelin authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    dcf0c6d View commit details
    Browse the repository at this point in the history
  3. Disable Non-Instant Life Leech with Strength of Blood (PathOfBuilding…

    …Community#7937)
    
    Co-authored-by: greatnameincoming <greatnameincoming@gmail.com>
    greatnameincoming and greatnameincoming authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b2304c5 View commit details
    Browse the repository at this point in the history
  4. Add tag to Legacy Watchers eye mods (PathOfBuildingCommunity#8002)

    The phys taken as mods are now legacy
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    46305c3 View commit details
    Browse the repository at this point in the history
  5. Fix numerous issues in bleed calculations (PathOfBuildingCommunity#7771)

    * Fix numerous issues in bleed calculations
    
    - Chance to bleed was applied in the incorrect location
    - Chance to hit was applied incorrectly
    - Bleed stacks and stack potential was overwritten with incorrect values at times
    - Crimson Dance calculations were broken
    - Bleed stack potential was incorrectly applied to per-stack bleed damage
    - Multiple damage formulas were used simultaneously
    - Output from multiple formulas did not align with numbers displayed to user
    
    * Add test for bleed fix
    
    * Fix ailment test
    
    * fix bleed not reflecting different chances on crits
    
    * Apply ailment chance and stack fixes to ignite and poison
    
    * Fix Bleed/Ignite chance breakdown
    
    * Apply instant ability ailment fix
    
    -fixes nan / divide by 0 for hit like corpse explosion
    
    * Move poison stacks affect into calcs tab
    
    * Integrate new formula for average roll
    
    ---------
    
    Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    3 people authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    4b8ede6 View commit details
    Browse the repository at this point in the history
  6. Release 2.47.0 (PathOfBuildingCommunity#8003)

    * Prepare release 2.47.0
    
    * Fix changelogs
    
    ---------
    
    Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com>
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    3 people authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    51185c9 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'dev'

    LocalIdentity committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    5a0b297 View commit details
    Browse the repository at this point in the history
  8. Release 2.47.0

    --- New to Path of Building ---
    * Update Gems, Item bases, Mods and Minions (Wires77, Regisle, Nostrademous, LocalIdentity)
    * Add support for new 3.25 Gems (LocalIdentity)
    * Add support for new 3.25 Uniques (LocalIdentity, Paliak, Nostrademous)
    * Add support for Warcries to affect Minions (Regisle)
    * Add support for Echoes of Creation (LocalIdentity)
    * Fix numerous issues in bleed calculations (CelestiaTheDryad)
    
    --- Fixed Crashes ---
    * Fix crash when importing a build where empty configs were not loaded properly (Wires77)
    
    --- User Interface ---
    * Remove remote build list functionality pending redesign (Wires77)
    * Fix breakdown for DoT Multiplier (Rybadour)
    
    --- Fixed Calculations ---
    * Fix DoT Multi when using Maligaro's Virtuosity and Perfect Agony (DieMango)
    * Fix Scorch chance on Crit when using Warden's Oath of Summer (ConnorThelin)
    * Fix Gladiator Determined Survivor Shield Block calculation (Regisle)
    * Fix Ignite divide by 0 error (NL908)
    
    --- Fixed Behaviours ---
    * Fix Quality on Tinctures to apply More effect instead of Increased (nexus671)
    * Fix non-instant Life Leech incorrectly applying with Strength of Blood (greatnameincoming)
    * Fix Ravenous Passion helmet not granting Spell damage from Rage (LocalIdentity)
    * Fix Rallying Cry Exerted damage mod incorrectly working with Autoexertion (LocalIdentity)
    * Improve Militant Faith Notable Protection (Peechey)
    
    --- Accuracy Improvements ---
    * Fix Dark Seer missing global Chance to Blind on Hit (NL908)
    * Add tag to Legacy Watchers eye mods (LocalIdentity)
    LocalIdentity committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    dd1290c View commit details
    Browse the repository at this point in the history
  9. Merge branch 'master' into dev

    LocalIdentity committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    8b9dd4d View commit details
    Browse the repository at this point in the history
  10. Fix Added Damage not applying to Monster Explosions (PathOfBuildingCo…

    …mmunity#8008)
    
    The damage effectiveness should have been 1 not 0
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    81af710 View commit details
    Browse the repository at this point in the history
  11. Fix Poison stacks applying twice to Poison DPS (PathOfBuildingCommuni…

    …ty#8007)
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    a7c3b2f View commit details
    Browse the repository at this point in the history
  12. Fix calculation when using both Autoexertion and Echoes of Creation (P…

    …athOfBuildingCommunity#8006)
    
    The More mods were being summed together before being multiplier. This also fixes the terrible breakdown names I previously used
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    baa231a View commit details
    Browse the repository at this point in the history
  13. Fix increased Chance to Block mod on Shields not working (PathOfBuild…

    …ingCommunity#8010)
    
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    LocalIdentity and LocalIdentity authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    eb94bc0 View commit details
    Browse the repository at this point in the history
  14. Release 2.47.1 (PathOfBuildingCommunity#8011)

    * Prepare release 2.47.1
    
    * Fix
    
    ---------
    
    Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com>
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>
    3 people authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    61e8edc View commit details
    Browse the repository at this point in the history
  15. Merge branch 'dev'

    LocalIdentity committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    4b061c1 View commit details
    Browse the repository at this point in the history
  16. Release 2.47.1

    --- Fixed Calculations ---
    * Fix Added Damage not applying to Monster Explosions (LocalIdentity)
    * Fix Poison stacks applying twice to Poison DPS (LocalIdentity)
    * Fix damage calculation when using both Autoexertion and Echoes of Creation (LocalIdentity)
    
    --- Fixed Behaviours ---
    - Fix increased Chance to Block mod on Shields not working (LocalIdentity)
    LocalIdentity committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    e154ceb View commit details
    Browse the repository at this point in the history
  17. Merge branch 'master' into dev

    LocalIdentity committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    938e9ae View commit details
    Browse the repository at this point in the history
  18. Fix Block chance calculation

    LocalIdentity committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    a68fe82 View commit details
    Browse the repository at this point in the history
  19. Update manifest

    LocalIdentity committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    efb6b80 View commit details
    Browse the repository at this point in the history
  20. Merge branch 'dev'

    LocalIdentity committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    000e9ed View commit details
    Browse the repository at this point in the history
  21. Release 2.47.2

    --- Fixed Calculations ---
    * Fix Block Chance calculation (LocalIdentity)
    LocalIdentity committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    3c3c9ff View commit details
    Browse the repository at this point in the history
  22. Merge branch 'master' into dev

    LocalIdentity committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    0904a87 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    b6736cd View commit details
    Browse the repository at this point in the history