Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package @testing-library/user-event from 12.8.3 to 14.5.2 #2072

Open
palisadoes opened this issue Jul 4, 2024 · 20 comments
Open

Upgrade package @testing-library/user-event from 12.8.3 to 14.5.2 #2072

palisadoes opened this issue Jul 4, 2024 · 20 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers security Security fix

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade @testing-library/user-event from 12.8.3 to 14.5.2.
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs

Release Note Details

Bumps @testing-library/user-event from 12.8.3 to 14.5.2.

Release notes

Sourced from @​testing-library/user-event's releases.

v14.5.2

14.5.2 (2023-12-29)

Bug Fixes

  • remove interop and deep DTL imports (6a3c896)

v14.5.1

14.5.1 (2023-09-15)

Bug Fixes

  • incorrect default import from @​testing-library/dom (#1162) (d7483f0)

v14.5.0

14.5.0 (2023-09-14)

Bug Fixes

  • exports: add a named export for userEvent (4019cee), closes #1146

Features

  • types: Add additional type exports for UserEvent & Options (#1112) (da00e8d)

v14.4.3

14.4.3 (2022-08-09)

Bug Fixes

v14.4.2

14.4.2 (2022-08-04)

Bug Fixes

v14.4.1

14.4.1 (2022-08-02)

... (truncated)

Commits
  • d036279 chore: upgrade node in codesandbox
  • 910fee5 chore: set tsconfig baseUrl
  • fa8d867 revert: swap release script
  • c4b4629 chore: upgrade testing environment
  • 6a3c896 fix: remove interop and deep DTL imports
  • d7483f0 fix: incorrect default import from @​testing-library/dom (#1162)
  • 4be87b3 chore: swap release script
  • d95121d chore: add --experimental-import-meta-resolve
  • 8779eae chore: format, lint, fix lint
  • 4019cee fix(exports): add a named export for userEvent
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@palisadoes palisadoes added bug Something isn't working good first issue Good for newcomers security Security fix dependencies Pull requests that update a dependency file labels Jul 4, 2024
@sahil-idk
Copy link

i would like to work on this issue

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jul 15, 2024
@AradhyaDixit18
Copy link

Can I help in this issue ?

@sahil-idk
Copy link

sahil-idk commented Jul 15, 2024

After Updating the package to 14.5.2 i faced some act() issues with warnings that dependabot also faced

https://github.com/PalisadoesFoundation/talawa-admin/actions/runs/9736356167/job/26866929956?pr=2065

Then after Going through the testing library documentation it shows the requirement of testing-library/dom package but once i run the tests again i encounter almost half tests failing which i am working on and any assistance will be appreciated
@palisadoes @varshith257
image

@palisadoes
Copy link
Contributor Author

Please ask the #talawa-admin slack channel for assistance

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jul 16, 2024
@sahil-idk
Copy link

@palisadoes i asked the slack , didnt get response but what i figured is the new version of user event requires a @testing-library/dom package which i installed but it leads to fail in tests as the libraray's test writing syntax had many changes in 13.5 and from there to 14.5 as well ( u can check them in @testing-library/user-event repository) which will require modifying those tests , so what should be the next course of action ?

@varshith257
Copy link
Member

varshith257 commented Jul 22, 2024

@sahil-idk Yes, there are major changes from version 13. Refactor the changes needed according to docs of user
-event library to update to latest version 14

Copy link

github-actions bot commented Aug 2, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 2, 2024
@Cioppolo14
Copy link

@sahil-idk Are you still working on this?

@sahil-idk
Copy link

@sahil-idk Are you still working on this?

I've been working on updating a package to a specific version, but now there are numerous changes in the test files. With around 50 failed tests to fix, it's becoming quite overwhelming. Could you suggest a more efficient solution for handling this situation?

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 13, 2024
@palisadoes
Copy link
Contributor Author

Unassigning. Inactivity

@ManjariRathore
Copy link

Hey @palisadoes, @varshith257
If possible can you assign this to me since one of the issues that i was working on has been closed. I will raise a draft PR asap.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Aug 14, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 26, 2024
@palisadoes
Copy link
Contributor Author

Unassigning. Inactivity

@github-actions github-actions bot removed the no-issue-activity No issue activity label Aug 31, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Sep 10, 2024
@Kanishk-tiwari-045
Copy link

@palisadoes Can you please assign this to me?
I am just about to raise a PR

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@palisadoes
Copy link
Contributor Author

Unassigning. Inactivity

@Kanishk-tiwari-045
Copy link

Kanishk-tiwari-045 commented Oct 5, 2024

@palisadoes Sir I have nearly solved all the testcases, which were failing in my previous PR, Now i am about to push my recent work after solving 6 more of them.
Can I be reassigned please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers security Security fix
Projects
None yet
Development

No branches or pull requests

7 participants