-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade package @testing-library/user-event from 12.8.3 to 14.5.2 #2072
Comments
i would like to work on this issue |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Can I help in this issue ? |
After Updating the package to 14.5.2 i faced some act() issues with warnings that dependabot also faced https://github.com/PalisadoesFoundation/talawa-admin/actions/runs/9736356167/job/26866929956?pr=2065 Then after Going through the testing library documentation it shows the requirement of testing-library/dom package but once i run the tests again i encounter almost half tests failing which i am working on and any assistance will be appreciated |
Please ask the #talawa-admin slack channel for assistance |
@palisadoes i asked the slack , didnt get response but what i figured is the new version of user event requires a @testing-library/dom package which i installed but it leads to fail in tests as the libraray's test writing syntax had many changes in 13.5 and from there to 14.5 as well ( u can check them in @testing-library/user-event repository) which will require modifying those tests , so what should be the next course of action ? |
@sahil-idk Yes, there are major changes from version 13. Refactor the changes needed according to docs of user |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
@sahil-idk Are you still working on this? |
I've been working on updating a package to a specific version, but now there are numerous changes in the test files. With around 50 failed tests to fix, it's becoming quite overwhelming. Could you suggest a more efficient solution for handling this situation? |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Unassigning. Inactivity |
Hey @palisadoes, @varshith257 |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Unassigning. Inactivity |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
@palisadoes Can you please assign this to me? |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Unassigning. Inactivity |
@palisadoes Sir I have nearly solved all the testcases, which were failing in my previous PR, Now i am about to push my recent work after solving 6 more of them. |
Rationale
This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes
Task
Background Failing PRs
Release Note Details
Bumps @testing-library/user-event from 12.8.3 to 14.5.2.
Release notes
Sourced from
@testing-library/user-event
's releases.... (truncated)
Commits
d036279
chore: upgradenode
in codesandbox910fee5
chore: set tsconfigbaseUrl
fa8d867
revert: swap release scriptc4b4629
chore: upgrade testing environment6a3c896
fix: remove interop and deep DTL importsd7483f0
fix: incorrect default import from@testing-library/dom
(#1162)4be87b3
chore: swap release scriptd95121d
chore: add --experimental-import-meta-resolve8779eae
chore: format, lint, fix lint4019cee
fix(exports): add a named export for userEventDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)The text was updated successfully, but these errors were encountered: