-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@testing-library/user-event from 12.8.3 to 14.5.2 #2164
@testing-library/user-event from 12.8.3 to 14.5.2 #2164
Conversation
Updated CONTRIBUTING.md with new branching strategy
Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 1.3.1 to 1.3.4. - [Release notes](https://github.com/mafintosh/dns-packet/releases) - [Changelog](https://github.com/mafintosh/dns-packet/blob/master/CHANGELOG.md) - [Commits](mafintosh/dns-packet@v1.3.1...v1.3.4) Signed-off-by: dependabot[bot] <support@github.com>
…dependabot/npm_and_yarn/dns-packet-1.3.4 Bump dns-packet from 1.3.1 to 1.3.4
* Update authorized-changes-detection.yml * Code Coverage @ 87.1% * Update .gitignore * Delete codecov This executable should not be in the repo * added translation hint text in placeholders (#487) * Update pull-requests.yml * Create DOCUMENTATION.md * Rename issue-guidelines.md to ISSUE_GUIDELINES.md * Update CONTRIBUTING.md * Update issue.yml * Rename PR-guidelines.md to PR_GUIDELINES.md * Update CONTRIBUTING.md * Update pull-request-target.yml * Delete PULL_REQUEST_TEMPLATE.md * Delete ISSUE_TEMPLATE.md * Rename Code_Style.md to CODE_STYLE.md * added removeMember mutation (#491) * added removeMember mutation * changed mutation name * remove contributions from router (#502) * Fixed Settings page Header (#501) * fixed cani-use lite warning * fixed the alignments for smaller screens and also added spacing on places where it was needed * fixed the linting errors * ran prettier to remove styling errors * made the orgSetting title dynamic * linted the code and made the settings header as required and also made the settings page navbar responsive * linted code and made necessary changes * errors fixed * Added dropdown for Applanguage in UserUpdation form (#498) * Added dropdown for Applanguage in UserUpdation form * App language code changed to Default language * Change the Scalar Types [Provides relevant client side changes for #1085 in Talawa-API] (#500) * Change typedefs * Fix date parsing * Move ID to ObjectID scalar * Client changes for Adding GraphQL Scalars (#511) * Change typedefs * Fix date parsing * Move ID to ObjectID scalar * Revert ObjectID to ID * Change ObjectID to ID * modal closed after organization creation (#516) * most recently added Org displays at the top (#515) * Add Husky (#520) * updated contributing (#521) * Display and choose Organisation image (#512) * upload image working for createOrganisation * Organisation image showing everywhere * Testcase failure fixed * Linting fixed * convertToBase64 func made and tests for it * CI/CD error fixed * tests added for AdminNavbar & OrganisationDashboard * Linting fixed * fixed translation on the plugin tab (#510) * added OrgName to the Navbar (#525) * Fix create event mutation [Fixes part of #1101 in Talawa-API] (#523) * Add format fix * Fix updation of posts * Test coverage improved for organizationPeople.tsx (#526) * Update INSTALLATION.md * Update INSTALLATION.md * Update INSTALLATION.md * Update stale.yml * Remove tags (#532) * Fixed navbar added tests (#534) * Fixed navbar added tests * Fixed the translation of All orgnaizations btn in AdminNavbar * Fix the updateOrg page, and made it to create mutation request [Fixes #531] (#536) * fix orgUpdate system * fix translations * Update CONTRIBUTING.md * Code Coverage @ 88% * Fixes #478 : Implemeneted calendar to the Event tab (#537) * calendar-implemented * calendar-implemented * fixed tests * Added post-merge hook using husky (#541) * Added post-merge hook using husky * made required changes to installation.md * make changes to documentation for husky * made the required changes in installation guide * Update pull-requests.yml * Fixed yarn installation instructions (#584) * organization sorting for all organization (#619) * removed redundant notification (#577) * Profile Page for Members (#543) * Initial member page made * Changed query added Org and Events section * Homescreen ready * initial translation added for Profile * initial translation added for Profile * Added translations * Added translations * Revised translation * Fixed failing tests for components * Link added to OrgAdminListCard * Linting fixed for OrgPeopleListCard * Added tests, removed logs * Uniform design * Fix:routing issue for orgdash page (#580) * Fix:routing issue for orgdash page * fix:failing test of SuperDashListCard * Rectify Warnings: EventListCard.test.tsx (#595) * Added logic to close modal after successful submission (#623) * Feature Request: Position of the search bar. (#631) * Feature Request: Position of the search bar #614 resolved * Feature Request: Position of the search bar #614 resolved * fixes: #550 added test for the calendar (#552) * added test for the calendar * updates mocks * Update Router Function [Fixes #636] (#638) * Update Router Function * Empty commit * Fix about content overflow (#632) Signed-off-by: Ekene Nwobodo <Nwobodoe71@gmail.com> * removed duplicate rows per page section in orgposts (#648) * fixed :made card in organization dashboard interactive (#620) * Implemented manage functionality for admin and super admin after login (#539) * Implememnted manage functinality for admin/superadmin after login * Update AdminDashListCard.module.css * Some formatting issues with module file * resolved workflow issues * Added folding feature to posts (#581) * added folding feature to posts * added fold feature to posts * brought code under code coverage * added tests * added tests for remainging uncovered lines * brought code coverage to 100% for the changes * Code coverage @87.2% * Fix User Update Details Page and Add Update Password Page [Fixes #530] (#657) * fixed updateuser logic * update translations * fix lint * lint fix 2 * fix tests * fixed:move orgLocation & remove duplicate orgName (#655) * fixed:move orgLocation & remove duplicate orgName * Dummy commit * fixes - [#597] - Navbar navlinks hover and button styles (#603) * fixed: #585 - Password error showing. Tested * fix: #590 - fixed navbar hover issues * fix: #590 - fixed navbar hover issues * Code Coverage 87.4% * fixes 599 (#653) * fixed errors and removed window.replace * written test case for ensure window.location.replace * written test case for ensure window.location.replace * added useHistory to keep track of routing behind the scenes * fixed merge conflicts and errors * updated comments for file changes * Added warning comments for routing --------- Co-authored-by: Adepeju <adepeju.kayode@gmail> * fix org search location (#682) Signed-off-by: Ekene Nwobodo <Nwobodoe71@gmail.com> * fixed the issue of validate the input before submit #674 (#678) * Adds required tests for OrganizationEvents.tsx and Fixes a minor bug in Calendar (#527) * adds tests for organization events * removes the unrequired branch from OrganizationEvents.tsx * fixes failing tests * fixes failing lint tests * Update password preview feature with coverage tests (#629) * Fix to the issue #585 (#607) * [fix]- fixed the password error warning * [fix]- fixed the password error warning * [fix]- fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [feat]-added test cases for password error warning * [feat]- added test cases for password error warning * [feat]- added test cases for password error warning * [fix]- fixed the linting * Improve test coverage for calendar.tsx (#679) * Improve test coverage for calendar.tsx * Restore previous tests * remove --coverage * i rebased my codebase and resolved the initial issue (#669) * fixed the issue use of toast in place of window.alert #645 (#687) * Update ISSUE_GUIDELINES.md * fixed the static time data under Organization card in the Organization List tab (#689) * fixed the static time in org card * formatted the date to MM D, YYYY --------- Co-authored-by: thesaaddevloper <thesaaddeveloper@gmail.com> * Fixed the pagination alignment issue (#702) * [fix]- fixed the password error warning * [fix]- fixed the password error warning * [fix]- fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [fix]-fixed the password error warning * [feat]-added test cases for password error warning * [feat]- added test cases for password error warning * [feat]- added test cases for password error warning * [fix]- fixed the linting * [fix]- fixed the pagination alignment issue * [fix]- fixed the pagination alignment issue * [fix]- fixed the pagination alignment issue * Removed overlapping (#675) * changes input element to textarea and changes in test (#710) * Code Coverage @90.7% * Indicating active tabs (#691) * added underline to active links in navbar * fixed lint error * fixed the org default image #688 and removed stock image (#695) * fixed the org default image #688 and removed stock image * removed eslint warning * added new img as default org img * Update INSTALLATION.md * Added Clear Error and Warn Messages when API is unavailable (#670) * Added error and warn messages * Added tests & fixed inconsistency in mocks * Lint fix LoginPage * Lint Fix LoginPage.test * minor fix * Minor update to LoginPage * Minor change to LoginPage.test * Replaced toast.warn() with toast.error() * Fixed test accordingly * Lint Fix * Minor fix * Extra edge case handled * code coverage fix * Lint fix * Update LoginPage * Update LoginPage.test * Lint fix * improve test coverage for orgpost.tsx (#718) * Improve test coverage for calendar.tsx * Restore previous tests * remove --coverage * improve test for orgpost.tsx * Implemented Proper Error Handling for all Screens [Fixes: #535] (#731) * Handled error cases for all screens * Some more fixes * Some more fixes * Added StaticMockLink to use Mocks multiple times [Fixes Multiple Issues] (#745) * add StaticMockLink * lint fix * remove showWarning * Added prompt to Register on Login Page (#628) * Add prompt to Login page - Add prompt in other languages: fr, sp, hi, zh. - switch styling of Login Button with Reg Button * format with prettier * fixed event checkboxes to update (#707) * Block/Unblock functionality for only members of the organization (#690) * Implememnted manage functinality for admin/superadmin after login * Update AdminDashListCard.module.css * Some formatting issues with module file * resolved workflow issues * Updated block/unblock page preventing users who are not members of organiztion * Update BlockUser.test.tsx to resolve failing tests Modified the mocks fields according to the corresponding changes in BlockUser.tsx file. * created a reusable postNotFound Component with responsive UI (#717) * created a reusable postNotFound Component with responsive UI * run test error solved * added translation to the component and also created the test.tsx for the error component * fixed the failing test and added the postNotFound reusable component for OrgList --------- Co-authored-by: thesaaddevloper <thesaaddeveloper@gmail.com> * fix: #601 modal responsive width (#621) * added dynamic title to OrgPeople section (#704) * added dynamic title to OrgPeople section * fixed code coverage * fixed code coverage * uncommented the mistakenly added code * Delete er * Updated session timeout notification toast with already existing one (#734) * Added a toast to notify users that session has expired and redirects to the login page * Updated toast notification on session timeout with already existing one * eliminated the use of magic numbers * minor error correction on the timeout minutes --------- Co-authored-by: TheoCathy <theocathyne@gmail.com> * Fixed the empty space in the OrgList (#751) * created a reusable postNotFound Component with responsive UI * run test error solved * added translation to the component and also created the test.tsx for the error component * fixed the failing test and added the postNotFound reusable component for OrgList * fixed the empty space in orgList * fixed the failing test * removed the unwanted files --------- Co-authored-by: thesaaddevloper <thesaaddeveloper@gmail.com> * align navbar items (#755) * align navbar items * replace More with a hamburger icon * replace More with a hamburger icon to fix workflow error * replace More with a hamburger icon to fix workflow error * Fixes: toggle password for registration (#758) * added toggle-password * updated * formatting * added icon for toggle password * Super Admin Dashboard Error When Organizations Absent (#754) * No Organization Warning on OrgList * Minor Fix * Fixed failing tests * Added Warning on Roles and Request Pages * Added Tests for OrgList * Testing Fixes * Added more tests * Added Tests for Roles and Request Pages * Code Coverage @ 91.0% * Add link to dashboard admin card (#760) * image upload made functional (#677) * image upload made functional * lint * fixed failing test * linting * re run test , remove yarn.lock changes * updateUser test cov * OrgPost * rerun tests * Empty commit * reverted last 2 commits changes * re run code cov * update userUpdate * rerun code cov again * revert last commit * Update PR_GUIDELINES.md * Implemented Search bar and the radio buttons in orgPost page that searches both title and text of post (#770) * created a reusable postNotFound Component with responsive UI * run test error solved * added translation to the component and also created the test.tsx for the error component * fixed the failing test and added the postNotFound reusable component for OrgList * fixed the empty space in orgList * fixed the failing test * removed the unwanted files * the one search bar which searches both text and title of post * testing file * orpost file testing * code coverage is increased * fixed the failing test --------- Co-authored-by: thesaaddevloper <thesaaddeveloper@gmail.com> Co-authored-by: saadabban76 <�115649011+saadabban76@users.noreply.github.com> * center org image on mobile (#778) Signed-off-by: Ekene Nwobodo <Nwobodoe71@gmail.com> * removed link for plugin dropdown toggle (#781) * removed link for plugin dropdown toggle * added id * align superadmin nav items and fix failed tests (#766) * changed the handleSearchByName function in searchByName in Roles page (#735) * changed the handleSearchByName function to search using target's value instead of searchByName variable * updated the file Roles.tsx to take care of useState lag * changed tests for suiting searchByName * changed tests for searchByName including backspaces * added tests for paginationList and changing rowsPerPage * added tests to increase coverage in Roles.tsx * changed the package.json file's test command * removed extra scrollbars (#800) * Recently added Post displays at top (#773) * Recently added Post displays at top * reversed the posts as required in the query * Increased the OrgList Code Coverage (#786) * increased the orgList coverage to 95$ * increased the orgList Code Coverage * increased the orgList Code Coverage * increased the orgList Code Coverage * fixed image rendering in orgPost page * increased the code coverage for orgList Component * increased code coverage to 97% in orgList Component --------- Co-authored-by: saadabban76 <�115649011+saadabban76@users.noreply.github.com> * Modify event visibility for non-admins (#796) * Modify event visibility for non-admins Signed-off-by: Ekene Nwobodo <Nwobodoe71@gmail.com> * Add test suites for events visibilty --------- Signed-off-by: Ekene Nwobodo <Nwobodoe71@gmail.com> * Bug Fix: Drawer menu visibility (#794) * Remove filter by event field (#807) * increased the orgList coverage to 95$ * increased the orgList Code Coverage * increased the orgList Code Coverage * increased the orgList Code Coverage * fixed image rendering in orgPost page * increased the code coverage for orgList Component * increased code coverage to 97% in orgList Component * removed the filter by event section in orgPeople's component * fixed the failing test --------- Co-authored-by: saadabban76 <�115649011+saadabban76@users.noreply.github.com> * Add image to post (#804) * increased the orgList coverage to 95$ * increased the orgList Code Coverage * increased the orgList Code Coverage * increased the orgList Code Coverage * fixed image rendering in orgPost page * increased the code coverage for orgList Component * increased code coverage to 97% in orgList Component * added Image to the post's card * replaced external links with codebase default image * replaced external links with codebase default image * replaced blank image with the default image * fixed the failing test --------- Co-authored-by: saadabban76 <�115649011+saadabban76@users.noreply.github.com> * Update pull-request-target.yml * Update pull-request-target.yml * Update pull-request-target.yml * Update pull-request-target.yml * Update pull-request-target.yml * Update pull-request-target.yml * Upgrade Yarn to NPM in Talawa Admin Project (#802) * npm upgrade * remove package lock * Update push.yml * empty * upgrade yarn to npm * fix docs * fix scripts * empty * stop watch mode * fix ymls * empty * fix scripts * empty commit * update scripts * Redirect to dashboard on organization update (#816) * Redirect to dashboard on organization update * Minor Change * Proper Testing Of Pagination In All List Views (#797) * install faker package used for mocks in tests * Test init for pagination * install dependencies needed to implement certain tests * add a data-testid attribute to their markup for use in tests * add data-testid attributes to its markup being referenced from tests * add test to ensure the number of organization displayed on the page corresponds to the option selected from rowsPerPage * add prop to allow rendering of component in test environment * add data-testid attributes to their markup being referenced from tests * add data-testid attributes to its markup being referenced from tests * add test to affirm that the number of persons displayed on the webpage is same with the selected option from rowsPerPage * install dependencies for certain tests * fix lint errors * tests fix * remove unnecessary dependencies * lint fix * tests fix update * restore file to previous state * empty commit * tests fix update * lint fix * Conditional Usage of Google reCAPTCHA [Fixes #798] (#820) * conditonal recaptcha * Update INSTALLATION.md * add tests * fixed the issue of Mismatched passwords validation #722 (#824) * fixed the issue of Mismatched passwords validation #722 * fixed lint code error * Code Coverage @ 92% * Replace Talawa Portal with Talawa Admin Portal #817 (#821) * Update website title to Talawa Admin Portal in en * Update website title in fr json file * Update website title in sp json file * Update website title in zh json file * Update website title in hi json file * Update the test in ListNavbar file * Update the test in LoginPage.test file * Create a function for the tex macher to make test * Fix lint errors in the LandingPage test file * Remove console.log in LandingPage test file * Upgrade to use npm instead of yarn * Delete yarn.lock file * Fix lint errors * Fix lint errors * Update the heading in hi.json file * Remove unused codes * Fix lint error in LanfingPage file * Correct the talawa_portal value in Fr json file * Correct the talawa_portal value in sp json file * Remove anused package in package.json file * Organization Form Redirect Issue Prevents User Navigation, Affecting User Experience. Issue #808 (#815) * addressing issue #808 * finished - requested changes * addressing warning * Added: event preview modal to view event details (#772) * added event preview model * added event preview model * fixed formatting * added test * added test * added test * failing tests * test * tests * Update workflow (#832) * Workflow fix (#833) * Update pull-requests.yml * Update pull-requests.yml * Update pull-requests.yml * Code Coverage @ 91.0% * Feature: Separation of ADMIN and SUPERADMIN functionalities (#826) * Initial changes * Commit to sync repo * Made changes to OrgList * Some fixes * Minor fix * Added tests for OrgList * Added tests for OrgList * Coverage fix * Required changes added * Made changes to OrgList * Some fix * Some fixes * fixes test for OrgList * Some more fixes * Empty commit * Lint fix * Fixed test * Lint fix * Added Whitespace Validation to Organization and Post create forms (#838) * Added whitespace check in Org Create form * Added Tests * Added Empty String check to OrgPost Form * Added Tests for OrgPost * fixed the issue of Toast msg is not available in all languages #740 (#845) * fixed the issue of Toast msg is not available in all languages #740 * format issue * Empty-Commit * Fixed Org Update (#843) * Prevent Admins and Super Admins from downgrading their own roles (#840) * Code Cleanup * Disabled Super Admins from changing their roles * Added Tests * Added more tests * Improved Code Quality * Revert "Fixed Org Update (#843)" (#847) This reverts commit 53c3fef28ef986d63b1eec45663acb7d07cf1b8d. * Fixed Organization Update and Translation (#849) * Fixed Organization Update * Minor Changes * Success message updated * Fail tests on warning [Priority Needed] (#856) * fix warnings Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com> * fix warnings Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com> * fix warnings Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com> * fix warnings Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com> * fix warnings Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com> * restore addonregister Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com> --------- Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com> * Code duplicacy removed (#852) * Code duplicacy removed * Tests added * Added comments * Fixed failing tests * Code formatted * Unused packages removed, flag icons package updated to latest version (#860) * Unused packages removed, flag icons updated to latest version * Empty commit * Changes in package-lock.json * Fixes #848: limiting mulitple toast (#851) * limiting-toast * added test * Organization People Filters Improved (#855) * Added Filters to Users and Organizations Query * Added Last Name Filter on User, Member and Admin * Added Translation * Fixed Failing Tests * Added Tests for Filters * Fixed Failing Tests * Code Cleanup * Fixed Tests * Added Translation * remove graphql-boost dep (#866) Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com> * added UserNotFound component to the Roles page and improved the search (#865) * changed the handleSearchByName function to search using target's value instead of searchByName variable * updated the file Roles.tsx to take care of useState lag * changed tests for suiting searchByName * changed tests for searchByName including backspaces * added tests for paginationList and changing rowsPerPage * added tests to increase coverage in Roles.tsx * changed the package.json file's test command * changed PostNotFound component to be used as a reusable one and added it in Roles section and set languages option in locales folder * changed formatting in locales changed files * removed comments in Roles.tsx * Empty commit * renamed the PostNotFound component and modifiied relevant files * changed Roles.tsx filtering * empty commit * reverted changes in package.json * Improved signupform validations (#828) * Improved signupform validations * updated signup form validation to show all messages at once * improved test coverage for LoginPage * Fixed failing test --------- Co-authored-by: Joyce Malicha <joycejattane@gmail.com> * added tests for Search Bar in the Organization List Page of SUPERADMIN #827 (#867) * added tests for Search Bar in the Organization List Page of SUPERADMIN #827 * added tests for Search Bar in the Organization List Page of SUPERADMIN #827 * Added Tests Previews (#868) * Installed jest-preview * Automatic Setup * Fiixed Failing Test Command * Added Basic CSS * Added PostCSS Module * Fixed MUI Styling * Minor Changes * Added cross-env to support windows * Adaptar for React 17 and CSS Modules Mock * Added Mocked Styles to Tests * Documentatin Updated * Fixed Failing Tests * Minorr change in documentation * Jest is now Dev Dependency * Workflow Test * Jest Module Path Updates * Module Path Tese 2 * Github Workflow Fixed * Removed Legacy Test Command * Added Documentation to Debug Tests * Fixed Documentation * Docs Image Added To Repo * Images Reorganization * Organized Images * Revert "Improved signupform validations (#828)" (#875) This reverts commit 5820dd9ec05256551b48470c8880fcdc05452fda. * Restored SearchBar Test for OrgList Page (#878) * Restored searchBar test * Lint fix * Coverage fix * Lint fix * Some fixes * Some fixes * fixed the issue of Users filter to fetch corresponding Users to Organisation #701 (#853) * fixed the issue of Users filter to fetch corresponding Users to Organisation #701 * removedd uunused variable * fixed failing text * fixed merged issue * fixed lint error * swap variable * Revert "Restored SearchBar Test for OrgList Page (#878)" (#879) This reverts commit 3d39c524d54e81853490d2d8a1f844ce67252365. * Fixed crashing on error in Block/Unblock page (#862) * Website crash fixed * lint fixed * Added tests for empty response from server * More tests added * Rerun tests empty commit * Redirect on error functioning * Fixed failing tests * Testcase and Title added when users not found * Linting fixed * Typo fixed * Fixed failing tests * Linting fixed * Added NotFound component in OrgPeople and changed Roles.tsx (#882) * changed the handleSearchByName function to search using target's value instead of searchByName variable * updated the file Roles.tsx to take care of useState lag * changed tests for suiting searchByName * changed tests for searchByName including backspaces * added tests for paginationList and changing rowsPerPage * added tests to increase coverage in Roles.tsx * changed the package.json file's test command * changed PostNotFound component to be used as a reusable one and added it in Roles section and set languages option in locales folder * changed formatting in locales changed files * removed comments in Roles.tsx * Empty commit * renamed the PostNotFound component and modifiied relevant files * changed Roles.tsx filtering * empty commit * reverted changes in package.json * added NotFound component in OrgPeople, made changes in the locales files and made some changes to Roles too * added NotFound component to OrgPeople, changerd locales files and changed Roles.tsx * minor change * Restored Search-Bar Test for OrgList Page (#880) * Restored searchBar test * Lint fix * Coverage fix * Lint fix * Some fixes * Some fixes * Fixed Org Dashboard Error (#873) * Fixed TypeError * Minor Change * Fixed Tests * Added back logo512 * Fixed auth header getting copied on login (#890) * fix user update (#876) * fix user detials update * remove userType from update-user page * fix failed test for userUpdate.test.tsx * Removed and Replaced Ant Design from the project (#891) * Fixed auth header getting copied on login * Removed/Replaced Ant Design from the project * Fixed failing tests * Removed comment * Add today functionality in calendar (#897) * Update countline.py * Update pull-requests.yml * Updated countlines.py to cover .spec. files (#900) Co-authored-by: Peter Harrison <peter@colovore.com> * fixed the Inability to set user roles for specific organizations #556 (#898) * fixed the Inability to set user roles for specific organizations #556 * added all language translation * Revert "fixed the Inability to set user roles for specific organizations #556 (#898)" (#901) This reverts commit 891d898eb5543116bb9042a6386b5a12e474159c. * Documentation updated, Redundant css files removed (#896) * Doc updated unused files removed * Removed unused css files from setup tests * Added small calendar in the events #887 (#903) * added small clanedar * added small clanedar * fixed Code Coverage: Create tests for OrgSettings.tsx #396 (#905) * remove redundancy from orgPostCard (#906) * Revert "remove redundancy from orgPostCard (#906)" (#910) This reverts commit d5ce4aa27ee241b0687f7db3d6acd1b62339562f. * Block/Unblock Page Improvements (#885) * Added Radio Buttons * Optimized Queries * Optimized Query and Added Last Name Filter * Radio Button Working * Added Translations * Fixed Filter Name * Fixed Debounce * Fixed Asynchronous Debounce * Added Tests * Better Error and Loading State Handline * Fixed Loader * Fixed Loader * Modulrised Mock Data * Minor Change * Fixed Tests * Increase Coverage * User query replaced with OrgMemberConnection * Fixed Tests * Code Coverage Increase * Code Cov * Fixed Translations * Fixed Failing Tests * fix in failing test (#913) * Improve and Standardize Automated Linting Tests (#916) * added linting rules * added linting rules * added linting rules * Rename `data` variables to more readable name [Fixes #829] (#835) * Refactor screens * Update components * Fix test * Fix typecheck errors * Increase test coverage * Merge latest adminUI-Redesign into Develop (#927) * Updated CODE_STYLE.md * Updated CODE_STYLE.md (#917) * Updated CODE_STYLE.md * Import section update * Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925) * Updated CODE_STYLE.md * Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed * Buttons replaced from normal ones to Bootstrap ones * Import section update * Error fixed for Buttons * Language dropdowns and Change language * InputBoxes & Checkboxes fixed and imported from BS * Removed unused package popper.js * Replaced react-modal with Bootstrap one in Login Page * Modals converted to React Bootstrap one * Completely replaced react-modal with react-bootstrap/Modal from the project * Removed react-modal from the project * Removed classbased modal and unused images * Notification navbar migrated * Modal migration * Modal migration * Modal migration done for OrgPostCard * Empty commit to make workflow run * Empty commit to make workflow run * Empty commit to run the workflow --------- Co-authored-by: Anwer Sayeed <deeyasrewna@gmail.com> * Introduces API versioning check in CI/CD (#924) * a random change * husky precommit * one more try * one more try * one more try * one more try * one more try * one more try * second try * removed unwanted deps * removed unwanted deps * resolved the error * updated variable name * rerun test * rerun test * added test to pull.yml * removed push check * resolved conflict * Update stale.yml * Update CONTRIBUTING.md * Merge talawa-user-portal into develop (#935) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Merge latest Admin UI Redesign into Develop (#934) * Updated CODE_STYLE.md * Updated CODE_STYLE.md (#917) * Updated CODE_STYLE.md * Import section update * Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925) * Updated CODE_STYLE.md * Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed * Buttons replaced from normal ones to Bootstrap ones * Import section update * Error fixed for Buttons * Language dropdowns and Change language * InputBoxes & Checkboxes fixed and imported from BS * Removed unused package popper.js * Replaced react-modal with Bootstrap one in Login Page * Modals converted to React Bootstrap one * Completely replaced react-modal with react-bootstrap/Modal from the project * Removed react-modal from the project * Removed classbased modal and unused images * Notification navbar migrated * Modal migration * Modal migration * Modal migration done for OrgPostCard * Empty commit to make workflow run * Empty commit to make workflow run * Empty commit to run the workflow * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Customised Bootstrap (#929) * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Assets typo fixed * Typo fix * Merge conflict error fixed --------- Co-authored-by: Anwer Sayeed <deeyasrewna@gmail.com> * test PR for API versioning check (#932) * testPR * test2 * testing the change * testing it again * test--no-verify * test--no-verify * echo token * test-again * test-again * test * test * read-only * clone * clone * redesigned newsfeed (#939) * Revert "redesigned newsfeed (#939)" (#943) This reverts commit a645eca7cf2ce1335374f48b52335a293e344580. * Make Talawa-Admin mutations in sync with the backend (#946) * Initial change * Redundant Notification removed * Fixed linting and other issues * Tests fixed * Add Home Screen And People Screen along with other components (#940) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Merge AdminUI-Redesign into Develop (#947) * Updated CODE_STYLE.md * Updated CODE_STYLE.md (#917) * Updated CODE_STYLE.md * Import section update * Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925) * Updated CODE_STYLE.md * Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed * Buttons replaced from normal ones to Bootstrap ones * Import section update * Error fixed for Buttons * Language dropdowns and Change language * InputBoxes & Checkboxes fixed and imported from BS * Removed unused package popper.js * Replaced react-modal with Bootstrap one in Login Page * Modals converted to React Bootstrap one * Completely replaced react-modal with react-bootstrap/Modal from the project * Removed react-modal from the project * Removed classbased modal and unused images * Notification navbar migrated * Modal migration * Modal migration * Modal migration done for OrgPostCard * Empty commit to make workflow run * Empty commit to make workflow run * Empty commit to run the workflow * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Customised Bootstrap (#929) * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Assets typo fixed * Typo fix * Initial login page work * Merge conflict error fixed * Theming modified and Added Loader over every screen * Fixed UI issue for navbar and login * Fixed production bug * Removed unused variable * Tests fixed * Added Change Language Btn dropdown * Merge conflict fixed, merge latest develop into adminUI-redesign (#938) * Merge latest adminUI-Redesign into Develop (#927) * Updated CODE_STYLE.md * Updated CODE_STYLE.md (#917) * Updated CODE_STYLE.md * Import section update * Upgrade and Migrate from Bootstrap 4 to Bootstrap 5 (#925) * Updated CODE_STYLE.md * Latest Boostrap v5.3.0 & react-bootstrap v2.7.4 installed * Buttons replaced from normal ones to Bootstrap ones * Import section update * Error fixed for Buttons * Language dropdowns and Change language * InputBoxes & Checkboxes fixed and imported from BS * Removed unused package popper.js * Replaced react-modal with Bootstrap one in Login Page * Modals converted to React Bootstrap one * Completely replaced react-modal with react-bootstrap/Modal from the project * Removed react-modal from the project * Removed classbased modal and unused images * Notification navbar migrated * Modal migration * Modal migration * Modal migration done for OrgPostCard * Empty commit to make workflow run * Empty commit to make workflow run * Empty commit to run the workflow --------- Co-authored-by: Anwer Sayeed <deeyasrewna@gmail.com> * Introduces API versioning check in CI/CD (#924) * a random change * husky precommit * one more try * one more try * one more try * one more try * one more try * one more try * second try * removed unwanted deps * removed unwanted deps * resolved the error * updated variable name * rerun test * rerun test * added test to pull.yml * removed push check * resolved conflict * Sass filed added with documentation * Linting fixed * Fixed the folder structure and naming convention * Update stale.yml * Typo fix * Update CONTRIBUTING.md * Merge talawa-user-portal into develop (#935) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Merge conflict error fixed --------- Co-authored-by: Anwer Sayeed <deeyasrewna@gmail.com> Co-authored-by: Kanishka Bansode <96020697+kb-0311@users.noreply.github.com> Co-authored-by: Peter Harrison <16875803+palisadoes@users.noreply.github.com> Co-authored-by: Noble Mittal <62551163+beingnoble03@users.noreply.github.com> * Random checkout * Design ready for homescreen * Login page 100% code c=coverage * Login page icon adjustment * Added translations * Fixed the failing tests * Revert to older version of loader * Animation added fixed warnings * Fixed accessability * Mutations and Tests foxed * Fixed coloring in UserPortal * Tests fixed and ChangeLanguageDropdown used in UserLoginPage * Linting Fixed --------- Co-authored-by: Anwer Sayeed <deeyasrewna@gmail.com> Co-authored-by: Kanishka Bansode <96020697+kb-0311@users.noreply.github.com> Co-authored-by: Peter Harrison <16875803+palisadoes@users.noreply.github.com> Co-authored-by: Noble Mittal <62551163+beingnoble03@users.noreply.github.com> * Merge latest adminUI-Redesign (#950) * Initial Organizations screen done * Removed yellow scrollbar * Linting fixed * Replaced images with svgs for logos * Styling done for btnsContainer * Better typechecking and readability * Animated Drawer working * Responsive page ready * OrgCard responsive * Fixed navbar issue and added webkit keyframes * LeftDrawer ready * Translations added * Added shimmer loading effect * Styling issue fixed * Failing tests fixed for OrgList * Removed unused vars * Tests done for LeftDrawer * Succesfully made component without causing any breaking change * 100% Code coverage achieved for Requests Screen * Fix alignment * Roles screen UI done * Role screen fixed with 100% test coverage * Changing screen activeness fixed * Unused vars and Typos fixed * Language support added * Linting and typos fixed * Fixed failing tests for LeftDrawer * Completed tests of AdminDashListCard with 100% code coverage * OrgListCard done * Finalised tests * Requests user search made functional again ! * Fixed loading on refetch and UX on all screens * OrgList failing errors fixed * Fixed all failing tests * Achieved 100% code coverage for OrgList.tsx * Wrote tests and mod LeftDrawer for admins * Minor ui issue fixed * Fixed failing test * UI bug dropdown * Frontend insync with Backend attempt 1 * Introspection fail fix 1 * Introspection error fix 3 * Introspection error fix another attempt * Another attempt * [Talawa-user-portal] Add Settings and Donate Screen, along with other UI fixes (#953) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Add Settings and Donate Screen * Add multilingual support for the screens * Add Event Project and Volunteer Management (#961) * Add screens for adding and updating event projects * Add delete operation for event projects and debug update * Remove yarn.lock * Begin testing * Add display of tasks and functionality to add tasks * Add modal for edit task * Add UpdateTaskModal * Add Delete Task Modal and volunteers display * Add test for DeleteEventProjectModal.tsx * Add tests for add and update event project modal * Add screen for managing volunteers * Add option to assign and remove volunteers * Add tests for AddTaskModal.tsx * Add tests for TaskListItem.tsx and DeleteTaskModal.tsx * Complete testing for all Task Modals * Add completed display to tasks * Add tests for event dashboard * Restructure files * Add attendee management modal * Add testing for EventAttendeeModal * Move to 100% testing and wrapper for attendees modal * Add basic checkIn functionality for users * Add testing for CheckIn modals * Introduce the tag generation into the repository * Update linting rule and fix errors * Remove alloted seat and alloted room * Fix testing * Correct some tests * Migrate from attendees to registrants * Migrate Event Project modals to new design * Migrate registrants modals and checkin modals to new design with 100% test coverage * Move task modals to new styles * Move to 100% test coverage * Admin workflow completed with updated package.json (#960) * Merge latest AdminUI Redesign into develop (#956) * Initial Organizations screen done * Removed yellow scrollbar * Linting fixed * Replaced images with svgs for logos * Styling done for btnsContainer * Better typechecking and readability * Animated Drawer working * Responsive page ready * OrgCard responsive * Fixed navbar issue and added webkit keyframes * LeftDrawer ready * Translations added * Added shimmer loading effect * Styling issue fixed * Failing tests fixed for OrgList * Removed unused vars * Tests done for LeftDrawer * Succesfully made component without causing any breaking change * 100% Code coverage achieved for Requests Screen * Fix alignment * Roles screen UI done * Role screen fixed with 100% test coverage * Changing screen activeness fixed * Unused vars and Typos fixed * Language support added * Linting and typos fixed * Fixed failing tests for LeftDrawer * Completed tests of AdminDashListCard with 100% code coverage * OrgListCard done * Finalised tests * Requests user search made functional again ! * Fixed loading on refetch and UX on all screens * OrgList failing errors fixed * Fixed all failing tests * Achieved 100% code coverage for OrgList.tsx * Wrote tests and mod LeftDrawer for admins * Minor ui issue fixed * Fixed failing test * UI bug dropdown * Frontend insync with Backend attempt 1 * Introspection fail fix 1 * Introspection error fix 3 * Introspection error fix another attempt * Another attempt * Fixed Default Animation on Organizations Screen * Fixed typo * Loading data from localstorage functional * Fixed name conventions * Fixed typo * UI Fix * Changed screen name * Table Loader added * Added LeftOrg drawer and Organization screen comp to Screens * routesReducer tests fixed * Redundant adminNavbar removed from project * MemberDetail issue fixed * Achieved 100% code coverage for LeftDrawerOrg, Added Empty div in images * Fixed failing tests * Fix tests * Fixed warnings * Linting fixes * Linting issues fixed * Achieved 100% code coverage for CollapsibleDropdown * Achieved 100% CC on IconComponent and removed useless imports * Achieved 100% cc for LeftDrawer Component * Achieved 100% CC on SuperAdminScreen Component * Fixed typo * Integrated Event Dashboard * Failing tests for LeftDrawer LeftDrawerOrg OrgList screen fixed * Removed redundant code * Removed useless imports * Linting fixed * Removed LeftDrawerOrg * Update documentation * copy-docs -to-talawa branch update to develop * removed dependance of code copying from generate segment * Update push.yml (#969) * Update push.yml (#970) * Feature Request: Adding a dialog to go to plugin store after an organization is created by the admin (#951) * Add/ test for OrgPost.tsx * fix: org post back to default * Added Dialog 2 * Updated Dialog UI * Removed Extra code * Updated Plugin store * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * Fix: UI Redesign * fix: merge * fix * Update AddOnStore.tsx * Fixed Merge Errors * Add test: for OrgEntry * Test 3 * fix test 4 * Merge latest AdminUI Redesign into develop (#972) * Initial Organizations screen done * Removed yellow scrollbar * Linting fixed * Replaced images with svgs for logos * Styling done for btnsContainer * Better typechecking and readability * Animated Drawer working * Responsive page ready * OrgCard responsive * Fixed navbar issue and added webkit keyframes * LeftDrawer ready * Translations added * Added shimmer loading effect * Styling issue fixed * Failing tests fixed for OrgList * Removed unused vars * Tests done for LeftDrawer * Succesfully made component without causing any breaking change * 100% Code coverage achieved for Requests Screen * Fix alignment * Roles screen UI done * Role screen fixed with 100% test coverage * Changing screen activeness fixed * Unused vars and Typos fixed * Language support added * Linting and typos fixed * Fixed failing tests for LeftDrawer * Completed tests of AdminDashListCard with 100% code coverage * OrgListCard done * Finalised tests * Requests user search made functional again ! * Fixed loading on refetch and UX on all screens * OrgList failing errors fixed * Fixed all failing tests * Achieved 100% code coverage for OrgList.tsx * Wrote tests and mod LeftDrawer for admins * Minor ui issue fixed * Fixed failing test * UI bug dropdown * Frontend insync with Backend attempt 1 * Introspection fail fix 1 * Introspection error fix 3 * Introspection error fix another attempt * Another attempt * Fixed Default Animation on Organizations Screen * Fixed typo * Loading data from localstorage functional * Fixed name conventions * Fixed typo * UI Fix * Changed screen name * Table Loader added * Added LeftOrg drawer and Organization screen comp to Screens * routesReducer tests fixed * Redundant adminNavbar removed from project * MemberDetail issue fixed * Achieved 100% code coverage for LeftDrawerOrg, Added Empty div in images * Fixed failing tests * Fix tests * Fixed warnings * Linting fixes * Linting issues fixed * Achieved 100% code coverage for CollapsibleDropdown * Achieved 100% CC on IconComponent and removed useless imports * Achieved 100% cc for LeftDrawer Component * Achieved 100% CC on SuperAdminScreen Component * Fixed typo * Integrated Event Dashboard * Failing tests for LeftDrawer LeftDrawerOrg OrgList screen fixed * Removed redundant code * Removed useless imports * Linting fixed * Removed LeftDrawerOrg * Dashboard screen ui almost ready * Org Dash ready * Block/Unblock screen ready * Organization settings page ready * Lang changes * Page refresh on updating org removed * OrgUpdate tests done * OrgUpdate 100% test coverage achieved * OrgSettings Tests done * Organization Dashboard Cards done * Organization Dashboard achieved 100% CC * 100% CC achieved for BlockUser screen * Finalised changes * Small change * Tests fixed * Separate OrgSettings component made * Linting fixed * Formatting fixed * Events screen and Post Comment Modal for Talawa-user-portal (#963) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Add Settings and Donate Screen * Add multilingual support for the screens * Add events screen without calendar view * Add multilingual support to Events screen * Fix failing tests due to merge * Add Post Comment functionality * Refactor Events tests * Deprecate event registrants from query * Update README.md * Add My Tasks screen and Fix UI bugs [User Portal] (#978) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Add Settings and Donate Screen * Add multilingual support for the screens * Add events screen without calendar view * Add multilingual support to Events screen * Fix failing tests due to merge * Add Post Comment functionality * Refactor Events tests * Deprecate event registrants from query * Add my tasks screen for user portal * Remove unnecessary comments from test files * Add Feedback UI Components to Talawa Admin (#980) * Add feedback component * Add tests for feedback modal * Add handling for empty feedback * Add Average Rating and Reviews component * Add testing for all the added cards * Fix tests and move to 100% coverage * Add bugfix * Add merge function to fix failing tests * Add key definitons * Change merge policy * Add custom merge policy to all the Event Stat tests * remove cache * Migrate to a single query in the parent * Adding Plugin Logic to the Talawa Mobile Web App (#976) * Add/ test for OrgPost.tsx * fix: org post back to default * Added Dialog 2 * Updated Dialog UI * Removed Extra code * Updated Plugin store * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * Fix: UI Redesign * fix: merge * fix * Update AddOnStore.tsx * Fixed Merge Errors * Add test: for OrgEntry * Test 3 * fix test 4 * chores: version changes * Add: Initial Websocket setup on talawa mobile web * Add: plugin logic * Add: plugin logic * removed extra * removed extra * Added: Tests * fix * Add Side Navigation to Event Dashboard (#981) * Create left drawer for event dashboard * Add basic styles to the event dashboard * Fix button styling * Add testing * Add testing for the left event drawer * Add 100% line coverage for all components * Increase timeout for tests * Move maximum rating in feedback from 10 to 5 [Fixes #990] (#987) * Move maximum rating in feedbacks from 10 to 5 * Fix failing tests * Add chat screen to talawa-user-portal (#986) * Create login and register page for user portal * Lint public locales * Create tests for login page components * Add react import in tests * Create organizations screen for user portal * Fix failing tests and lint code * fix failing tests * Add tests for organization screen and componenets * Fix non-null assertions * Fix non-null assertions in organizations test * Fix bootstrap migration changes * Add Home Screen along with other components * Fix failing tests * Add required tests and Offcanvas navbar * Remove unused variables from tests * Sync the Mutations with talawa-api * Add Settings and Donate Screen * Add multilingual support for the screens * Add events screen without calendar view * Add multilingual support to Events screen * Fix failing tests due to merge * Add Post Comment functionality * Refactor Events tests * Deprecate event registrants from query * Add my tasks screen for user portal * Remove unnecessary comments from test files * Add chat screen along with components * Add mui/system package for x-chart support * Add chat screen tests and fix other bugs * Update issue.yml * Update stale.yml * Merge latest AdminUI Redesign into Master (#1006) * Pagination Done for Orglist * Fixed warnings * Infinite scroll and search working for Requests screen * Simplified the code * Infinite scroll enabled and functioning on OrgList Requests and Users screen * FIxed warning * Fixed typo * Fixed bug * Joined and Blockedbyorgs screen and mdoal ready * Tables ready ! * Remove user from organization functionality working well * Update user role in organization feature ready * Minor changes * Done with tests on OrgList * Done with testss of Requests screen * 100% CC achieved for Users screen * Main tests done for UserTableItem * 100% Code Coverage Achieved for UserTableItem * Removed Redundant Landing Page * 100% CC achieved for TableLoader * Translation added for Users Screen * Translation done for Requests screen * Translation done for dashboard screen * Linting and warnings fixed * Improved login page * UI Done for Forgot Password Screen * Forgot Password Screen Tests done! * Fixed all pending tests * Better message for btns and coloring * Linting issues fixed * Fixed code styles * SUPPRESSED UNKNOWN ERROR * Fixed formatting * Updated typoed message * Fixed failing tests accompanying typo * fix createEvent to close modal and show events without refresh (#1014) * fix: Ensure Full Visibility of Logo on 404 Error Page (#1018) - Adjusted the positioning of the logo on the 404 error page to ensure full visibility. - Implemented CSS modifications to prevent the logo from being covered or cut off. - Tested the changes by navigating to various undefined endpoints, confirming that the logo is now displayed correctly on the 404 error page. This commit addresses the bug by ensuring the proper display of the logo on the 404 error page, enhancing the user experience. Fixes #1016 Signed-off-by: Akhilender <akhilenderb9@gmail.com> * Implemented featurs for Postfeed Management (#982) * redesigned newsfeed * added test * newsfeed management * pinned post * postfeed management * pin unpin tag and video control * changes part 2 * newsfeed changes * changes in Card Preview of newsfeed * changes in Card Preview of newsfeed * testing phase 1 * translation * tests * tests * merged intto develop * test * Added query * Update pull-requests.yml * update and delete buttons of event modal are now working (#1051) * update and delete buttons of event modal are now working * fixed the naming conventions and style of the modal * Dynamic dashboard Enhancements (#979) * Dynamic Organization Dashboard * Dynamic Organization Dashboard * refined organization dashboard * Update src/utils/handleLatestFeed.ts Co-authored-by: Noble Mittal <62551163+beingnoble03@users.noreply.github.com> * fixed inconsistent casing * fixed org dashboard test * fixed org dashboard test * revert previous commit * final changes * final changes --------- Co-authored-by: Noble Mittal <62551163+beingnoble03@users.noreply.github.com> * Fix dashboard items (#1007) * Dashboard items are working now. * added variables for links -fix dashboard items * Added variables for links -fix dashboard items. * made the changes as said * Removed : string from variable assignment. * remove repititive code and resolved falling tests * Fix repeating code and falling tests. * Resolved some more falling tests * write test for missed lines * Fix event creation issue with white spaces. (#1025) * fix event creation with white spaces * Add test for empty input values * chore: fix unit test (#1052) * Fix layout distortion due to untruncated title description of events. (#1049) * Fix layout distortion due to untruncated title description of events * Add test * add test for LeftDrawerEvent.tsx * fixed some tests * add test complete * test: SecuredRouteForUser component 100% Test Coverage and fixed uncovered lines (#1048) * SecuredRouteForUser test case added * Fixed Linting Errors * Update SecuredRouteForUser.test.tsx * Update SecuredRouteForUser.test.tsx * linting fix * Update SecuredRouteForUser.test.tsx * Update SecuredRouteForUser.test.tsx * Fix incorrect toast Notification. (#1053) * correct toast notification for TableRow.tsx with full test coverage * Add correct toast with full code coverage * Add correct toast for deleteEventProjectModal.tsx with full test coverage * Add correct toast for UpdateEventProjectModal.tsx with full test coverage * Add correct toast for EventRegistrantsModal.tsx and full test coverage. * Add correct toast for AddTaskModal.tsx with full test coverage * Add correct toast for UpdateTaskModal.tsx with full test coverage * minor fix * Add correct toast to EventRegistrantsModal.tsx * fix EventRegitrantsModal.tsx * created a return button on event dashboard (#1057) * test: Loader Component 100% Test Coverage and Fix Uncovered Lines (#1047) * test: Achieve 100% Test Coverage and Fix Uncovered Lines - Improved the test coverage for the Loader component, addressing the previously uncovered lines and ensuring that all tests pass successfully. - Added a test to ensure that the component renders correctly with a custom 'sm' size. I verified that both the spinner-wrapper and spinner elements are present and that the correct class is applied. - Added a test to ensure that the component renders correctly with a 'lg' size. I verified that the spinner element has the appropriate class. - Added a test to ensure that the component renders correctly with an 'xl' size. I verified that the spinner element has the correct class. With these new tests, I now have 100% test coverage, and there are no more uncovered lines. The Loader component is thoroughly tested for different size scenarios, and all tests pass successfully. Signed-off-by: Akhilender <akhilenderb9@gmail.com> * Fixed linting in Loader component Signed-off-by: Akhilender <akhilenderb9@gmail.com> * Test: Increasing the test level - Trying to meet the code coverage level for Loader component. Signed-off-by: Akhilender <akhilenderb9@gmail.com> * Fixed Linting Signed-off-by: Akhilender <akhilenderb9@gmail.com> * fix: Linting Signed-off-by: Akhilender <akhilenderb9@gmail.com> * Improving test coverage for Loader Component - Fixed lint errors Signed-off-by: Akhilender <akhilenderb9@gmail.com> * test: Improving the tests on the Loader Component - Added a new aspect in the test-case1 Signed-off-by: Akhilender <akhilenderb9@gmail.com> * Fixed: Removed runtime-generated classes from testing - Eliminated all checks for classes associated with bootstrap components assigned at runtime. - Recognized that validating classes assigned during runtime is inappropriate. Signed-off-by: Akhilender <akhilenderb9@gmail.com> --------- Signed-off-by: Akhilender <akhilenderb9@gmail.com> * Simulated Test Database (#984) * Dynamic Organization Dashboard * Dynamic Organization Dashboard * Sample Org Implementation * removed unnecessary changes * removed unnecessary svgs * removed unnecessary import * added appropriate button style * fixed OrgListCard tests * Fixed OrgList and OrgListCard Tests * Removed Unnecessary 'container' Variable * Added Missing Translations and removed unused variable * Fixed event check in management not updating automatically bug (#1062) * fixed the event checkIn bug * fixed the failing test * fixed the CheckInWrapper test * Fix user profile buttons layout and added form validation (#1064) * Fix user profile buttons layout and added form validation * Fix falling tests and warnings * Add test for missed lines * fix falling tests * test: Achieved 100% test coverage and fixed uncovered lines (#1068) * test: Achieved 100% test coverage and fixed uncovered lines - Improved the test coverage for the User-Password-Update component, addressing the previously uncovered lines and ensuring that all tests pass successfully. - Added two new tests 1. Empty Password Field Test: - The first test ensures that an error is displayed when attempting to save changes with an empty password field. 2. Mismatched New and Confirm Passwords Test - The second test covers the scenario where the new and confirm password fields do not match. With these new tests, I now have 100% test coverage, and there are no more uncovered lines. Signed-off-by: Akhilender <akhilenderb9@gmail.com> * Altered the formData - Altered the formData to make sure all are related to the organization name. Signed-off-by: Akhilender <akhilenderb9@gmail.com> --------- Signed-off-by: Akhilender <akhilenderb9@gmail.com> * created test for src/components/UserPortal/EventCard/EventCard.tsx (#1079) * created test for eventCard of User portal * corrected the start and end time * Feature request: Adding advertisement screen (#994) * Add/ test for OrgPost.tsx * fix: org post back to default * Added Dialog 2 * Updated Dialog UI * Removed Extra code * Updated Plugin store * fix: warnings and solves #951 & #948 * fix: warnings and solves #951 & #948 * fix: warnings and solve…
…ations" button (PalisadoesFoundation#1124) * Changes position and text of all organization button * Made changes to the routesReducer.test file * Made changes in IconComponent.test file * Fetched changes from main repo * Fixed unnecessary changes --------- Co-authored-by: Aditya Agarwal <adi790u@gmail.com>
… Organizations" button (PalisadoesFoundation#1124)" (PalisadoesFoundation#1183) This reverts commit 1fd4105.
* Added Base branch check to main * Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop to main * Deleted all main files * Merged develop into main
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main * Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.15 to 6.2.1. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.15...v6.2.1) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…lisadoesFoundation#1961) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40 to 41. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v40...v41) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10. - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.9...v3.1.10) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tion#2020) * Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main --------- Co-authored-by: Peter Harrison <peter@colovore.com>
* 20240727112607 Deleted all files in the main branch in anticipation of merging develop into main cleanly * 20240727112842 Merge develop into main
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
WalkthroughThe changes introduce a structured configuration and enhancements across various files for the Talawa project, focusing on coding standards, automated tools, and UI component styling. Notable updates include the introduction of new YAML configurations for a language server, environment settings for development, and refined SCSS styles for UI components. These modifications aim to improve maintainability, coding practices, and overall user experience, while also ensuring better collaboration and contribution processes. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant Server
participant LintingTool
participant Workflow
User->>UI: Interacts with components
UI->>Server: Sends data
Server-->>UI: Returns response
UI->>LintingTool: Checks code quality
LintingTool-->>UI: Provides feedback
UI->>Workflow: Triggers actions for PRs/issues
Workflow-->>User: Acknowledges interactions
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 50
Outside diff range, codebase verification and nitpick comments (60)
scripts/githooks/update-toc.js (1)
4-6
: Ensure the script is run in the correct directory.The script assumes it is run in a directory containing markdown files. Consider adding a check or documentation to ensure users run it in the correct context.
if (markdownFiles.length === 0) { console.warn('No markdown files found in the current directory.'); }public/locales/en/errors.json (1)
5-5
: Correct capitalization in the message.The word "Authorised" should not be capitalized mid-sentence.
- "Sorry! you are not Authorised!" + "Sorry! you are not authorised!"public/locales/sp/errors.json (7)
2-2
: Translate message to Spanish.The message "Talawa-API service is unavailable!..." should be translated to Spanish for consistency.
- "Talawa-API service is unavailable!. Is it running? Check your network connectivity too." + "¡El servicio Talawa-API no está disponible! ¿Está en funcionamiento? Verifique también su conectividad de red."
3-3
: Translate message to Spanish.The message "Not found" should be translated to Spanish for consistency.
- "Not found" + "No encontrado"
4-4
: Translate message to Spanish.The message "An unknown error occurred..." should be translated to Spanish for consistency.
- "An unknown error occurred. Please try again later. {{msg}}" + "Ocurrió un error desconocido. Por favor, inténtelo de nuevo más tarde. {{msg}}"
5-5
: Translate message to Spanish.The message "Sorry! you are not Authorised!" should be translated to Spanish for consistency.
- "Sorry! you are not Authorised!" + "¡Lo sentimos! No está autorizado."
6-6
: Translate message to Spanish.The message "Error sending mail" should be translated to Spanish for consistency.
- "Error sending mail" + "Error al enviar correo"
7-7
: Translate message to Spanish.The message "Email not registered" should be translated to Spanish for consistency.
- "Email not registered" + "Correo electrónico no registrado"
8-8
: Translate message to Spanish.The message "Oops! The Page you requested..." should be translated to Spanish for consistency.
- "Oops! The Page you requested was not found!" + "¡Vaya! La página que solicitó no fue encontrada."src/GraphQl/Mutations/AgendaItemMutations.ts (1)
12-18
: Input Validation Missing forremoveAgendaItemId
The codebase does not currently implement input validation for
removeAgendaItemId
in theDELETE_AGENDA_ITEM_MUTATION
. It is recommended to add validation to ensure that the ID is valid before processing the mutation to prevent potential errors or security issues.
- Consider adding validation logic in the mutation resolver or before invoking the mutation.
Analysis chain
Ensure input validation for
DELETE_AGENDA_ITEM_MUTATION
.Verify that the
removeAgendaItemId
is validated to ensure it is a valid ID before processing the mutation.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify input validation for `removeAgendaItemId`. # Test: Search for validation logic related to `removeAgendaItemId`. Expect: Validation logic should be present. rg --type typescript 'removeAgendaItemId' -A 5Length of output: 81
Script:
#!/bin/bash # Description: Verify input validation for `removeAgendaItemId`. # Test: Search for validation logic related to `removeAgendaItemId`. Expect: Validation logic should be present. rg --type ts 'removeAgendaItemId' -A 5Length of output: 2317
.github/ISSUE_TEMPLATE/bug-report.md (1)
33-34
: Clarify the purpose of the new section.The section "Potential internship candidates" provides a link for internship applications. Ensure that this section is relevant to the bug report template and consider adding a brief explanation of why it's included here.
+ **Potential internship candidates** + If you're interested in applying for a Palisadoes Foundation internship, please refer to the following link for more information: https://github.com/PalisadoesFoundation/talawa/issues/359src/GraphQl/Mutations/ActionItemCategoryMutations.ts (1)
10-16
: Implement Error Handling for CREATE_ACTION_ITEM_CATEGORY_MUTATIONThe
CREATE_ACTION_ITEM_CATEGORY_MUTATION
is used insrc/components/OrgActionItemCategories/OrgActionItemCategories.tsx
without explicit error handling. Please ensure that error handling is implemented to manage potential GraphQL errors effectively.
- File:
src/components/OrgActionItemCategories/OrgActionItemCategories.tsx
Analysis chain
Ensure proper error handling for GraphQL mutations.
The
CREATE_ACTION_ITEM_CATEGORY_MUTATION
is well-structured, but ensure that error handling is implemented wherever this mutation is used in the application to manage potential GraphQL errors effectively.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify usage of `CREATE_ACTION_ITEM_CATEGORY_MUTATION` for error handling. # Test: Search for the mutation usage. Expect: Error handling logic present. rg --type javascript 'CREATE_ACTION_ITEM_CATEGORY_MUTATION'Length of output: 94
Script:
#!/bin/bash # Corrected command to search for the usage of `CREATE_ACTION_ITEM_CATEGORY_MUTATION`. rg 'CREATE_ACTION_ITEM_CATEGORY_MUTATION' --type js -A 5Length of output: 56
Script:
#!/bin/bash # Search for the usage of `CREATE_ACTION_ITEM_CATEGORY_MUTATION` across all file types. rg 'CREATE_ACTION_ITEM_CATEGORY_MUTATION' -A 5 # Confirm the definition of `CREATE_ACTION_ITEM_CATEGORY_MUTATION` in the expected file. rg 'export const CREATE_ACTION_ITEM_CATEGORY_MUTATION' src/GraphQl/Mutations/ActionItemCategoryMutations.ts -A 5Length of output: 4407
Script:
#!/bin/bash # Search for error handling patterns in `OrgActionItemCategories.tsx` where `CREATE_ACTION_ITEM_CATEGORY_MUTATION` is used. rg 'CREATE_ACTION_ITEM_CATEGORY_MUTATION' src/components/OrgActionItemCategories/OrgActionItemCategories.tsx -A 10 | rg 'catch|error|onError|try'Length of output: 145
src/assets/scss/_general.scss (1)
1-3
: Consider using a more comprehensive font stack.The font stack includes Arial, Helvetica, and sans-serif. Consider adding more fonts for better cross-platform consistency.
- --bs-body-font-family: Arial, Helvetica, sans-serif; + --bs-body-font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";.github/workflows/codeql-codescan.yml (1)
12-13
: Ensure the workflow name is descriptive.The workflow name is "codeql codescan workflow." Consider making it more descriptive to indicate its purpose clearly.
- name: codeql codescan workflow + name: CodeQL Code Scanning Workflowsrc/assets/scss/components/_dropdown.scss (1)
1-35
: Consider using a consistent naming convention for SCSS variables.The current naming convention mixes hyphenated and underscored variable names. It's a good practice to maintain consistency in naming conventions for better readability and maintainability.
- $dropdown-min-width: 10rem; - $dropdown-padding-x: 0; - $dropdown-padding-y: 0.5rem; + $dropdown_min_width: 10rem; + $dropdown_padding_x: 0; + $dropdown_padding_y: 0.5rem;.github/workflows/issue.yml (1)
12-35
: The link to the CONTRIBUTING.md file is not accessible.The link to the
CONTRIBUTING.md
file in the greeting message does not return a successful HTTP status, indicating it might be incorrect or the file is missing. Please verify the path and ensure the file is available. The link to theISSUE_GUIDELINES.md
file is correct and accessible.
- Link to
CONTRIBUTING.md
: Verify the URL or check if the file exists.- Link to
ISSUE_GUIDELINES.md
: Confirmed to be correct.Analysis chain
Ensure the greeting message links are correct and accessible.
Verify that the links in the greeting message point to the correct and accessible resources for contributors. This ensures new contributors receive accurate guidance.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the accessibility of links in the greeting message. # Test: Check if the links are accessible. Expect: HTTP status 200. curl -I https://github.com/PalisadoesFoundation/talawa-admin/blob/develop/CONTRIBUTING.md | grep 'HTTP/2 200' curl -I https://github.com/PalisadoesFoundation/talawa-admin/blob/develop/ISSUE_GUIDELINES.md | grep 'HTTP/2 200'Length of output: 965
DOCUMENTATION.md (2)
26-26
: Capitalize "Markdown" as a proper noun.The word "markdown" should be capitalized as "Markdown" since it refers to the formatting language.
- Add/modify the markdown documents to the `docs/` directory of the `talawa-docs` repository + Add/modify the Markdown documents to the `docs/` directory of the `talawa-docs` repositoryTools
LanguageTool
[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to thedocs/
directory of t...(MARKDOWN_NNP)
32-32
: Use "to" instead of "in".The sentence "do not add markdown files in this repository" should use "to" instead of "in."
- ***PLEASE*** do not add markdown files in this repository. Add them to `talawa-docs`! + ***PLEASE*** do not add markdown files to this repository. Add them to `talawa-docs`!Tools
LanguageTool
[uncategorized] ~32-~32: The preposition “to” seems more likely in this position.
Context: ... PLEASE do not add markdown files in this repository. Add them to `talawa-do...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
src/GraphQl/Mutations/VenueMutations.ts (2)
7-7
: Correct typographical error in the comment.The word "Ineteger" should be corrected to "Integer."
- * @param capacity - Ineteger representing capacity of venue. + * @param capacity - Integer representing capacity of venue.
39-39
: Correct typographical error in the comment.The word "Ineteger" should be corrected to "Integer."
- * @param capacity - Ineteger representing capacity of venue. + * @param capacity - Integer representing capacity of venue.src/GraphQl/Queries/ActionItemQueries.ts (1)
3-12
: Inconsistent parameter naming between documentation and query.The parameter names in the documentation do not match those in the query implementation. Specifically:
actionItemCategory_id
should beactionItemCategoryId
.event_id
should beeventId
.Please update the documentation to ensure consistency with the query parameters.
Analysis chain
Verify parameter consistency between documentation and query.
Ensure that the parameter names in the documentation match those in the query, such as
actionItemCategory_id
vs.actionItemCategoryId
.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify parameter consistency between documentation and query. # Test: Search for parameter names in the documentation and query. Expect: Consistent naming conventions. rg --type ts -A 10 $'GraphQL query to retrieve action item categories by organization.'Length of output: 2160
Script:
#!/bin/bash # Search for the query implementation in ActionItemQueries.ts to verify parameter names. rg --type ts 'ACTION_ITEM_LIST' -A 10Length of output: 28925
ISSUE_GUIDELINES.md (3)
3-3
: Consider simplifying the sentence.The sentence is wordy and can be shortened for clarity.
-:+1::tada: First off, thanks for taking the time to contribute! :tada::+1: +:+1::tada: Thanks for contributing! :tada::+1:
30-30
: Consider using a more formal verb."Verify" is more formal than "fix" in this context.
-Verify whether the issue has been fixed by trying to reproduce it using the latest master or development branch in the repository. +Verify whether the issue has been resolved by trying to reproduce it using the latest master or development branch in the repository.Tools
LanguageTool
[style] ~30-~30: Consider using a different verb for a more formal wording.
Context: .... 1. Verify whether the issue has been fixed by trying to reproduce it using the lat...(FIX_RESOLVE)
35-35
: Improve the wording for clarity.The sentence can be rephrased for better clarity and impact.
-We welcome contributors who find new ways to make the code better. +We welcome contributors who suggest improvements to the code.Tools
LanguageTool
[style] ~35-~35: The wording of this phrase can be improved.
Context: ...lcome contributors who find new ways to make the code better. ### Existing Issues You can also be ...(MAKE_STYLE_BETTER)
README.md (2)
56-56
: Consider adding a hyphen for compound adjectives.The phrase "new open source contributors" might be clearer with a hyphen: "new open-source contributors."
- 1. The "Getting Started - Developers" videos are extremely helpful for new open source contributors. + 1. The "Getting Started - Developers" videos are extremely helpful for new open-source contributors.Tools
LanguageTool
[uncategorized] ~56-~56: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...s" videos are extremely helpful for new open source contributors.(EN_COMPOUND_ADJECTIVE_INTERNAL)
3-3
: Incorrect Slack Link in README.mdThe link labeled "Join the community on Slack" in the README.md file points to a GitHub page instead of a Slack invite link. Please update it to the correct Slack link.
- Current link:
[💬 Join the community on Slack](https://github.com/PalisadoesFoundation/)
Analysis chain
Verify Slack link accuracy.
Ensure that the Slack link is correct and leads to the intended community page.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the Slack link in the README.md file. # Test: Check if the Slack link is correct. rg --type md $'\\[💬 Join the community on Slack\\]\\(https://github.com/PalisadoesFoundation/\\)'Length of output: 180
package.json (1)
5-5
: CommonJS syntax detected in ES module project.The addition of
"type": "module"
inpackage.json
requires all scripts to be compatible with ES module syntax. However, the following files contain CommonJS imports and exports:
scripts/config-overrides/index.js
: Usesrequire
andmodule.exports
.scripts/config-overrides/custom_build.js
: Usesrequire
.scripts/config-overrides/custom_start.js
: Usesrequire
.Please verify these scripts and consider refactoring them to use ES module syntax.
Analysis chain
Module type declaration.
The addition of
"type": "module"
indicates a shift to ES module syntax. Ensure all scripts and imports are compatible with this change.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility with ES module syntax. # Test: Check for commonJS imports. Expect: No commonJS imports. rg --type js 'require('Length of output: 92
Script:
#!/bin/bash # Description: Verify compatibility with ES module syntax. # Test: Check for CommonJS imports and exports. Expect: No CommonJS imports or exports. rg --type js 'require\(' rg --type js 'module\.exports'Length of output: 597
PR_GUIDELINES.md (5)
1-3
: Introduction and purpose.The introduction sets a positive tone for contributors. Consider addressing the LanguageTool suggestion to improve punctuation and conciseness.
- :+1::tada: First off, thanks for taking the time to contribute! :tada::+1: + :+1::tada: Thanks for contributing! :tada::+1:Tools
LanguageTool
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Pull Request Guidelines 👍🎉 First off, thanks for taking t...(UNLIKELY_OPENING_PUNCTUATION)
27-42
: Linting and formatting scripts.Providing scripts for linting and formatting ensures code consistency. Consider specifying the language in code blocks for clarity.
- ``` + ```bashTools
Markdownlint
31-31: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
39-39: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
46-47
: Testing requirements.Emphasizes the importance of testing in PRs. Address the LanguageTool suggestion to avoid split infinitives for improved readability.
- you'll need to tell us what steps you followed to manually test your changes. + you'll need to tell us what steps you followed to test your changes manually.Tools
LanguageTool
[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...(SPLIT_INFINITIVE)
56-56
: Reviewer assignment importance.The importance of reviewer assignment is well-explained. Consider addressing the LanguageTool suggestion for improved clarity.
- Therefore we make experienced maintainers of our code base review your code. + Therefore, we have experienced maintainers review your code.Tools
LanguageTool
[style] ~56-~56: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...o be closed. The quality of our code is very important to us. Therefore we make experienced ma...(EN_WEAK_ADJECTIVE)
[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ty of our code is very important to us. Therefore we make experienced maintainers of our ...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
64-64
: Communication etiquette.Encourages patience and proper communication. Consider addressing the LanguageTool suggestion for improved sentence structure.
- we get and it won't make us look at your issue faster. + we get, and it won't make us look at your issue faster.Tools
LanguageTool
[style] ~64-~64: This expression is wordy and overused. Consider replacing it with a more concise and formal alternative.
Context: ...wer your questions, but we'll get to it sooner or later. @mentioning someone just adds to the p...(SOONER_OR_LATER)
[uncategorized] ~64-~64: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...adds to the pile of notifications we get and it won't make us look at your issue fas...(COMMA_COMPOUND_SENTENCE)
.github/workflows/push.yml (2)
34-48
: Improve cache key specificity.The cache key includes
hashFiles('**/package-lock.json')
, which is good for ensuring cache validity. However, if there are multiplepackage-lock.json
files in different directories, consider specifying the path more precisely to avoid unintended cache misses.
70-71
: Remove commented-out code.The lines for pulling the latest changes from the develop branch are commented out. If not needed, consider removing them to keep the workflow clean.
- # - name: Pull latest changes from develop - # run: git pull origin develop.github/workflows/countline.py (1)
197-294
: Consider improving clarity in error message.The
main
function is comprehensive and effectively performs file analysis. Consider adding more context to the error message for better clarity.- LINE COUNT ERROR: Files with excessive lines of code have been found\n + LINE COUNT ERROR: The following files exceed the allowed line count limit:\nsrc/App.tsx (2)
51-185
: Consider renamingapp
toApp
for consistency.The
app
function is well-structured and effectively manages routing and session management. Consider renaming it toApp
to maintain consistency with React component naming conventions.- function app(): JSX.Element { + function App(): JSX.Element {
189-189
: Align export with naming convention.Consider aligning the export statement with the suggested naming convention for consistency.
- export default app; + export default App;.github/workflows/pull-request.yml (4)
24-24
: Clarify job name for better understanding.The job name "Performs linting, formatting, type-checking, checking for different source and target branch" is lengthy. Consider shortening it for clarity.
name: Code Quality Checks
71-77
: Improve error message clarity for branch checks.The error message for identical source and target branches could be more descriptive. Consider revising for better understanding.
echo "Error: The source branch '${{ github.event.pull_request.head.ref }}' and target branch '${{ github.event.pull_request.base.ref }}' are the same. Please ensure they are different."
111-119
: Improve unauthorized file change detection.The script lists unauthorized files but exits immediately after listing. Consider logging the unauthorized files for better traceability before exiting.
for file in ${CHANGED_UNAUTH_FILES}; do echo "::error::$file is unauthorized to change/delete" done exit 1
138-147
: Clarify error message for excessive file changes.The error message for too many changed files could be more informative. Consider adding potential solutions or next steps.
echo "Error: Too many files (greater than 100) changed in the pull request." echo "Possible issues:" echo "- Contributor may be merging into an incorrect branch." echo "- Source branch may be incorrect, please use 'develop' as the source branch." echo "Please review the changes and ensure they are necessary."CODE_STYLE.md (5)
5-7
: Clarify adherence to code style.The statements about code style adherence are repetitive. Consider merging them for clarity.
The code style must be strictly adhered to, ensuring consistency throughout contributions to Talawa Admin. Changes to the code style are not permitted.
127-137
: Address markdownlint issues in list indentation.The list indentation does not comply with markdownlint rules. Consider adjusting indentation for consistency.
- - `css` - This houses all of the css files used in the project - - `images` - This houses all of the images used in the project +`css` - This houses all of the css files used in the project +`images` - This houses all of the images used in the projectTools
LanguageTool
[style] ~127-~127: Consider removing “of” to be more concise
Context: ...tories ofsrc
assets
- This houses all of the static assets used in the project - `...(ALL_OF_THE)
[style] ~128-~128: Consider removing “of” to be more concise
Context: ... in the project -css
- This houses all of the css files used in the project - `imag...(ALL_OF_THE)
[style] ~129-~129: Consider removing “of” to be more concise
Context: ... the project -images
- This houses all of the images used in the project -scss
-...(ALL_OF_THE)
[style] ~130-~130: Consider removing “of” to be more concise
Context: ...in the project -scss
- This houses all of the scss files used in the project - `c...(ALL_OF_THE)
[grammar] ~134-~134: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ...rms -_talawa.scss
- Partial Sass file for Talawa -_utilities.scss
- Pa...(HE_VERB_AGR)
[grammar] ~135-~135: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... -_utilities.scss
- Partial Sass file for utilities -_variables.scss
-...(HE_VERB_AGR)
[grammar] ~136-~136: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... -_variables.scss
- Partial Sass file for variables -app.scss
- Main S...(HE_VERB_AGR)
Markdownlint
128-128: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
129-129: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
130-130: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
131-131: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
132-132: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
133-133: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
134-134: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
135-135: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
136-136: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
137-137: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
239-247
: Specify language for fenced code blocks.The fenced code blocks lack a specified language, which can hinder readability. Consider specifying the language for syntax highlighting.
```bash npx sass src/assets/scss/app.scss src/assets/css/app.css --watch<details> <summary>Tools</summary> <details> <summary>Markdownlint</summary><blockquote> 239-239: null Fenced code blocks should have a language specified (MD040, fenced-code-language) --- 245-245: null Fenced code blocks should have a language specified (MD040, fenced-code-language) </blockquote></details> </details> --- `120-121`: **Missing linting steps in CI/CD pipeline.** The CI/CD pipeline currently includes testing but lacks linting steps. To comply with the code style guidelines, ensure that linting is also enforced in the pipeline. - Consider adding `npm run lint` to the GitHub Actions workflows. <details> <summary>Analysis chain</summary> **Ensure test and linting compliance.** The document mandates unit tests and linting for all submissions. Verify that this compliance is enforced in the CI/CD pipeline. </details> <details> <summary>Scripts executed</summary> The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Description: Verify test and linting compliance in CI/CD pipeline. # Test: Check for test and linting steps in GitHub Actions workflows. rg 'npm run test' .github/workflows/
Length of output: 221
Script:
#!/bin/bash # Description: Verify linting compliance in CI/CD pipeline. # Test: Check for linting steps in GitHub Actions workflows. rg 'npm run lint' .github/workflows/Length of output: 38
162-167
: Import Order Inconsistencies DetectedThe import order specified in the
CODE_STYLE.md
is not consistently followed across the codebase. Many files have incorrect import groupings, which do not adhere to the specified order of React imports, third-party imports, and local imports.Here are some files with incorrect import orders:
setup.ts
jest-preview.config.ts
scripts/test.js
jest.config.js
src/utils/useLocalstorage.ts
src/state/store.ts
src/state/index.ts
src/utils/recurrenceUtils/recurrenceConstants.ts
src/utils/recurrenceUtils/index.ts
src/utils/linkValidator.ts
src/utils/languages.ts
src/utils/i18n.ts
src/utils/interfaces.ts
src/utils/i18nForTest.ts
src/utils/getRefreshToken.ts
src/utils/errorHandler.tsx
src/state/reducers/routesReducer.ts
src/state/action-creators/index.ts
src/screens/OrganizationFundCampaign/OrganizationFundCampaignMocks.ts
src/screens/OrganizationEvents/OrganizationEventsMocks.ts
src/screens/OrganizationActionItems/OrganizationActionItemsErrorMocks.ts
src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts
src/screens/OrganizationActionItems/OrganizationActionItemMocks.ts
src/screens/OrgList/OrgListMocks.ts
src/screens/FundCampaignPledge/PledgesMocks.ts
src/screens/FundCampaignPledge/PledgeModal.tsx
src/screens/FundCampaignPledge/FundCampaignPledge.tsx
src/screens/OrganizationAgendaCategory/OrganizationAgendaCategoryErrorMocks.ts
src/screens/OrganizationAgendaCategory/OrganizationAgendaCategoryMocks.ts
src/components/Venues/VenueCard.tsx
src/components/plugins/index.ts
src/GraphQl/Queries/Queries.ts
src/GraphQl/Queries/fundQueries.ts
src/GraphQl/Queries/PlugInQueries.ts
src/GraphQl/Queries/OrganizationQueries.ts
src/GraphQl/Queries/AgendaItemQueries.ts
src/GraphQl/Queries/AgendaCategoryQueries.ts
src/GraphQl/Queries/ActionItemQueries.ts
src/components/plugins/DummyPlugin/DummyPlugin.tsx
src/Constant/constant.ts
src/Constant/constant.spec.ts
src/components/UserPortal/SecuredRouteForUser/SecuredRouteForUser.tsx
src/screens/UserPortal/Organizations/Organizations.test.tsx
src/components/RequestsTableItem/RequestsTableItemMocks.ts
src/components/SecuredRoute/SecuredRoute.tsx
src/components/Pagination/Pagination.tsx
src/components/OrgUpdate/OrgUpdateMocks.ts
src/components/OrgPeopleListCard/OrgPeopleListCard.tsx
src/components/OrgDelete/OrgDelete.tsx
src/components/OrgAdminListCard/OrgAdminListCard.tsx
src/components/IconComponent/IconComponent.tsx
src/components/IconComponent/IconComponent.test.tsx
src/components/EventRegistrantsModal/EventRegistrantsModal.tsx
src/components/EventStats/Statistics/AverageRating.tsx
src/components/EventStats/Statistics/Feedback.tsx
src/components/EventListCard/EventListCardProps.ts
src/components/EventListCard/EventListCardMocks.ts
src/components/EventCalendar/constants.js
src/components/EditCustomFieldDropDown/EditCustomFieldDropDown.tsx
src/components/AgendaCategory/AgendaCategoryContainerMocks.ts
src/components/ChangeLanguageDropdown/ChangeLanguageDropDown.tsx
src/components/AgendaCategory/AgendaCategoryContainerProps.ts
src/components/AgendaItems/AgendaItemsContainerMocks.ts
src/components/AgendaItems/AgendaItemsContainerProps.ts
src/components/AddOn/AddOn.tsx
src/components/AddOn/support/services/Render.helper.ts
src/components/AddOn/support/services/Plugin.helper.ts
src/components/AddOn/support/services/Plugin.helper.test.ts
src/components/AddOn/support/components/Action/Action.tsx
src/components/OrgActionItemCategories/OrgActionItemCategoryMocks.ts
src/components/ActionItems/ActionItemsModalBody.tsx
src/components/ActionItems/ActionItemsContainerProps.ts
src/components/ActionItems/ActionItemsContainerMocks.ts
src/components/AddOn/core/AddOnEntry/AddOnEntryMocks.ts
src/GraphQl/Queries/ActionItemCategoryQueries.ts
src/GraphQl/Mutations/OrganizationMutations.ts
src/GraphQl/Mutations/VenueMutations.ts
src/GraphQl/Mutations/mutations.ts
src/GraphQl/Mutations/CommentMutations.ts
src/GraphQl/Mutations/FundMutation.ts
src/GraphQl/Mutations/PledgeMutation.ts
src/GraphQl/Mutations/EventAttendeeMutations.ts
src/GraphQl/Mutations/AgendaItemMutations.ts
src/GraphQl/Mutations/CampaignMutation.ts
src/GraphQl/Mutations/AgendaCategoryMutations.ts
src/App.tsx
src/GraphQl/Mutations/ActionItemMutations.ts
src/GraphQl/Mutations/ActionItemCategoryMutations.ts
scripts/config-overrides/custom_start.js
scripts/config-overrides/custom_build.js
src/components/EventStats/Statistics/Review.tsx
scripts/config-overrides/index.js
src/components/EventManagement/EventAgendaItems/EventAgendaItemsMocks.ts
src/assets/svgs/social-icons/index.tsx
src/components/EventManagement/Dashboard/EventDashboard.mocks.ts
scripts/__mocks__/@dicebear/core.ts
scripts/__mocks__/@dicebear/collection.ts
Please review and correct the import orders in these files to ensure consistency with the code style guidelines.
Analysis chain
Clarify import grouping order.
The guideline specifies the order for import grouping. Ensure this order is consistently applied across the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify import grouping order in the codebase. # Test: Check for import grouping consistency. rg 'import ' src/Length of output: 357878
Script:
#!/bin/bash # Description: Check import grouping order in each file. # Find all TypeScript and JavaScript files and check the order of imports. fd -e ts -e tsx -e js -e jsx --exec bash -c ' echo "Checking {}" rg "^import " {} | awk " BEGIN { react = 0; third_party = 0; local = 0 } /import React/ { react = 1 } /import .* from '\''[^.]/ { if (react) third_party = 1 } /import .* from '\''\./ { if (third_party) local = 1 } END { if (!react || !third_party || !local) print \"Incorrect order in: \" FILENAME } " 'Length of output: 29352
Tools
LanguageTool
[uncategorized] ~165-~165: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...following order: - React imports - Third party imports - Local imports If there is...(EN_COMPOUND_ADJECTIVE_INTERNAL)
Markdownlint
164-164: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
165-165: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
166-166: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
CONTRIBUTING.md (1)
26-26
: Add "please" for a more polite tone.Consider adding "please" to the sentence for a more polite tone.
Let us know immediately if you have unacceptable experiences in this area, please.Tools
LanguageTool
[style] ~26-~26: This expression usually appears with a “please” in front of it.
Context: ...DUCT.md) to understand what this means. Let us know immediately if you have unacceptable ex...(INSERT_PLEASE)
INSTALLATION.md (8)
3-3
: Add a comma for clarity.Consider adding a comma after "in sequence" for better readability.
- The instructions are written to be followed in sequence so make sure to go through each of them step by step without skipping any sections. + The instructions are written to be followed in sequence, so make sure to go through each of them step by step without skipping any sections.Tools
LanguageTool
[uncategorized] ~3-~3: A comma might be missing here.
Context: ...tructions are written to be followed in sequence so make sure to go through each of them...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
24-24
: Remove repeated word.The word "Talawa-Admin" is repeated. Consider removing one instance.
- - [Running Talawa-Admin](#running-talawa-admin) - [Accessing Talawa-Admin](#accessing-talawa-admin) + - [Running Talawa-Admin](#running-talawa-admin) - [Accessing Talawa-Admin](#accessing-talawa-admin)Tools
LanguageTool
[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...](#running-talawa-admin) - Accessing Talawa-Admin - [Talawa-Admin Registration](#talawa-admin-registratio...(ENGLISH_WORD_REPEAT_RULE)
54-54
: Add a comma for clarity.Consider adding a comma after "the sections that follow" for better readability.
- The prerequisites are now installed. The next step will be to get the app up and running. + The prerequisites are now installed. The next step will be to get the app up and running.Tools
LanguageTool
[typographical] ~54-~54: It appears that a comma is missing.
Context: ... that follow. # Prerequisites In this section we'll explain how to set up all the pre...(DURING_THAT_TIME_COMMA)
60-60
: Use a hyphen for compound adjectives.Consider using a hyphen in "open source" to form the compound adjective "open-source."
- Basic `git` knowledge is required for open source contribution so make sure you're comfortable with it. + Basic `git` knowledge is required for open-source contribution, so make sure you're comfortable with it.Tools
LanguageTool
[uncategorized] ~60-~60: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: .... Basicgit
knowledge is required for open source contribution so make sure you're comfor...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[uncategorized] ~60-~60: Possible missing comma found.
Context: ...` knowledge is required for open source contribution so make sure you're comfortable with it...(AI_HYDRA_LEO_MISSING_COMMA)
66-66
: Correct verb usage.Use "set up" as a verb instead of "setup."
- navigate to the folder where you want to setup the repository. + navigate to the folder where you want to set up the repository.Tools
LanguageTool
[grammar] ~66-~66: The word “setup” is a noun. The verb is spelled with a space.
Context: ...avigate to the folder where you want to setup the repository. 2. Open acmd
(Window...(NOUN_VERB_CONFUSION)
154-154
: Add a comma for clarity.Consider adding a comma after "manually as well" for better readability.
- All the options in "setup" can be done manually as well and here's how to do it. + All the options in "setup" can be done manually as well, and here's how to do it.Tools
LanguageTool
[uncategorized] ~154-~154: Possible missing comma found.
Context: ...ions in "setup" can be done manually as well and here's how to do it. - [Creating .e...(AI_HYDRA_LEO_MISSING_COMMA)
158-158
: Use a comma before 'and' in a compound sentence.Consider adding a comma before "and you will have to create it."
- It is not a part of the repo and you will have to create it. + It is not a part of the repo, and you will have to create it.Tools
LanguageTool
[uncategorized] ~158-~158: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...at runtime. It is not a part of the repo and you will have to create it. For a sampl...(COMMA_COMPOUND_SENTENCE)
[uncategorized] ~158-~158: You might be missing the article “the” here.
Context: ...the contents of the.env.example
into.env
file. Use this command: ``` cp .e...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
286-286
: Add a verb for clarity.Consider adding "run" before "lint" for clarity.
- You can lint your code files using this command: + You can run lint on your code files using this command:Tools
LanguageTool
[grammar] ~286-~286: The word ‘lint’ is a noun or an adjective. A verb or adverb is missing or misspelled here, or maybe a comma is missing.
Context: ...w.webp) ## Linting code files You can lint your code files using this command: ``...(PRP_MD_NN)
public/locales/en/translation.json (4)
12-12
: Consistency Improvement: Remove period from key.The key "Password_and_Confirm_password_mismatches." contains a period, which is inconsistent with other keys. Consider removing it for consistency.
- "Password_and_Confirm_password_mismatches.": "Password and Confirm password mismatches." + "Password_and_Confirm_password_mismatches": "Password and Confirm password mismatches."
16-16
: Grammar Improvement: Use "Please try again later".The phrase "Please try after sometime" is less common. Consider using "Please try again later" for better clarity and standard usage.
- "Something_went_wrong": "Something went wrong, Please try after sometime." + "Something_went_wrong": "Something went wrong. Please try again later."
289-289
: Inconsistent Capitalization: "Created By" should be "Created by".For consistency with other entries, consider using "Created by".
- "createdBy": "Created By" + "createdBy": "Created by"
445-445
: Grammar Improvement: "information of the post" should be "information for the post".The phrase "Write information of the post" should be corrected to "Write information for the post" for better clarity.
- "information1": "Write information of the post" + "information1": "Write information for the post"
public/locales/hi/translation.json (1)
6-7
: Inconsistency in character length validation messagesThe
atleast_6_char_long
message is used insrc/screens/LoginPage/LoginPage.tsx
, but there is no usage of theatleast_8_char_long
message in the codebase. This suggests a potential inconsistency in the character length validation requirements. Please verify if the 8-character validation is necessary and ensure consistency across the application.
atleast_6_char_long
is used in:
src/screens/LoginPage/LoginPage.tsx
atleast_8_char_long
is not used in the codebase.Analysis chain
Potential inconsistency in character length messages.
The messages for character length ("कम से कम 8 अक्षर लंबा" and "कम से कम 6 अक्षर लंबा") should be verified for consistency with the application's requirements.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of character length messages in the codebase. # Test: Search for usage of these messages. Expect: Consistent character length requirements. rg --type json -A 2 $'"atleast_8_char_long": "कम से कम 8 अक्षर लंबा"' rg --type json -A 2 $'"atleast_6_char_long": "कम से कम 6 अक्षर लंबा"'Length of output: 1055
Script:
#!/bin/bash # Search for the usage of "atleast_8_char_long" key in the codebase rg 'atleast_8_char_long' --type js --type ts --type jsx --type tsx # Search for the usage of "atleast_6_char_long" key in the codebase rg 'atleast_6_char_long' --type js --type ts --type jsx --type tsxLength of output: 189
Script:
#!/bin/bash # Search for the usage of "atleast_8_char_long" key in JavaScript and TypeScript files rg 'atleast_8_char_long' --type js --type ts # Search for the usage of "atleast_6_char_long" key in JavaScript and TypeScript files rg 'atleast_6_char_long' --type js --type tsLength of output: 364
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (68)
package-lock.json
is excluded by!**/package-lock.json
public/favicon.ico
is excluded by!**/*.ico
public/favicon_palisadoes.ico
is excluded by!**/*.ico
public/images/logo512.png
is excluded by!**/*.png
public/images/svg/angleDown.svg
is excluded by!**/*.svg
public/images/svg/profiledefault.svg
is excluded by!**/*.svg
public/logo192.png
is excluded by!**/*.png
public/markdown/images/install1.png
is excluded by!**/*.png
public/markdown/images/install2.png
is excluded by!**/*.png
src/assets/css/app.css.map
is excluded by!**/*.map
src/assets/images/blank.png
is excluded by!**/*.png
src/assets/images/defaultImg.png
is excluded by!**/*.png
src/assets/images/palisadoes_logo.png
is excluded by!**/*.png
src/assets/images/talawa-logo-200x200.png
is excluded by!**/*.png
src/assets/images/talawa-logo-dark-200x200.png
is excluded by!**/*.png
src/assets/images/talawa-logo-lite-200x200.png
is excluded by!**/*.png
src/assets/svgs/actionItem.svg
is excluded by!**/*.svg
src/assets/svgs/admin.svg
is excluded by!**/*.svg
src/assets/svgs/agenda-category-icon.svg
is excluded by!**/*.svg
src/assets/svgs/agenda-items.svg
is excluded by!**/*.svg
src/assets/svgs/angleLeft.svg
is excluded by!**/*.svg
src/assets/svgs/angleRight.svg
is excluded by!**/*.svg
src/assets/svgs/article.svg
is excluded by!**/*.svg
src/assets/svgs/blockUser.svg
is excluded by!**/*.svg
src/assets/svgs/blockedUser.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemDate.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemEvent.svg
is excluded by!**/*.svg
src/assets/svgs/cardItemLocation.svg
is excluded by!**/*.svg
src/assets/svgs/chat.svg
is excluded by!**/*.svg
src/assets/svgs/checkInRegistrants.svg
is excluded by!**/*.svg
src/assets/svgs/dashboard.svg
is excluded by!**/*.svg
src/assets/svgs/date.svg
is excluded by!**/*.svg
src/assets/svgs/event.svg
is excluded by!**/*.svg
src/assets/svgs/eventDashboard.svg
is excluded by!**/*.svg
src/assets/svgs/eventStats.svg
is excluded by!**/*.svg
src/assets/svgs/events.svg
is excluded by!**/*.svg
src/assets/svgs/flask.svg
is excluded by!**/*.svg
src/assets/svgs/funds.svg
is excluded by!**/*.svg
src/assets/svgs/key.svg
is excluded by!**/*.svg
src/assets/svgs/listEventRegistrants.svg
is excluded by!**/*.svg
src/assets/svgs/location.svg
is excluded by!**/*.svg
src/assets/svgs/logout.svg
is excluded by!**/*.svg
src/assets/svgs/media.svg
is excluded by!**/*.svg
src/assets/svgs/newChat.svg
is excluded by!**/*.svg
src/assets/svgs/organizations.svg
is excluded by!**/*.svg
src/assets/svgs/palisadoes.svg
is excluded by!**/*.svg
src/assets/svgs/people.svg
is excluded by!**/*.svg
src/assets/svgs/plugins.svg
is excluded by!**/*.svg
src/assets/svgs/post.svg
is excluded by!**/*.svg
src/assets/svgs/posts.svg
is excluded by!**/*.svg
src/assets/svgs/requests.svg
is excluded by!**/*.svg
src/assets/svgs/roles.svg
is excluded by!**/*.svg
src/assets/svgs/settings.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Facebook-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Github-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Instagram-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Linkedin-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Reddit-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Slack-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Twitter-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/social-icons/Youtube-Logo.svg
is excluded by!**/*.svg
src/assets/svgs/tags.svg
is excluded by!**/*.svg
src/assets/svgs/talawa.svg
is excluded by!**/*.svg
src/assets/svgs/user.svg
is excluded by!**/*.svg
src/assets/svgs/userEvent.svg
is excluded by!**/*.svg
src/assets/svgs/users.svg
is excluded by!**/*.svg
src/assets/svgs/venues.svg
is excluded by!**/*.svg
src/assets/talawa-logo-lite-200x200.png
is excluded by!**/*.png
Files selected for processing (105)
- .coderabbit.yaml (1 hunks)
- .env.example (1 hunks)
- .eslintignore (1 hunks)
- .eslintrc.json (4 hunks)
- .github/ISSUE_TEMPLATE/bug-report.md (2 hunks)
- .github/ISSUE_TEMPLATE/feature-request.md (2 hunks)
- .github/dependabot.yaml (1 hunks)
- .github/pull_request_template.md (2 hunks)
- .github/workflows/README.md (1 hunks)
- .github/workflows/codeql-codescan.yml (1 hunks)
- .github/workflows/compare_translations.py (1 hunks)
- .github/workflows/countline.py (1 hunks)
- .github/workflows/eslint_disable_check.py (1 hunks)
- .github/workflows/issue.yml (1 hunks)
- .github/workflows/md_mdx_format_adjuster.py (1 hunks)
- .github/workflows/pull-request-target.yml (1 hunks)
- .github/workflows/pull-request.yml (1 hunks)
- .github/workflows/push.yml (1 hunks)
- .github/workflows/stale.yml (1 hunks)
- .gitignore (2 hunks)
- .husky/post-merge (1 hunks)
- .husky/pre-commit (1 hunks)
- .lintstagedrc.json (1 hunks)
- .node-version (1 hunks)
- .prettierignore (1 hunks)
- .prettierrc (1 hunks)
- CODEOWNERS (1 hunks)
- CODE_OF_CONDUCT.md (1 hunks)
- CODE_STYLE.md (1 hunks)
- CONTRIBUTING.md (2 hunks)
- DOCUMENTATION.md (1 hunks)
- INSTALLATION.md (1 hunks)
- ISSUE_GUIDELINES.md (1 hunks)
- PR_GUIDELINES.md (1 hunks)
- README.md (3 hunks)
- jest-preview.config.ts (1 hunks)
- jest.config.js (1 hunks)
- package.json (2 hunks)
- public/index.html (1 hunks)
- public/locales/en/common.json (1 hunks)
- public/locales/en/errors.json (1 hunks)
- public/locales/en/translation.json (1 hunks)
- public/locales/fr/common.json (1 hunks)
- public/locales/fr/errors.json (1 hunks)
- public/locales/fr/translation.json (1 hunks)
- public/locales/hi/common.json (1 hunks)
- public/locales/hi/errors.json (1 hunks)
- public/locales/hi/translation.json (1 hunks)
- public/locales/sp/common.json (1 hunks)
- public/locales/sp/errors.json (1 hunks)
- public/locales/sp/translation.json (1 hunks)
- public/locales/zh/common.json (1 hunks)
- public/locales/zh/errors.json (1 hunks)
- public/locales/zh/translation.json (1 hunks)
- public/manifest.json (1 hunks)
- schema.graphql (1 hunks)
- scripts/mocks/@dicebear/collection.ts (1 hunks)
- scripts/mocks/@dicebear/core.ts (1 hunks)
- scripts/config-overrides/custom_build.js (1 hunks)
- scripts/config-overrides/custom_start.js (1 hunks)
- scripts/config-overrides/index.js (1 hunks)
- scripts/config-overrides/package.json (1 hunks)
- scripts/custom-test-env.js (1 hunks)
- scripts/githooks/check-localstorage-usage.js (1 hunks)
- scripts/githooks/update-toc.js (1 hunks)
- scripts/test.js (1 hunks)
- setup.ts (1 hunks)
- src/App.test.tsx (1 hunks)
- src/App.tsx (1 hunks)
- src/Constant/constant.spec.ts (1 hunks)
- src/Constant/constant.ts (1 hunks)
- src/GraphQl/Mutations/ActionItemCategoryMutations.ts (1 hunks)
- src/GraphQl/Mutations/ActionItemMutations.ts (1 hunks)
- src/GraphQl/Mutations/AgendaCategoryMutations.ts (1 hunks)
- src/GraphQl/Mutations/AgendaItemMutations.ts (1 hunks)
- src/GraphQl/Mutations/CampaignMutation.ts (1 hunks)
- src/GraphQl/Mutations/CommentMutations.ts (1 hunks)
- src/GraphQl/Mutations/EventAttendeeMutations.ts (1 hunks)
- src/GraphQl/Mutations/FundMutation.ts (1 hunks)
- src/GraphQl/Mutations/OrganizationMutations.ts (1 hunks)
- src/GraphQl/Mutations/PledgeMutation.ts (1 hunks)
- src/GraphQl/Mutations/VenueMutations.ts (1 hunks)
- src/GraphQl/Mutations/mutations.ts (1 hunks)
- src/GraphQl/Queries/ActionItemCategoryQueries.ts (1 hunks)
- src/GraphQl/Queries/ActionItemQueries.ts (1 hunks)
- src/GraphQl/Queries/AgendaCategoryQueries.ts (1 hunks)
- src/GraphQl/Queries/AgendaItemQueries.ts (1 hunks)
- src/GraphQl/Queries/OrganizationQueries.ts (1 hunks)
- src/GraphQl/Queries/PlugInQueries.ts (1 hunks)
- src/GraphQl/Queries/Queries.ts (1 hunks)
- src/GraphQl/Queries/fundQueries.ts (1 hunks)
- src/assets/css/scrollStyles.css (1 hunks)
- src/assets/scss/_general.scss (1 hunks)
- src/assets/scss/_talawa.scss (1 hunks)
- src/assets/scss/_variables.scss (1 hunks)
- src/assets/scss/app.scss (1 hunks)
- src/assets/scss/components/_accordion.scss (1 hunks)
- src/assets/scss/components/_alert.scss (1 hunks)
- src/assets/scss/components/_badge.scss (1 hunks)
- src/assets/scss/components/_breadcrumb.scss (1 hunks)
- src/assets/scss/components/_buttons.scss (1 hunks)
- src/assets/scss/components/_card.scss (1 hunks)
- src/assets/scss/components/_carousel.scss (1 hunks)
- src/assets/scss/components/_close.scss (1 hunks)
- src/assets/scss/components/_dropdown.scss (1 hunks)
Files not processed due to max files limit (41)
- src/assets/scss/components/_list-group.scss
- src/assets/scss/components/_modal.scss
- src/assets/scss/components/_nav.scss
- src/assets/scss/components/_navbar.scss
- src/assets/scss/components/_offcanvas.scss
- src/assets/scss/components/_pagination.scss
- src/assets/scss/components/_placeholder.scss
- src/assets/scss/components/_progress.scss
- src/assets/scss/components/_spinners.scss
- src/assets/scss/content/_table.scss
- src/assets/scss/content/_typography.scss
- src/assets/scss/forms/_check-radios.scss
- src/assets/scss/forms/_floating-label.scss
- src/assets/scss/forms/_form-control.scss
- src/assets/scss/forms/_input-group.scss
- src/assets/scss/forms/_range.scss
- src/assets/scss/forms/_select.scss
- src/assets/scss/forms/_validation.scss
- src/assets/svgs/social-icons/index.tsx
- src/components/ActionItems/ActionItemsContainer.module.css
- src/components/ActionItems/ActionItemsContainer.test.tsx
- src/components/ActionItems/ActionItemsContainer.tsx
- src/components/ActionItems/ActionItemsContainerMocks.ts
- src/components/ActionItems/ActionItemsContainerProps.ts
- src/components/ActionItems/ActionItemsModal.test.tsx
- src/components/ActionItems/ActionItemsModal.tsx
- src/components/ActionItems/ActionItemsModalBody.tsx
- src/components/ActionItems/ActionItemsWrapper.module.css
- src/components/ActionItems/ActionItemsWrapper.test.tsx
- src/components/ActionItems/ActionItemsWrapper.tsx
- src/components/AddOn/AddOn.test.tsx
- src/components/AddOn/AddOn.tsx
- src/components/AddOn/core/AddOnEntry/AddOnEntry.module.css
- src/components/AddOn/core/AddOnEntry/AddOnEntry.test.tsx
- src/components/AddOn/core/AddOnEntry/AddOnEntry.tsx
- src/components/AddOn/core/AddOnEntry/AddOnEntryMocks.ts
- src/components/AddOn/core/AddOnRegister/AddOnRegister.module.css
- src/components/AddOn/core/AddOnRegister/AddOnRegister.test.tsx
- src/components/AddOn/core/AddOnRegister/AddOnRegister.tsx
- src/components/AddOn/core/AddOnStore/AddOnStore.module.css
- src/components/AddOn/core/AddOnStore/AddOnStore.test.tsx
Files skipped from review due to trivial changes (28)
- .env.example
- .eslintignore
- .github/ISSUE_TEMPLATE/feature-request.md
- .github/dependabot.yaml
- .github/workflows/README.md
- .gitignore
- .lintstagedrc.json
- .node-version
- .prettierignore
- CODEOWNERS
- jest-preview.config.ts
- public/locales/en/common.json
- public/locales/fr/errors.json
- public/locales/fr/translation.json
- public/locales/hi/common.json
- public/locales/hi/errors.json
- public/locales/sp/common.json
- public/locales/zh/errors.json
- scripts/mocks/@dicebear/collection.ts
- scripts/mocks/@dicebear/core.ts
- scripts/config-overrides/package.json
- src/GraphQl/Queries/ActionItemCategoryQueries.ts
- src/assets/css/scrollStyles.css
- src/assets/scss/_talawa.scss
- src/assets/scss/_variables.scss
- src/assets/scss/app.scss
- src/assets/scss/components/_alert.scss
- src/assets/scss/components/_badge.scss
Additional context used
Learnings (3)
src/GraphQl/Queries/fundQueries.ts (1)
Learnt from: GlenDsza PR: PalisadoesFoundation/talawa-admin#2064 File: src/screens/OrganizationFunds/FundDeleteModal.tsx:1-2 Timestamp: 2024-06-30T21:44:39.912Z Learning: The folder containing mutation queries in the codebase is named `GraphQl`, not `graphql`.
src/GraphQl/Mutations/FundMutation.ts (1)
Learnt from: GlenDsza PR: PalisadoesFoundation/talawa-admin#2064 File: src/screens/OrganizationFunds/FundDeleteModal.tsx:1-2 Timestamp: 2024-06-30T21:44:39.912Z Learning: The folder containing mutation queries in the codebase is named `GraphQl`, not `graphql`.
src/GraphQl/Mutations/CampaignMutation.ts (1)
Learnt from: GlenDsza PR: PalisadoesFoundation/talawa-admin#2064 File: src/screens/OrganizationFundCampaign/CampaignDeleteModal.tsx:4-5 Timestamp: 2024-06-30T21:17:16.481Z Learning: The folder containing mutation queries in the codebase is named `GraphQl`, not `graphql`.
Biome
scripts/test.js
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
LanguageTool
DOCUMENTATION.md
[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...fdocs.talawa.io
should automatically launched in your browser at http://localhost:300...(MD_BASEFORM)
[grammar] ~26-~26: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ttp://localhost:3000/ 1. Add/modify the markdown documents to thedocs/
directory of t...(MARKDOWN_NNP)
[uncategorized] ~32-~32: The preposition “to” seems more likely in this position.
Context: ... PLEASE do not add markdown files in this repository. Add them to `talawa-do...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
ISSUE_GUIDELINES.md
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Issue Report Guidelines 👍🎉 First off, thanks for taking t...(UNLIKELY_OPENING_PUNCTUATION)
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a issu...(IN_ORDER_TO_PREMIUM)
[misspelling] ~5-~5: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...der to give everyone a chance to submit a issues reports and contribute to the Ta...(EN_A_VS_AN)
[typographical] ~24-~24: Consider adding a comma here.
Context: ...> ___ ## Issue Management In all cases please use the [GitHub open issue search](http...(PLEASE_COMMA)
[uncategorized] ~27-~27: Possible missing comma found.
Context: ...reported. ### New Issues To create new issues follow these steps: 1. Your issue may ...(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~30-~30: Consider using a different verb for a more formal wording.
Context: .... 1. Verify whether the issue has been fixed by trying to reproduce it using the lat...(FIX_RESOLVE)
[style] ~35-~35: The wording of this phrase can be improved.
Context: ...lcome contributors who find new ways to make the code better. ### Existing Issues You can also be ...(MAKE_STYLE_BETTER)
[grammar] ~44-~44: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...butors to assign it to you in#talawa
slack channel. Working on these types of exi...(ON_SKYPE)
[grammar] ~53-~53: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...ew Issues 1. Join our#talawa-github
slack channel for automatic issue and pull re...(ON_SKYPE)
[grammar] ~57-~57: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...lines 1. Discuss issues in our various slack channels when necessary 2. Please do no...(ON_SKYPE)
[typographical] ~57-~57: Consider adding a comma here.
Context: ...ur various slack channels when necessary 2. Please do not derail or troll issues. 3. Keep...(PLEASE_COMMA)
README.md
[uncategorized] ~56-~56: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...s" videos are extremely helpful for new open source contributors.(EN_COMPOUND_ADJECTIVE_INTERNAL)
PR_GUIDELINES.md
[uncategorized] ~2-~2: Loose punctuation mark.
Context: # Pull Request Guidelines 👍🎉 First off, thanks for taking t...(UNLIKELY_OPENING_PUNCTUATION)
[style] ~4-~4: Consider a shorter alternative to avoid wordiness.
Context: ...ing the time to contribute! 🎉👍 In order to give everyone a chance to submit a pull...(IN_ORDER_TO_PREMIUM)
[style] ~46-~46: Style-wise, it’s not ideal to insert an adverb (‘manually’) in the middle of an infinitive construction (‘to test’). Try moving the adverb to avoid split infinitives.
Context: ..., you'll need to tell us what steps you followed to manually test your changes. 1. Please read our [CONTRIBUTING.md](C...(SPLIT_INFINITIVE)
[style] ~56-~56: As an alternative to the over-used intensifier ‘very’, consider replacing this phrase.
Context: ...o be closed. The quality of our code is very important to us. Therefore we make experienced ma...(EN_WEAK_ADJECTIVE)
[uncategorized] ~56-~56: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ty of our code is very important to us. Therefore we make experienced maintainers of our ...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[style] ~59-~59: Consider using a different verb for a more formal wording.
Context: ...check if all tests are passing; if not, fix the issues and then create a pull reque...(FIX_RESOLVE)
[style] ~64-~64: This expression is wordy and overused. Consider replacing it with a more concise and formal alternative.
Context: ...wer your questions, but we'll get to it sooner or later. @mentioning someone just adds to the p...(SOONER_OR_LATER)
[uncategorized] ~64-~64: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...adds to the pile of notifications we get and it won't make us look at your issue fas...(COMMA_COMPOUND_SENTENCE)
[style] ~65-~65: Consider shortening or rephrasing this to strengthen your wording.
Context: ...ue faster. 1. Do not force push. If you make changes to your pull request, please simply add a ...(MAKE_CHANGES)
CODE_OF_CONDUCT.md
[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...(ENGLISH_WORD_REPEAT_RULE)
CODE_STYLE.md
[style] ~127-~127: Consider removing “of” to be more concise
Context: ...tories ofsrc
assets
- This houses all of the static assets used in the project - `...(ALL_OF_THE)
[style] ~128-~128: Consider removing “of” to be more concise
Context: ... in the project -css
- This houses all of the css files used in the project - `imag...(ALL_OF_THE)
[style] ~129-~129: Consider removing “of” to be more concise
Context: ... the project -images
- This houses all of the images used in the project -scss
-...(ALL_OF_THE)
[style] ~130-~130: Consider removing “of” to be more concise
Context: ...in the project -scss
- This houses all of the scss files used in the project - `c...(ALL_OF_THE)
[grammar] ~134-~134: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ...rms -_talawa.scss
- Partial Sass file for Talawa -_utilities.scss
- Pa...(HE_VERB_AGR)
[grammar] ~135-~135: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... -_utilities.scss
- Partial Sass file for utilities -_variables.scss
-...(HE_VERB_AGR)
[grammar] ~136-~136: The singular proper name ‘Sass’ must be used with a third-person or a past tense verb.
Context: ... -_variables.scss
- Partial Sass file for variables -app.scss
- Main S...(HE_VERB_AGR)
[style] ~141-~141: Consider removing “of” to be more concise
Context: ...views/screensConstant
- This houses all of the constants used in the project `GraphQl...(ALL_OF_THE)
[style] ~143-~143: Consider removing “of” to be more concise
Context: ...in the projectGraphQl
- This houses all of the GraphQL queries and mutations used in t...(ALL_OF_THE)
[style] ~145-~145: Consider removing “of” to be more concise
Context: ...in the projectscreens
- This houses all of the views/screens to be navigated through i...(ALL_OF_THE)
[style] ~147-~147: Consider removing “of” to be more concise
Context: ... in Talawa-Adminstate
- This houses all of the state management code for the project ...(ALL_OF_THE)
[uncategorized] ~165-~165: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...following order: - React imports - Third party imports - Local imports If there is...(EN_COMPOUND_ADJECTIVE_INTERNAL)
CONTRIBUTING.md
[style] ~26-~26: This expression usually appears with a “please” in front of it.
Context: ...DUCT.md) to understand what this means. Let us know immediately if you have unacceptable ex...(INSERT_PLEASE)
[grammar] ~56-~56: A determiner may be missing.
Context: ...l Request guidelines](PR_GUIDELINES.md) is best resource to follow to start working on ...(THE_SUPERLATIVE)
[uncategorized] ~62-~62: Loose punctuation mark.
Context: ...ushed to themain
branch: -develop
: For unstable code and bug fixing - `mai...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~63-~63: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...d bug fixing -main
: Where the stable production ready code lies. This is our default branch. ...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[typographical] ~67-~67: Consider adding a comma.
Context: ...ultiple developers are working on issues there is bound to be a conflict of interest (...(IF_THERE_COMMA)
[typographical] ~67-~67: Consider adding a comma after ‘Usually’ for more clarity.
Context: ...licts) among issues, PRs or even ideas. Usually these conflicts are resolved in a **Fir...(RB_LY_COMMA)
[grammar] ~67-~67: Did you mean “served” (as in the idiom ‘first come, first served’)?
Context: ...ts are resolved in a First Come First Serve basis however there are certain excep...(FIRST_SERVED)
[uncategorized] ~69-~69: Possible missing comma found.
Context: ... an extension or in conflict with other PRs it is important to ask the author of th...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~69-~69: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...tant to ask the author of the PR in the slack channel or in their PRs or issues thems...(ON_SKYPE)
[style] ~71-~71: ‘Last but not the least’ might be wordy. Consider a shorter alternative.
Context: ...y and test that function when needed. - Last but not the least, communication is important make sure t...(EN_WORDINESS_PREMIUM_LAST_BUT_NOT_THE_LEAST)
[grammar] ~71-~71: It seems that “to” is missing before the verb.
Context: ...t the least, communication is important make sure to talk to other contributors, in ...(MISSING_TO_BETWEEN_BE_AND_VB)
[grammar] ~71-~71: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ... other contributors, in these cases, in slack channel or in a issue/PR thread. - As a...(ON_SKYPE)
[misspelling] ~71-~71: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... in these cases, in slack channel or in a issue/PR thread. - As a last resort the...(EN_A_VS_AN)
[typographical] ~72-~72: It appears that a comma is missing.
Context: ...el or in a issue/PR thread. - As a last resort the Admins would be responsible for dec...(DURING_THAT_TIME_COMMA)
[grammar] ~129-~129: The operating system from Apple is written “macOS”.
Context: ...r packages can be found for Windows and MacOS. 6. The currently acceptable c...(MAC_OS)
[uncategorized] ~157-~157: Possible missing comma found.
Context: ...odecov/results.jpg)]() 1. After making changes you can add them to git locally using `...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~159-~159: Possible missing comma found.
Context: ...using:git push origin <branch_name>
.(Here branch name must be name of the branch ...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~159-~159: Possible missing article found.
Context: ...:git push origin <branch_name>
.(Here branch name must be name of the branch you wan...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~159-~159: Possible missing article found.
Context: ...branch_name>`.(Here branch name must be name of the branch you want to push the chan...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~161-~161: Possible missing comma found.
Context: ...test suite passes, either locally or on CI once a PR has been created. 1. Review a...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~172-~172: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...dation/talawa) for the link to join our slack channel. 1. We also have a technical em...(ON_SKYPE)
INSTALLATION.md
[uncategorized] ~3-~3: A comma might be missing here.
Context: ...tructions are written to be followed in sequence so make sure to go through each of them...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[duplication] ~24-~24: Possible typo: you repeated a word
Context: ...](#running-talawa-admin) - Accessing Talawa-Admin - [Talawa-Admin Registration](#talawa-admin-registratio...(ENGLISH_WORD_REPEAT_RULE)
[typographical] ~54-~54: It appears that a comma is missing.
Context: ... that follow. # Prerequisites In this section we'll explain how to set up all the pre...(DURING_THAT_TIME_COMMA)
[uncategorized] ~60-~60: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: .... Basicgit
knowledge is required for open source contribution so make sure you're comfor...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[uncategorized] ~60-~60: Possible missing comma found.
Context: ...` knowledge is required for open source contribution so make sure you're comfortable with it...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~66-~66: The word “setup” is a noun. The verb is spelled with a space.
Context: ...avigate to the folder where you want to setup the repository. 2. Open acmd
(Window...(NOUN_VERB_CONFUSION)
[grammar] ~67-~67: The operating system from Apple is written “macOS”.
Context: ...cmd
(Windows) orterminal
(Linux or MacOS) session in this folder. 1. An easy...(MAC_OS)
[uncategorized] ~68-~68: You might be missing the article “the” here.
Context: ...to do this is to right-click and choose appropriate option based on your OS. 3. **For Our O...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~69-~69: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...e option based on your OS. 3. For Our Open Source Contributor Software Developers: ...(EN_COMPOUND_ADJECTIVE_INTERNAL)
[uncategorized] ~95-~95: A determiner appears to be missing. Consider inserting it.
Context: ....git ``` ## Install node.js Best way to install and managenode.js
is ...(AI_EN_LECTOR_MISSING_DETERMINER)
[uncategorized] ~96-~96: Possible missing preposition found.
Context: ... way to install and managenode.js
is making use of node version managers. We recomm...(AI_EN_LECTOR_MISSING_PREPOSITION)
[uncategorized] ~98-~98: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...steps to install thenode.js
packages in Windows, Linux and MacOS. 1. For Windo...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)
[grammar] ~98-~98: The operating system from Apple is written “macOS”.
Context: ...node.js` packages in Windows, Linux and MacOS. 1. For Windows: 1. first install ...(MAC_OS)
[duplication] ~112-~112: Possible typo: you repeated a word
Context: ... 5. Save the document. 6. Exitnotepad
7. Exit PowerShell 8. This will ens...(ENGLISH_WORD_REPEAT_RULE)
[uncategorized] ~114-~114: Possible missing comma found.
Context: ...ou are always using the correct version ofnode.js
2. For Linux and MacOS, use t...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~115-~115: The operating system from Apple is written “macOS”.
Context: ...t version ofnode.js
2. For Linux and MacOS, use the terminal window. 1. install...(MAC_OS)
[grammar] ~119-~119: The word “setup” is a noun. The verb is spelled with a white space.
Context: ... the respective recommended commands to setup your node environment 3. This ...(NOUN_VERB_CONFUSION)
[uncategorized] ~126-~126: Possible missing comma found.
Context: ...stall TypeScript, you can use thenpm
command which comes withnode.js
: ```bash np...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~154-~154: Possible missing comma found.
Context: ...ions in "setup" can be done manually as well and here's how to do it. - [Creating .e...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~158-~158: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...at runtime. It is not a part of the repo and you will have to create it. For a sampl...(COMMA_COMPOUND_SENTENCE)
[uncategorized] ~158-~158: You might be missing the article “the” here.
Context: ...the contents of the.env.example
into.env
file. Use this command: ``` cp .e...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~199-~199: Possible missing preposition found.
Context: ... For additional details, please refer theHow to Access the Talawa-API URL
sect...(AI_HYDRA_LEO_MISSING_TO)
[grammar] ~203-~203: The word “setup” is a noun. The verb is spelled with a space.
Context: ...E_KEY in .env file You may not want to setup reCAPTCHA since the project will still ...(NOUN_VERB_CONFUSION)
[grammar] ~207-~207: The word “setup” is a noun. The verb is spelled with a space.
Context: ...ad the following steps. If you want to setup Google reCAPTCHA now, you may refer to ...(NOUN_VERB_CONFUSION)
[uncategorized] ~209-~209: Possible missing comma found.
Context: ... service you set up duringtalawa-api
installation as shown in this screenshot: ![reCAPTC...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~213-~213: You might be missing the article “the” here.
Context: ...namedREACT_APP_RECAPTCHA_SITE_KEY
in.env
file. ``` REACT_APP_RECAPTCHA_SIT...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[typographical] ~221-~221: Except for inverted sentences, ‘need them’ requires a question mark at the end of the sentence.
Context: ...t need them or want to keep the console clean # Post Configuration Steps It's now t...(MD_PRP_QUESTION_MARK)
[uncategorized] ~236-~236: Did you mean: “By default,”?
Context: ...n serve ``` ## Accessing Talawa-Admin By defaulttalawa-admin
runs on port `4321` on y...(BY_DEFAULT_COMMA)
[uncategorized] ~253-~253: A comma might be missing here.
Context: ... navigate to the running talawa-admin's website you'll land at talawa-admin registratio...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~253-~253: You might be missing the article “the” here.
Context: ...g talawa-admin's website you'll land at talawa-admin registration page. Sign up using ...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[grammar] ~286-~286: The word ‘lint’ is a noun or an adjective. A verb or adverb is missing or misspelled here, or maybe a comma is missing.
Context: ...w.webp) ## Linting code files You can lint your code files using this command: ``...(PRP_MD_NN)
Markdownlint
DOCUMENTATION.md
25-25: null
Bare URL used(MD034, no-bare-urls)
PR_GUIDELINES.md
31-31: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
39-39: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
CODE_STYLE.md
128-128: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
129-129: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
130-130: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
131-131: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
132-132: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
133-133: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
134-134: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
135-135: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
136-136: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
137-137: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
164-164: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
165-165: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
166-166: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
57-57: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
73-73: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
75-75: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
92-92: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
190-190: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
230-230: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
58-58: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
65-65: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
78-78: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
95-95: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
158-158: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
173-173: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
181-181: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
239-239: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
245-245: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
251-251: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
CONTRIBUTING.md
98-98: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
107-107: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
122-122: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
133-133: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
137-137: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
152-152: null
No empty links(MD042, no-empty-links)
153-153: null
No empty links(MD042, no-empty-links)
155-155: null
No empty links(MD042, no-empty-links)
INSTALLATION.md
296-296: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time(MD001, heading-increment)
32-32: Expected: 4; Actual: 6
Unordered list indentation(MD007, ul-indent)
33-33: Expected: 4; Actual: 6
Unordered list indentation(MD007, ul-indent)
91-91: null
Dollar signs used before commands without showing output(MD014, commands-show-output)
101-101: null
Bare URL used(MD034, no-bare-urls)
138-138: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
150-150: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
160-160: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
183-183: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
189-189: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
195-195: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
215-215: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
231-231: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
239-239: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
245-245: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
267-267: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
275-275: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
288-288: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
302-302: Expected: fenced; Actual: indented
Code block style(MD046, code-block-style)
310-310: Expected: fenced; Actual: indented
Code block style(MD046, code-block-style)
173-173: Expected: #setting-up-react_app_talawa_url-in-env-file; Actual: #setting-up-REACT_APP_TALAWA_URL-in-env-file
Link fragments should be valid(MD051, link-fragments)
173-173: Expected: #setting-up-react_app_recaptcha_site_key-in-env-file; Actual: #setting-up-REACT_APP_RECAPTCHA_SITE_KEY-in-env-file
Link fragments should be valid(MD051, link-fragments)
Additional comments not posted (206)
.prettierrc (1)
3-3
: Good addition for cross-platform compatibility.The
"endOfLine": "auto"
setting ensures consistent line endings across different environments, which is beneficial for collaboration..husky/post-merge (1)
1-4
: Useful post-merge hook for dependency management.This script ensures that any changes to
package.json
are followed bynpm install
, maintaining the correct state of dependencies after a merge..husky/pre-commit (1)
1-10
: Comprehensive pre-commit hook for code quality.This script runs linting, type checking, and other tasks to ensure code quality and consistency before committing changes.
src/Constant/constant.ts (1)
1-7
: Ensure sensitive information is not exposed.The use of environment variables is appropriate for configuration, but ensure that sensitive information like API keys and tokens are not exposed in client-side code. Consider using server-side environment variables for sensitive data.
.coderabbit.yaml (1)
1-17
: Verify configuration aligns with project goals.The YAML configuration sets up CodeRabbit's review and chat settings. Ensure these settings align with the project's review process and collaboration goals. For example, enabling
auto_review
andauto_reply
should fit the team's workflow.src/assets/scss/components/_breadcrumb.scss (1)
1-11
: LGTM! Verify integration with other stylesheets.The SCSS variables for breadcrumb styling are well-defined and follow a consistent naming pattern. Ensure these variables are correctly integrated with other stylesheets in the project to maintain styling consistency.
Verification successful
Breadcrumb styles are integrated through import statements.
The breadcrumb styles are imported in other stylesheets, indicating integration within the project's SCSS files. There were no mixins found using breadcrumb variables, which suggests direct usage or a different integration approach.
- Import statement found:
@import './components/breadcrumb';
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration of breadcrumb styles with other stylesheets. # Test: Search for breadcrumb variable usage in SCSS files. Expect: Occurrences of breadcrumb variables in other SCSS files. rg --type scss '\$breadcrumb-'Length of output: 61
Script:
#!/bin/bash # Description: Verify integration of breadcrumb styles with other stylesheets. # Find all SCSS files and search for breadcrumb variable usage fd --extension scss --exec rg '\$breadcrumb-' {}Length of output: 461
Script:
#!/bin/bash # Description: Check for import statements or mixins involving breadcrumb styles. # Search for any import statements related to breadcrumb styles in SCSS files rg '@import' --type scss -A 2 | rg 'breadcrumb' # Search for mixins that might use breadcrumb variables rg 'mixin' --type scss -A 5 | rg '\$breadcrumb-'Length of output: 152
Script:
#!/bin/bash # Description: Check for import statements or mixins involving breadcrumb styles. # Find all SCSS files and search for import statements related to breadcrumb styles fd --extension scss --exec rg '@import' {} -A 2 | rg 'breadcrumb' # Find all SCSS files and search for mixins that might use breadcrumb variables fd --extension scss --exec rg 'mixin' {} -A 5 | rg '\$breadcrumb-'Length of output: 169
public/manifest.json (2)
16-16
: LGTM!The path change for
logo512.png
toimages/logo512.png
is approved. This change likely reflects a reorganization of assets for better structure.
13-13
: Verify the change in image size.The
sizes
attribute forlogo192.png
is set to16x16
, which may be incorrect given the file name. Verify that this change is intentional and aligns with the intended use of the image.scripts/config-overrides/custom_build.js (1)
1-16
: LGTM! Verify environment variable usage.The custom build script is well-structured and uses
dotenv
to manage environment variables. Ensure that theALLOW_LOGS
environment variable is correctly set in all environments where this script will be executed.Verification successful
Environment Variable Usage Verified
The
ALLOW_LOGS
environment variable is consistently used across the codebase and is well-documented. Ensure it is set appropriately in all environments where the script is executed.
setup.ts
: Reads and modifies theALLOW_LOGS
variable.scripts/config-overrides/custom_start.js
: Checks ifALLOW_LOGS
is "YES".scripts/config-overrides/custom_build.js
: Checks ifALLOW_LOGS
is "YES".INSTALLATION.md
: Provides instructions for settingALLOW_LOGS
.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the `ALLOW_LOGS` environment variable. # Test: Search for `ALLOW_LOGS` variable usage in the codebase. Expect: Consistent usage across environments. rg 'ALLOW_LOGS'Length of output: 530
public/locales/en/errors.json (7)
2-2
: Message clarity and correctness.The message "Talawa-API service is unavailable!..." is clear and provides useful guidance.
3-3
: Message clarity and correctness.The message "Not found" is concise and appropriate.
4-4
: Message clarity and correctness.The message "An unknown error occurred..." is clear and includes a placeholder for additional details.
6-6
: Message clarity and correctness.The message "Error sending mail" is concise and appropriate.
7-7
: Message clarity and correctness.The message "Email not registered" is concise and appropriate.
8-8
: Message clarity and correctness.The message "Oops! The Page you requested..." is clear and friendly.
9-9
: Message clarity and correctness.The message "An error occurred. Couldn't create..." is clear and includes a placeholder for the entity.
public/locales/sp/errors.json (1)
9-9
: Message clarity and correctness.The message "Ocurrió un error. No se pudo crear..." is correctly translated and clear.
scripts/custom-test-env.js (1)
1-16
: LGTM!The class
CustomTestEnvironment
correctly sets upTextEncoder
andTextDecoder
. The code is clear and follows best practices.scripts/config-overrides/custom_start.js (2)
1-1
: Ensure environment variables are loaded correctly.The use of
dotenv
to load environment variables is appropriate. Ensure that a.env
file is present and correctly configured.
10-18
: Consider security implications of spawning processes.Using
spawn
withshell: true
can be risky if any part of the command is derived from user input. Ensure that the commands are safe and not influenced by external input.Verification successful
Verification successful: No user input influences the commands in
custom_start.js
.The script uses environment variables
process.env.ALLOW_LOGS
andprocess.env.PORT
, but there is no indication that these are derived from untrusted user input within the script. Therefore, the security implications of usingspawn
withshell: true
are mitigated in this context.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that no user input influences the commands in `custom_start.js`. # Test: Search for any user input in the file. Expect: No user input should be found. rg --type javascript 'process\.env\.[A-Z_]+'Length of output: 81
Script:
#!/bin/bash # Description: Verify that no user input influences the commands in `custom_start.js`. # Test: Search for any environment variables or user input in the file. rg 'process\.env\.[A-Z_]+' scripts/config-overrides/custom_start.js rg 'process\.argv' scripts/config-overrides/custom_start.jsLength of output: 235
src/GraphQl/Queries/AgendaCategoryQueries.ts (1)
10-22
: Review necessity of all fields in the query.Ensure that all fields retrieved in the
AGENDA_ITEM_CATEGORY_LIST
query are necessary for the application's functionality. Unnecessary fields can lead to inefficient data retrieval.src/GraphQl/Mutations/AgendaItemMutations.ts (2)
20-31
: Ensure input validation forUPDATE_AGENDA_ITEM_MUTATION
.Verify that both
updateAgendaItemId
andUpdateAgendaItemInput
are validated to prevent invalid data from being processed.
3-10
: Ensure input validation forCREATE_AGENDA_ITEM_MUTATION
.Verify that the
CreateAgendaItemInput
is validated in the application logic to prevent invalid data from being processed.src/assets/scss/components/_close.scss (1)
5-6
: Ensure color variable is defined.The variable
$btn-close-color
is used to set the fill color in the SVG background. Ensure that$black
is defined elsewhere in the SCSS files.src/assets/scss/components/_card.scss (2)
10-10
: Check for function definition.Ensure that the
subtract
function is defined or imported in the SCSS files. This function is used to calculate the inner border radius.
6-8
: Verify CSS variable definitions.Ensure that the CSS variables
--#{$prefix}border-width
,--#{$prefix}border-color-translucent
, and--#{$prefix}border-radius
are defined in the CSS or SCSS files..github/ISSUE_TEMPLATE/bug-report.md (1)
2-5
: Consistency in capitalization and labels.The changes to capitalize "Bug Report" and use lowercase "bug" for labels improve consistency. Ensure that these conventions are followed across all issue templates.
scripts/config-overrides/index.js (1)
7-20
: Ensure theProgressPlugin
configuration meets your needs.The
ProgressPlugin
provides detailed build progress. Ensure that themodulesCount
anddependenciesCount
are appropriate for your project size to avoid performance issues.src/Constant/constant.spec.ts (4)
8-12
: Ensure all constants are tested.Verify that all relevant constants are covered by tests. If there are additional constants in the module, consider adding corresponding tests.
14-16
: Verify environment variable usage.Ensure that the environment variable
REACT_APP_TALAWA_URL
is correctly set in all environments where tests are run.
18-22
: Check for environment variable configuration.Ensure that
REACT_APP_RECAPTCHA_SITE_KEY
is properly configured in the environment settings to avoid test failures.
24-28
: Ensure consistent environment variable configuration.Verify that
REACT_APP_USE_RECAPTCHA
is set consistently across environments to ensure test reliability.public/index.html (4)
5-5
: Verify the favicon update.Ensure that the new favicon file
favicon_palisadoes.ico
exists and is correctly linked.
8-8
: Check apple-touch-icon consistency.Verify that the
apple-touch-icon
link is consistent with branding and theming decisions.
10-11
: Preconnect optimization.The preconnect links to Google Fonts can improve performance. Ensure these resources are used in the application to justify the preconnection.
12-15
: Verify Google Fonts usage.Ensure that the "Outfit" font family is used in your styles to justify the inclusion of this stylesheet.
src/GraphQl/Mutations/ActionItemCategoryMutations.ts (1)
26-39
: Ensure proper error handling for GraphQL mutations.The
UPDATE_ACTION_ITEM_CATEGORY_MUTATION
is well-structured, but ensure that error handling is implemented wherever this mutation is used in the application to manage potential GraphQL errors effectively.src/assets/scss/_general.scss (2)
5-9
: Ensure consistent box-sizing across components.The universal selector is used for box-sizing, which is a good practice for consistency. Ensure all components adhere to this standard.
34-43
: Optimize the shimmer animation for performance.The shimmer animation is defined with a linear gradient. Ensure that the animation does not cause performance issues on lower-end devices.
.github/workflows/codeql-codescan.yml (1)
14-20
: Verify branch patterns for triggering workflows.The workflow triggers on all branches. Ensure this is intentional and aligns with the project's CI/CD strategy.
src/GraphQl/Mutations/AgendaCategoryMutations.ts (3)
9-15
: LGTM!The
CREATE_AGENDA_ITEM_CATEGORY_MUTATION
is well-defined and uses an appropriate input object.
23-27
: LGTM!The
DELETE_AGENDA_ITEM_CATEGORY_MUTATION
is correctly defined with a clear parameter name.
36-45
: LGTM!The
UPDATE_AGENDA_ITEM_CATEGORY_MUTATION
is well-defined and uses appropriate parameters.src/GraphQl/Mutations/CommentMutations.ts (3)
11-28
: LGTM!The
CREATE_COMMENT_POST
mutation is well-structured and returns detailed information about the created comment.
37-43
: LGTM!The
LIKE_COMMENT
mutation is correctly defined with a clear parameter name.
52-58
: LGTM!The
UNLIKE_COMMENT
mutation is correctly defined with a clear parameter name.src/GraphQl/Queries/AgendaItemQueries.ts (2)
3-37
: LGTM!The
AgendaItemByOrganization
query is well-structured and provides detailed information about agenda items.
39-73
: LGTM!The
AgendaItemByEvent
query is well-structured and provides detailed information about agenda items.src/assets/scss/components/_carousel.scss (1)
1-27
: SCSS Variables Look Good!The SCSS variables are well-defined and follow consistent naming conventions, which will help maintainability and readability.
src/GraphQl/Mutations/EventAttendeeMutations.ts (1)
1-49
: GraphQL Mutations Are Well-Structured!The GraphQL mutations are well-defined with clear documentation comments. The structure is consistent and aligns with best practices.
.github/pull_request_template.md (1)
Line range hint
1-53
: Enhanced PR Template!The updated pull request template provides clear and structured guidance for contributors. It emphasizes the branching strategy and includes prompts for necessary information, which will streamline the review process.
src/assets/scss/components/_accordion.scss (1)
1-36
: LGTM! Ensure consistency with existing styles.The SCSS variables are well-structured and use CSS custom properties effectively.
However, verify that these variables are used consistently with existing styles in the project.
.github/workflows/stale.yml (1)
1-43
: LGTM! The workflow is well-configured.The GitHub Action is correctly set up to manage stale issues and pull requests with appropriate parameters.
jest.config.js (1)
1-66
: LGTM! Ensure paths and patterns are correct.The Jest configuration is comprehensive and well-suited for a React project.
However, verify that all paths and patterns are correct and align with the project's testing requirements.
public/locales/zh/common.json (1)
1-86
: Translations look accurate and consistent.The translations for common UI terms seem appropriate and consistent with standard Chinese language usage.
src/assets/scss/components/_buttons.scss (1)
1-73
: SCSS styling is well-structured and consistent.The SCSS file defines variables for button styling, ensuring consistency and ease of maintenance. The use of variables and mixins is appropriate.
src/GraphQl/Mutations/PledgeMutation.ts (1)
1-84
: GraphQL mutations are correctly defined and well-documented.The mutations for creating, updating, and deleting pledges are well-structured and follow appropriate naming conventions. The parameter documentation is clear and helpful.
src/GraphQl/Mutations/FundMutation.ts (1)
79-85
: LGTM!The
REMOVE_FUND_MUTATION
is correctly implemented and well-documented.src/GraphQl/Mutations/CampaignMutation.ts (3)
15-37
: LGTM!The
CREATE_CAMPAIGN_MUTATION
is correctly implemented and well-documented.
51-73
: LGTM!The
UPDATE_CAMPAIGN_MUTATION
is correctly implemented and well-documented.
81-87
: LGTM!The
DELETE_CAMPAIGN_MUTATION
is correctly implemented and well-documented.src/GraphQl/Mutations/ActionItemMutations.ts (2)
13-33
: LGTM!The
CREATE_ACTION_ITEM_MUTATION
is correctly implemented and well-documented.
47-71
: LGTM!The
UPDATE_ACTION_ITEM_MUTATION
is correctly implemented and well-documented.src/GraphQl/Queries/ActionItemQueries.ts (1)
68-103
: LGTM!The
ACTION_ITEM_LIST_BY_EVENTS
query is well-structured and documented.scripts/githooks/check-localstorage-usage.js (4)
10-18
: LGTM!The
containsSkipComment
function is well-implemented and handles errors gracefully.
20-37
: LGTM!The
getModifiedFiles
function effectively retrieves the list of modified files and handles errors appropriately.
43-78
: LGTM!The
checkLocalStorageUsage
function accurately identifies localStorage usage and skips specified files.
80-95
: LGTM!The main logic of the script is clear and provides helpful instructions for handling localStorage usage.
.github/workflows/md_mdx_format_adjuster.py (3)
20-44
: LGTM!The
escape_mdx_characters
function efficiently escapes special characters for MDX compatibility.
46-66
: LGTM!The
process_file
function efficiently processes Markdown files and writes changes only when necessary.
67-97
: LGTM!The
main
function effectively processes all Markdown files in the specified directory for MDX compatibility.public/locales/fr/common.json (1)
1-86
: French translations look good!The translations are consistent and accurately reflect the intended meaning for each key.
ISSUE_GUIDELINES.md (1)
1-1
: Remove unnecessary punctuation.The punctuation at the end of the heading is not needed.
-# Issue Report Guidelines +# Issue Report GuidelinesLikely invalid or redundant comment.
src/App.test.tsx (5)
2-6
: Ensure imports are necessary and correctly used.The imports for testing utilities and context providers are appropriate for the test setup.
17-23
: Mock implementation forPieChart
is appropriate.The mock implementation helps avoid external dependencies during testing.
25-56
: Mock data setup is comprehensive.The mock data for
CHECK_AUTH
query is detailed and covers necessary fields.
69-94
: Test for logged-in user is well-structured.The test correctly checks the rendering and URL redirection for a logged-in user.
96-110
: Test for logged-out user is well-structured.The test appropriately handles the scenario for a logged-out user.
README.md (3)
10-10
: Verify Codecov badge link.Ensure that the Codecov badge link is correct and reflects the current branch.
Verification successful
Codecov Badge Link Verified
The Codecov badge link in the
README.md
file is correct and matches the expected URL pattern. The link is also present inCONTRIBUTING.md
andtalawa-admin-docs/README.md
, indicating consistent usage across documentation files.
README.md
CONTRIBUTING.md
talawa-admin-docs/README.md
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the Codecov badge link in the README.md file. # Test: Check if the Codecov badge link is correct. rg --type md $'\\!\\[codecov\\]\\(https://codecov.io/gh/PalisadoesFoundation/talawa-admin/branch/develop/graph/badge.svg\\?token=II0R0RREES\\)'Length of output: 326
Script:
#!/bin/bash # Description: Verify the Codecov badge link in the README.md file. # Test: Check if the Codecov badge link is correct. rg --type md '!\[codecov\]\(https://codecov.io/gh/PalisadoesFoundation/talawa-admin/branch/develop/graph/badge.svg\?token=II0R0RREES\)'Length of output: 770
24-32
: Ensure Table of Contents accuracy.Verify that the Table of Contents links match the corresponding sections in the document.
Verification successful
Table of Contents Verified
The Table of Contents links in the README.md file are accurate and correctly match the corresponding sections. No issues were found with the links.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the Table of Contents links in the README.md file. # Test: Check if the Table of Contents links are correct. rg --type md $'- \\[Talawa Components\\]\\(#talawa-components\\)\n- \\[Documentation\\]\\(#documentation\\)\n- \\[Videos\\]\\(#videos\\)'Length of output: 529
Script:
#!/bin/bash # Description: Verify the Table of Contents links in the README.md file. # Correct the pattern and check if the Table of Contents links are correct. rg --type md '\- \[Talawa Components\]\(#talawa-components\)\n\- \[Documentation\]\(#documentation\)\n\- \[Videos\]\(#videos\)' README.mdLength of output: 331
Script:
#!/bin/bash # Description: Verify the Table of Contents links in the README.md file. # Enable multiline mode to correctly match the Table of Contents links. rg --multiline --type md '\- \[Talawa Components\]\(#talawa-components\)\n\- \[Documentation\]\(#documentation\)\n\- \[Videos\]\(#videos\)' README.mdLength of output: 247
5-5
: Verify logo image accessibility.Ensure that the logo image link is correct and accessible.
Verification successful
Logo Image Accessibility Verified
The logo image link in the README.md file is correct and accessible, as confirmed by a successful HTTP status code of 200. No further action is required.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the logo image link in the README.md file. # Test: Check if the logo image link is correct. rg --type md $'\\!\\[talawa-logo-lite-200x200\\]\\(https://github.com/PalisadoesFoundation/talawa-admin/assets/16875803/26291ec5-d3c1-4135-8bc7-80885dff613d\\)'Length of output: 362
Script:
#!/bin/bash # Description: Verify the logo image link in the README.md file. # Corrected Test: Check if the logo image link is correct. rg --type md '!\[talawa-logo-lite-200x200\]\(https://github.com/PalisadoesFoundation/talawa-admin/assets/16875803/26291ec5-d3c1-4135-8bc7-80885dff613d\)'Length of output: 463
Script:
#!/bin/bash # Description: Check if the logo image URL is accessible. # Test: Use curl to check if the image URL returns a successful HTTP status code. curl -o /dev/null -s -w "%{http_code}\n" https://github.com/PalisadoesFoundation/talawa-admin/assets/16875803/26291ec5-d3c1-4135-8bc7-80885dff613dLength of output: 152
Script:
#!/bin/bash # Description: Check if the logo image URL is accessible by following redirects. # Test: Use curl to follow redirects and check the final HTTP status code. curl -o /dev/null -s -w "%{http_code}\n" -L https://github.com/PalisadoesFoundation/talawa-admin/assets/16875803/26291ec5-d3c1-4135-8bc7-80885dff613dLength of output: 155
.github/workflows/pull-request-target.yml (3)
21-24
: Verify the use of the action for commenting.Ensure that the action
thollander/actions-comment-pull-request@v2
is correctly configured and intended for use.Verification successful
Action is correctly configured for commenting.
The action
thollander/actions-comment-pull-request@v2
is present and configured in the.github/workflows/pull-request-target.yml
file with acomment_tag
, indicating it is set up for use in commenting as intended. No issues found with its configuration.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the use of `thollander/actions-comment-pull-request@v2`. # Test: Check if the action is correctly configured in the workflow. rg --type yaml $'uses: thollander/actions-comment-pull-request@v2'Length of output: 67
Script:
#!/bin/bash # Description: Verify the use of `thollander/actions-comment-pull-request@v2` specifically in the workflow file. # Test: Check if the action is correctly configured in the specified workflow file. rg 'uses: thollander/actions-comment-pull-request@v2' .github/workflows/pull-request-target.ymlLength of output: 154
12-14
: Ensure correct event trigger.The workflow is triggered on
pull_request_target
. Verify that this is the intended event.Verification successful
Event trigger confirmed.
The
pull_request_target
event trigger is correctly present in the.github/workflows/pull-request-target.yml
file. Ensure this is the intended behavior for your workflow.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the event trigger in the GitHub Actions workflow. # Test: Check if the workflow is triggered on `pull_request_target`. rg --type yaml $'on:\\n pull_request_target:'Length of output: 238
Script:
#!/bin/bash # Description: Verify the event trigger in the GitHub Actions workflow. # Test: Check if the workflow is triggered on `pull_request_target` using multiline mode. rg --type yaml -U 'on:\n pull_request_target:'Length of output: 49
Script:
#!/bin/bash # Description: Directly verify the presence of `pull_request_target` in the specified workflow file. # Test: Check for `pull_request_target` in the .github/workflows/pull-request-target.yml file. rg 'pull_request_target' .github/workflows/pull-request-target.ymlLength of output: 89
70-73
: Ensure secure handling of GitHub token.Verify that the GitHub token is correctly used and securely handled.
.github/workflows/eslint_disable_check.py (1)
104-106
: Ensure directory existence check is necessary.The directory existence check is crucial. Ensure that it is necessary and correctly implemented.
Verification successful
Directory Existence Check is Correctly Implemented and Necessary
The directory existence check in the
.github/workflows/eslint_disable_check.py
script is correctly implemented and is indeed necessary to ensure the script operates on a valid directory. This prevents potential errors during execution.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the directory existence check in the ESLint checker script. # Test: Check if the directory existence check is implemented. rg --type py $'if not os.path.exists\\(args.directory\\):'Length of output: 206
Script:
#!/bin/bash # Description: Verify the directory existence check in the ESLint checker script. # Test: Check if the directory existence check is implemented. # Ensure all Python files are searched. rg 'if not os.path.exists\(args.directory\):' --type py --debugLength of output: 180820
Script:
#!/bin/bash # Description: Locate the Python script file in the .github/workflows directory and verify the directory existence check. # Find the Python script in the .github/workflows directory. fd --extension py --exec cat # Verify the directory existence check in the located Python script. rg 'if not os.path.exists\(args.directory\):' .github/workflows/*.pyLength of output: 407
.eslintrc.json (10)
4-4
: Node.js environment inclusion.The addition of
"node": true
in the environment settings expands linting to server-side JavaScript, which is beneficial for projects using Node.js. Ensure this aligns with your project's requirements.
32-39
: Expanded plugin support.The addition of plugins like
"import"
,"eslint-plugin-tsdoc"
, and"prettier"
enhances import handling, documentation standards, and formatting consistency. Ensure these plugins are correctly configured and meet project needs.
41-42
: Stricter React and TypeScript rules.Changing
react/destructuring-assignment
to an error and adding@typescript-eslint/explicit-module-boundary-types
as an error enforces stricter coding standards. This can improve code quality but may require refactoring existing code.
55-56
: Import duplicates check.The rule
"import/no-duplicates": "error"
prevents duplicate imports, which is a good practice for maintaining clean and efficient code.
56-56
: TSDoc syntax enforcement.The
"tsdoc/syntax": "error"
rule enforces TSDoc syntax, which is beneficial for maintaining consistent documentation standards.
57-58
: TypeScript comment and type safety rules.The rules
@typescript-eslint/ban-ts-comment
and@typescript-eslint/no-explicit-any
enhance type safety by discouraging unsafe practices. Ensure existing code complies with these rules.
75-75
: Camelcase rule disabled.Disabling the
camelcase
rule provides flexibility in naming conventions. Ensure this aligns with your project's style guide.
76-119
: Naming conventions for TypeScript.The
@typescript-eslint/naming-convention
rule enforces consistent naming conventions across interfaces, types, variables, and functions. This helps maintain a uniform codebase.
131-132
: Jest expectation rule adjustment.The
"jest/expect-expect": 0
rule disables the requirement for assertions in tests, which can be useful in certain testing scenarios. Ensure this aligns with your testing strategy.
14-16
: Ensure compatibility with Prettier.The inclusion of
"plugin:prettier/recommended"
,"eslint-config-prettier"
, and"prettier"
extends Prettier integration. Make sure this does not conflict with other formatting rules.Verification successful
Prettier integration is correctly configured.
The ESLint configuration includes
"prettier/prettier": "error"
, which enforces Prettier formatting rules. This setup, along with"plugin:prettier/recommended"
,"eslint-config-prettier"
, and"prettier"
, ensures compatibility and prevents conflicts with other ESLint rules. No issues were found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify Prettier integration does not conflict with other ESLint rules. # Test: Search for Prettier-related rules. Expect: No conflicting rules. rg --type json --json-pretty 'prettier/prettier'Length of output: 486
Script:
#!/bin/bash # Description: Verify Prettier integration does not conflict with other ESLint rules. # Test: Search for Prettier-related rules in JSON files. Expect: No conflicting rules. rg --type json 'prettier/prettier'Length of output: 164
package.json (7)
2-3
: Project metadata update.The project name has been updated to
"talawa-admin"
and version to"3.0.0"
, indicating a major release. Ensure all references to the project name are updated accordingly.
6-6
: Config overrides path.The new field
"config-overrides-path"
specifies a custom configuration path. Ensure this path is correct and accessible.
62-76
: Script enhancements.The updated scripts for serving, building, and testing indicate a refined development workflow. Ensure these scripts are tested and documented for team usage.
134-142
: Node.js engine requirement.The new
"engines"
field specifies"node": ">=20.x"
, requiring a recent Node.js version. Ensure deployment environments meet this requirement.
143-147
: Lint-staged configuration.The
"lint-staged"
configuration ensures code quality before commits. This is a good practice for maintaining a clean codebase.
8-59
: Dependency updates and additions.The extensive updates and additions to dependencies, including Apollo Client and MUI components, suggest a significant shift in project capabilities. Verify compatibility and test thoroughly.
97-132
: DevDependency updates.The updates to devDependencies, including TypeScript and ESLint plugins, enhance development capabilities. Ensure these updates do not introduce breaking changes.
PR_GUIDELINES.md (2)
21-23
: Issue and PR guidelines.Clear guidelines for associating PRs with issues and closing them automatically. This aligns well with GitHub best practices.
54-55
: Branch submission guidelines.Clear instructions on submitting PRs against the
develop
branch. This helps maintain a stable main branch.setup.ts (1)
4-8
: Verify the existence of imported modules.Ensure that the modules
checkConnection
,askForTalawaApiUrl
,checkEnvFile
,validateRecaptcha
, andaskForCustomPort
exist and are correctly implemented.Verification successful
All imported modules exist. The modules
checkConnection
,askForTalawaApiUrl
,checkEnvFile
,validateRecaptcha
, andaskForCustomPort
are present in the codebase as expected.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify existence of imported modules in the `src/setup` directory. fd 'checkConnection.ts' --exec echo "Found: {}" || echo "Missing: checkConnection.ts" fd 'askForTalawaApiUrl.ts' --exec echo "Found: {}" || echo "Missing: askForTalawaApiUrl.ts" fd 'checkEnvFile.ts' --exec echo "Found: {}" || echo "Missing: checkEnvFile.ts" fd 'validateRecaptcha.ts' --exec echo "Found: {}" || echo "Missing: validateRecaptcha.ts" fd 'askForCustomPort.ts' --exec echo "Found: {}" || echo "Missing: askForCustomPort.ts"Length of output: 518
.github/workflows/push.yml (4)
19-21
: Ensure secure handling of environment variables.The
CODECOV_UNIQUE_NAME
environment variable includesgithub.run_id
andgithub.run_number
, which could potentially expose sensitive information if logged or misused. Ensure that these variables are handled securely.
100-101
: Review dependency management strategy.Running
yarn upgrade
updates all dependencies to their latest versions, which could lead to unexpected issues if not thoroughly tested. Consider specifying versions or using a tool like Renovate to manage dependency updates.
165-167
: Ensure secure handling of credentials.The use of
secrets.TALAWA_DOCS_SYNC
in thegit config
command should be reviewed to ensure that credentials are not exposed in logs or error messages.
177-184
: Verify destination repository and branch.Ensure that the
destination_repo
anddestination_branch
are correctly specified and that necessary permissions are in place for theAPI_TOKEN_GITHUB
to perform the copy operation.src/GraphQl/Mutations/OrganizationMutations.ts (10)
12-25
: Ensure alignment with backend schema.Verify that the mutation
updateUserRoleInOrganization
and its return fields align with the backend schema. Ensure that the_id
field is sufficient for the client-side logic.
34-38
: Verify backend handling of sample organizations.Ensure that the backend appropriately handles the creation of sample organizations and that the mutation returns the necessary fields for client-side use.
46-50
: Ensure correct backend handling of sample organization removal.Verify that the backend correctly handles the removal of sample organizations and that the mutation returns the necessary fields for client-side logic.
60-75
: Verify backend support for group chat creation.Ensure that the backend supports the creation of group chats with the specified parameters, including
userIds
,organizationId
, andtitle
.
78-86
: Ensure backend support for direct chat creation with optional organization ID.Verify that the backend supports the creation of direct chats with optional
organizationId
and that the mutation returns the necessary fields.
88-106
: Verify backend support for direct chat messaging.Ensure that the backend supports sending messages to direct chats and that all necessary fields are returned for client-side use.
109-122
: Ensure backend support for group chat messaging.Verify that the backend supports sending messages to group chats and that all necessary fields are returned for client-side use.
125-140
: Verify backend support for message chat creation.Ensure that the backend supports the creation of message chats with the specified parameters and that all necessary fields are returned.
143-165
: Ensure backend support for direct chat message subscription.Verify that the backend supports the subscription for messages sent to direct chats and that all necessary fields are returned for client-side use.
167-183
: Verify backend support for group chat message subscription.Ensure that the backend supports the subscription for messages sent to group chats and that all necessary fields are returned for client-side use.
src/GraphQl/Queries/OrganizationQueries.ts (8)
15-71
: Ensure backend support for organization post listing.Verify that the backend supports the query structure for listing organization posts and that all necessary fields are returned for client-side use.
74-109
: Verify backend support for organization advertisement listing.Ensure that the backend supports the query structure for listing organization advertisements and that all necessary fields are returned.
122-168
: Ensure backend support for user organization connection query.Verify that the backend supports the query structure for retrieving organizations based on user connection and that all necessary fields are returned.
178-206
: Verify backend support for user joined organizations query.Ensure that the backend supports the query structure for retrieving organizations joined by a user and that all necessary fields are returned.
216-244
: Ensure backend support for user created organizations query.Verify that the backend supports the query structure for retrieving organizations created by a user and that all necessary fields are returned.
254-266
: Verify backend support for organization admins list query.Ensure that the backend supports the query structure for retrieving the list of admins for a specific organization and that all necessary fields are returned.
275-288
: Ensure backend support for organization funds query.Verify that the backend supports the query structure for retrieving the list of funds for a specific organization and that all necessary fields are returned.
297-319
: Verify backend support for venue list query.Ensure that the backend supports the query structure for retrieving the list of venues for a specific organization and that all necessary fields are returned.
src/GraphQl/Queries/PlugInQueries.ts (10)
9-19
: LGTM!The
PLUGIN_GET
query is well-structured and documented.
27-45
: LGTM!The
ADVERTISEMENTS_GET
query is well-structured and documented.
59-100
: LGTM!The
ORGANIZATION_EVENTS_CONNECTION
query is well-structured, comprehensive, and documented.
111-133
: LGTM!The
DIRECT_CHAT_MESSAGES_BY_CHAT_ID
query is well-structured and documented.
135-167
: LGTM!The
DIRECT_CHAT_BY_ID
query is well-structured, comprehensive, and documented.
169-196
: LGTM!The
GROUP_CHAT_BY_ID
query is well-structured, comprehensive, and documented.
222-262
: LGTM!The
DIRECT_CHATS_LIST
query is well-structured, comprehensive, and documented.
264-299
: LGTM!The
GROUP_CHAT_LIST
query is well-structured, comprehensive, and documented.
307-311
: LGTM!The
IS_SAMPLE_ORGANIZATION_QUERY
is well-structured and documented.
320-328
: LGTM!The
ORGANIZATION_CUSTOM_FIELDS
query is well-structured and documented..github/workflows/countline.py (5)
35-55
: LGTM!The
_valid_filename
function is well-implemented and correctly identifies invalid filenames.
58-78
: LGTM!The
_valid_extension
function is well-implemented and correctly identifies invalid extensions.
81-119
: LGTM!The
_valid_exclusions
function is well-implemented and correctly handles exclusions.
122-142
: LGTM!The
_filepaths_in_directories
function is well-implemented and effectively retrieves file paths.
145-194
: LGTM!The
_arg_parser_resolver
function is well-structured and correctly parses CLI arguments.src/App.tsx (1)
1-45
: LGTM!The import statements are well-organized and necessary for the functionality of the file.
.github/workflows/pull-request.yml (5)
38-41
: Verify the functionality ofcountline.py
.The script
countline.py
is used to count lines but excludes specific files. Ensure that the script functions correctly and is necessary for the workflow.Verification successful
The
countline.py
script functions as expected.The script is designed to analyze directories for files exceeding a specified number of lines, excluding certain files and directories as specified by command-line arguments. It correctly implements the functionality to encourage efficient coding practices by reporting files with excessive lines of code. No issues were found with its logic.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the functionality of countline.py. # Test: Run the script and check for expected output. python ./.github/workflows/countline.py --lines 600 --exclude_files src/screens/LoginPage/LoginPage.tsx src/GraphQl/Queries/Queries.ts src/screens/OrgList/OrgList.tsx src/GraphQl/Mutations/mutations.ts src/components/EventListCard/EventListCardModals.tsxLength of output: 330
Script:
#!/bin/bash # Display the contents of countline.py to analyze its functionality cat ./.github/workflows/countline.pyLength of output: 7416
19-20
: Ensure the uniqueness ofCODECOV_UNIQUE_NAME
.The environment variable
CODECOV_UNIQUE_NAME
is constructed usinggithub.run_id
andgithub.run_number
. Verify that this combination ensures uniqueness across runs.Verification successful
The combination of
github.run_id
andgithub.run_number
ensures uniqueness forCODECOV_UNIQUE_NAME
.The verification script found no duplicates in recent GitHub Actions runs using available fields, indicating that the current approach effectively ensures uniqueness.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Ensure uniqueness of CODECOV_UNIQUE_NAME across runs. # Test: Check for uniqueness in recent GitHub Actions runs. gh run list --limit 10 --json runId,runNumber | jq '.[] | "\(.runId)-\(.runNumber)"' | sort | uniq -dLength of output: 334
Script:
#!/bin/bash # Description: Ensure uniqueness of CODECOV_UNIQUE_NAME across runs using available fields. # Test: Check for uniqueness in recent GitHub Actions runs using `number` and `createdAt`. gh run list --limit 10 --json number,createdAt | jq '.[] | "\(.number)-\(.createdAt)"' | sort | uniq -dLength of output: 105
226-233
: Ensure correct branch is cloned for API repository.The script clones the API repository using the base branch name. Verify that this branch exists and is correct.
Verification successful
Branch existence check is valid with correct substitution.
The script correctly checks for the branch's existence when the branch name is properly substituted. The issue observed was due to incorrect syntax for substitution in a non-GitHub Actions environment. In the actual GitHub Actions environment,
${{ github.base_ref }}
will be correctly replaced with the base branch name. Ensure that the branch name is accurately passed in the GitHub Actions context.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Ensure correct branch is cloned for API repository. # Test: Check if the branch exists in the remote repository. git ls-remote --heads https://github.com/PalisadoesFoundation/talawa-api | grep -q ${{ github.base_ref }}Length of output: 163
Script:
#!/bin/bash # Description: Simulate checking if a branch exists in the remote repository. # Placeholder for the branch name (replace with actual branch name for real verification) BRANCH_NAME="main" # Check if the branch exists in the remote repository. git ls-remote --heads https://github.com/PalisadoesFoundation/talawa-api | grep -q "refs/heads/$BRANCH_NAME" && echo "Branch exists" || echo "Branch does not exist"Length of output: 156
55-59
: Ensure ESLint is configured correctly for modified files.The ESLint step checks for linting errors in modified files. Verify that
CHANGED_FILES
is correctly populated and that ESLint is configured to handle these files.Verification successful
ESLint configuration and CHANGED_FILES usage are correctly set up.
The ESLint configuration file
.eslintrc.json
is present, and the workflow correctly uses thechanged-files
action to populateCHANGED_FILES
. This confirms that ESLint is configured to handle modified files as intended.
- ESLint configuration file found:
.eslintrc.json
changed-files
action correctly implemented in the workflow.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Ensure ESLint configuration for modified files. # Test: Run ESLint on a sample file to confirm configuration. npx eslint src/sample.jsLength of output: 97
Script:
#!/bin/bash # Search for ESLint configuration files in the repository fd --type f --name ".eslintrc*" # Check how CHANGED_FILES is defined and used in the workflow file rg 'CHANGED_FILES' .github/workflows/pull-request.yml -A 5Length of output: 1382
Script:
#!/bin/bash # Correct the search for ESLint configuration files fd --type f -g ".eslintrc*" # Investigate how the changed_files step is defined in the workflow rg 'changed-files' .github/workflows/pull-request.yml -A 5Length of output: 2449
Script:
#!/bin/bash # Search for ESLint configuration files, including hidden files fd --type f -g ".eslintrc*" --hiddenLength of output: 53
205-209
: Verify minimum coverage threshold.The minimum coverage threshold is set to 95%. Ensure this value aligns with project goals and is achievable.
CODE_STYLE.md (3)
49-51
: Ensure naming conventions are consistently applied.The document specifies naming conventions for React components and other files. Ensure that these conventions are consistently applied across the codebase.
53-55
: Clarify use of modular CSS.The guideline discourages the use of custom classes directly and encourages modular CSS. Ensure this practice is consistently applied.
71-71
: Ensure React-Bootstrap and Material UI usage.The guideline recommends using React-Bootstrap and Material UI components. Verify that these libraries are consistently used instead of plain Bootstrap.
src/GraphQl/Queries/Queries.ts (10)
5-29
: LGTM!The
CHECK_AUTH
query is well-structured and retrieves necessary fields.
32-61
: LGTM!The
ORGANIZATION_LIST
query is comprehensive and well-structured.
64-103
: LGTM!The
ORGANIZATION_CONNECTION_LIST
query is well-structured and flexible.
106-201
: LGTM!The
USER_LIST
query is comprehensive and well-structured.
202-220
: LGTM!The
USER_LIST_FOR_TABLE
query is simple and focused on essential details.
222-263
: LGTM!The
USER_LIST_REQUEST
query is comprehensive and well-structured.
265-290
: LGTM!The
EVENT_DETAILS
query is well-structured and retrieves detailed event information.
292-302
: LGTM!The
EVENT_ATTENDEES
query is simple and focused on attendee details.
304-322
: LGTM!The
EVENT_CHECKINS
query is well-structured and retrieves necessary fields.
324-336
: LGTM!The
EVENT_FEEDBACKS
query is simple and focused on feedback details.src/GraphQl/Mutations/mutations.ts (10)
3-9
: LGTM!The
UNBLOCK_USER_MUTATION
is well-structured and uses appropriate input parameters.
13-19
: LGTM!The
BLOCK_USER_MUTATION
is well-structured and uses appropriate input parameters.
23-29
: LGTM!The
REJECT_ORGANIZATION_REQUEST_MUTATION
is well-structured and uses appropriate input parameters.
33-39
: LGTM!The
ACCEPT_ORGANIZATION_REQUEST_MUTATION
is well-structured and uses appropriate input parameters.
43-67
: LGTM!The
UPDATE_ORGANIZATION_MUTATION
is well-structured and includes necessary details.
85-121
: LGTM!The
UPDATE_USER_MUTATION
is well-structured and uses appropriate input parameters.
125-143
: LGTM!The
UPDATE_USER_PASSWORD_MUTATION
is well-structured and uses appropriate input parameters.
147-171
: LGTM!The
SIGNUP_MUTATION
is well-structured and uses appropriate input parameters.
175-196
: LGTM!The
LOGIN_MUTATION
is well-structured and uses appropriate input parameters.
200-207
: LGTM!The
REFRESH_TOKEN_MUTATION
is well-structured and uses appropriate input parameters.public/locales/zh/translation.json (1)
1-984
: Ensure consistency and accuracy in translations.The translation keys and values seem consistent and well-organized. However, ensure that translations accurately reflect the intended meaning in the context of the application.
schema.graphql (1)
1-1584
: Verify the completeness and consistency of type definitions.The schema is comprehensive and covers a wide range of entities. Ensure that all necessary fields are included for each type and that relationships between types are logically consistent.
public/locales/en/translation.json (3)
30-30
: Typographical Error: "Atleast" should be "At least".The phrase "Atleast 8 Character long" should be corrected to "At least 8 characters long" for clarity and correctness.
31-31
: Consistency Improvement: Remove period from key.The key "Password_and_Confirm_password_mismatches." contains a period, which is inconsistent with other keys. Consider removing it for consistency.
35-35
: Grammar Improvement: Use "Please try again later".The phrase "Please try after sometime" is less common. Consider using "Please try again later" for better clarity and standard usage.
public/locales/hi/translation.json (20)
1-2
: Consistent JSON structure.The JSON structure is consistent and well-organized, with clear sectioning for different UI components.
43-46
: Translation accuracy for event messages.The translations for event-related messages appear accurate and contextually appropriate.
48-51
: Translation accuracy for post messages.The translations for post-related messages are accurate and contextually appropriate.
53-54
: Translation accuracy for navbar roles.The translation for "roles" is accurate.
56-59
: Translation accuracy for left drawer items.The translations for navigation items in the left drawer are accurate and consistent.
61-78
: Translation accuracy for organization drawer items.The translations for organization-related navigation items are accurate and consistent.
80-108
: Translation accuracy for organization list messages.The translations for organization list-related messages are accurate and contextually appropriate.
110-112
: Translation accuracy for organization list card.The translations for managing organizations are accurate.
114-116
: Translation accuracy for pagination controls.The translations for pagination controls are accurate.
118-129
: Translation accuracy for membership requests.The translations for handling membership requests are accurate and consistent.
131-153
: Translation accuracy for user-related messages.The translations for user-related actions and messages are accurate and consistent.
155-165
: Translation accuracy for community profile settings.The translations for community profile settings are accurate.
167-181
: Translation accuracy for dashboard messages.The translations for dashboard-related messages are accurate and consistent.
183-201
: Translation accuracy for organization people management.The translations for managing people within an organization are accurate.
203-205
: Translation accuracy for user list actions.The translations for user list actions are accurate.
207-211
: Translation accuracy for organization admin management.The translations for managing organization admins are accurate.
213-217
: Translation accuracy for organization member management.The translations for managing organization members are accurate.
219-248
: Translation accuracy for organization event management.The translations for managing events within an organization are accurate and consistent.
250-284
: Translation accuracy for organization action items.The translations for managing action items within an organization are accurate.
31-31
: Duplicate message detected.The message "पासवर्ड और पासवर्ड बेमेल होने की पुष्टि करें।" appears to be duplicated in both
loginPage
anduserLoginPage
sections. Ensure this duplication is intentional.public/locales/sp/translation.json (10)
2-43
: Translations look consistent and accurate.The
loginPage
section translations are well-structured and correctly formatted.
45-75
: Translations are consistent withloginPage
.The
userLoginPage
section maintains consistency in translations and key naming conventions.
77-80
: Translations are accurate and consistent.The
latestEvents
section is well-structured and translations are accurate.
82-85
: Translations are accurate and consistent.The
latestPosts
section is well-structured and translations are accurate.
87-91
: Translations are accurate and consistent.The
listNavbar
section is well-structured and translations are accurate.
93-100
: Translations are accurate and consistent.The
leftDrawer
section is well-structured and translations are accurate.
102-125
: Translations are accurate and consistent.The
leftDrawerOrg
section is well-structured and translations are accurate.
126-162
: Translations are accurate and consistent.The
orgList
section is well-structured and translations are accurate.
164-168
: Translations are accurate and consistent.The
orgListCard
section is well-structured and translations are accurate.
170-172
: Translations are accurate and consistent.The
paginationList
section is well-structured and translations are accurate.
const { override, addWebpackPlugin } = require('customize-cra'); | ||
const webpack = require('webpack'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using import
statements for consistency.
Using import
statements instead of require
can improve consistency with ES6 modules, which are commonly used in modern JavaScript projects.
- const { override, addWebpackPlugin } = require('customize-cra');
- const webpack = require('webpack');
+ import { override, addWebpackPlugin } from 'customize-cra';
+ import webpack from 'webpack';
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
const { override, addWebpackPlugin } = require('customize-cra'); | |
const webpack = require('webpack'); | |
import { override, addWebpackPlugin } from 'customize-cra'; | |
import webpack from 'webpack'; |
// Modify infrastructureLogging level | ||
(config) => { | ||
config.infrastructureLogging = { | ||
level: 'verbose', | ||
}; | ||
return config; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider making the logging level configurable.
Hardcoding the logging level to 'verbose' might not be suitable for all environments. Consider making it configurable based on environment variables or other settings.
- config.infrastructureLogging = {
- level: 'verbose',
- };
+ config.infrastructureLogging = {
+ level: process.env.WEBPACK_LOGGING_LEVEL || 'verbose',
+ };
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
// Modify infrastructureLogging level | |
(config) => { | |
config.infrastructureLogging = { | |
level: 'verbose', | |
}; | |
return config; | |
// Modify infrastructureLogging level | |
(config) => { | |
config.infrastructureLogging = { | |
level: process.env.WEBPACK_LOGGING_LEVEL || 'verbose', | |
}; | |
return config; |
The process in easy: | ||
1. Install `talawa-docs` on your system | ||
1. Launch docusaurus on your system according to the `talawa-docs`documentation. | ||
- A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix grammatical error and bare URL.
- The sentence "A local version of
docs.talawa.io
should automatically launched..." should use "launch" instead of "launched." - Replace the bare URL with a Markdown link for consistency.
- A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/
+ A local version of `docs.talawa.io` should automatically launch in your browser at [http://localhost:3000](http://localhost:3000)
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
The process in easy: | |
1. Install `talawa-docs` on your system | |
1. Launch docusaurus on your system according to the `talawa-docs`documentation. | |
- A local version of `docs.talawa.io` should automatically launched in your browser at http://localhost:3000/ | |
The process in easy: | |
1. Install `talawa-docs` on your system | |
1. Launch docusaurus on your system according to the `talawa-docs`documentation. | |
- A local version of `docs.talawa.io` should automatically launch in your browser at [http://localhost:3000](http://localhost:3000) |
Tools
LanguageTool
[grammar] ~25-~25: The modal verb ‘should’ requires the verb’s base form.
Context: ...fdocs.talawa.io
should automatically launched in your browser at http://localhost:300...(MD_BASEFORM)
Markdownlint
25-25: null
Bare URL used(MD034, no-bare-urls)
- [Our Standards](#our-standards) | ||
- [Enforcement Responsibilities](#enforcement-responsibilities) | ||
- [Scope](#scope) | ||
- [Enforcement](#enforcement) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix repeated word in Table of Contents.
There is a repeated word "Enforcement" in the Table of Contents.
- - [Enforcement](#enforcement)
Committable suggestion was skipped due to low confidence.
Tools
LanguageTool
[duplication] ~11-~11: Possible typo: you repeated a word
Context: ...-responsibilities) - Scope - Enforcement - Enforcement Guidelines ...(ENGLISH_WORD_REPEAT_RULE)
$btn-close-padding-x: 0.25em; | ||
$btn-close-padding-y: $btn-close-padding-x; | ||
$btn-close-color: $black; | ||
$btn-close-bg: url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 16 16' fill='#{$btn-close-color}'><path d='M.293.293a1 1 0 0 1 1.414 0L8 6.586 14.293.293a1 1 0 1 1 1.414 1.414L9.414 8l6.293 6.293a1 1 0 0 1-1.414 1.414L8 9.414l-6.293 6.293a1 1 0 0 1-1.414-1.414L6.586 8 .293 1.707a1 1 0 0 1 0-1.414z'/></svg>"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a data URI encoding function.
The inline SVG uses a hardcoded data URI. Consider using a SCSS function to encode SVGs, which can improve maintainability.
@function svg-url($svg) {
$encoded-svg: url("data:image/svg+xml,#{$svg}");
@return $encoded-svg;
}
$btn-close-bg: svg-url("<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 16 16' fill='#{$btn-close-color}'><path d='M.293.293a1 1 0 0 1 1.414 0L8 6.586 14.293.293a1 1 0 1 1 1.414 1.414L9.414 8l6.293 6.293a1 1 0 0 1-1.414 1.414L8 9.414l-6.293 6.293a1 1 0 0 1-1.414-1.414L6.586 8 .293 1.707a1 1 0 0 1 0-1.414z'/></svg>");
|
||
The Palisadoes Foundation has a Slack channel where members can assist with support and clarification. Click [here](https://join.slack.com/t/thepalisadoes-dyb6419/shared_invite/zt-nk79xxlg-OxTdlrD7RLaswu8EO_Q5rg) to join our slack channel. | ||
1. The Palisadoes Foundation has a Slack channel where members can assist with support and clarification. Visit the [Talawa GitHub repository home page](https://github.com/PalisadoesFoundation/talawa) for the link to join our slack channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize "Slack" for proper noun consistency.
Capitalize "Slack" for consistency with its usage as a proper noun.
- Visit the [Talawa GitHub repository home page](https://github.com/PalisadoesFoundation/talawa) for the link to join our slack channel.
+ Visit the [Talawa GitHub repository home page](https://github.com/PalisadoesFoundation/talawa) for the link to join our Slack channel.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
1. The Palisadoes Foundation has a Slack channel where members can assist with support and clarification. Visit the [Talawa GitHub repository home page](https://github.com/PalisadoesFoundation/talawa) for the link to join our slack channel. | |
1. The Palisadoes Foundation has a Slack channel where members can assist with support and clarification. Visit the [Talawa GitHub repository home page](https://github.com/PalisadoesFoundation/talawa) for the link to join our Slack channel. |
Tools
LanguageTool
[grammar] ~172-~172: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...dation/talawa) for the link to join our slack channel. 1. We also have a technical em...(ON_SKYPE)
- Release branches (release/1.XX) | ||
- Bug branches (bugfix/branch-name) | ||
- Hotfix branches (hotfix/branch-name) | ||
When multiple developers are working on issues there is bound to be a conflict of interest (not to be confused with git conflicts) among issues, PRs or even ideas. Usually these conflicts are resolved in a **First Come First Serve** basis however there are certain exceptions to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add commas for clarity.
Add commas after "issues" and "Usually" for better readability.
- When multiple developers are working on issues there is bound to be a conflict of interest (not to be confused with git conflicts) among issues, PRs or even ideas. Usually these conflicts are resolved in a **First Come First Serve** basis however there are certain exceptions to it.
+ When multiple developers are working on issues, there is bound to be a conflict of interest (not to be confused with git conflicts) among issues, PRs, or even ideas. Usually, these conflicts are resolved on a **First Come, First Served** basis; however, there are certain exceptions to it.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
When multiple developers are working on issues there is bound to be a conflict of interest (not to be confused with git conflicts) among issues, PRs or even ideas. Usually these conflicts are resolved in a **First Come First Serve** basis however there are certain exceptions to it. | |
When multiple developers are working on issues, there is bound to be a conflict of interest (not to be confused with git conflicts) among issues, PRs, or even ideas. Usually, these conflicts are resolved on a **First Come, First Served** basis; however, there are certain exceptions to it. |
Tools
LanguageTool
[typographical] ~67-~67: Consider adding a comma.
Context: ...ultiple developers are working on issues there is bound to be a conflict of interest (...(IF_THERE_COMMA)
[typographical] ~67-~67: Consider adding a comma after ‘Usually’ for more clarity.
Context: ...licts) among issues, PRs or even ideas. Usually these conflicts are resolved in a **Fir...(RB_LY_COMMA)
[grammar] ~67-~67: Did you mean “served” (as in the idiom ‘first come, first served’)?
Context: ...ts are resolved in a First Come First Serve basis however there are certain excep...(FIRST_SERVED)
- In the cases where you feel your potential issues could be an extension or in conflict with other PRs it is important to ask the author of the PR in the slack channel or in their PRs or issues themselves why he/she did not write code for something that would require minimal effort on their part. | ||
- Based on basic courtesy, it is good practice to let the person who created a function apply and test that function when needed. | ||
- Last but not the least, communication is important make sure to talk to other contributors, in these cases, in slack channel or in a issue/PR thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize "Slack" and improve phrasing.
Capitalize "Slack" and improve phrasing for clarity and correctness.
- it is important to ask the author of the PR in the slack channel or in their PRs or issues themselves why he/she did not write code for something that would require minimal effort on their part.
- communication is important make sure to talk to other contributors, in these cases, in slack channel or in a issue/PR thread.
+ it is important to ask the author of the PR in the Slack channel or in their PRs or issues themselves why they did not write code for something that would require minimal effort on their part.
+ Communication is important; make sure to talk to other contributors, in these cases, in the Slack channel or in an issue/PR thread.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- In the cases where you feel your potential issues could be an extension or in conflict with other PRs it is important to ask the author of the PR in the slack channel or in their PRs or issues themselves why he/she did not write code for something that would require minimal effort on their part. | |
- Based on basic courtesy, it is good practice to let the person who created a function apply and test that function when needed. | |
- Last but not the least, communication is important make sure to talk to other contributors, in these cases, in slack channel or in a issue/PR thread. | |
- In the cases where you feel your potential issues could be an extension or in conflict with other PRs it is important to ask the author of the PR in the Slack channel or in their PRs or issues themselves why they did not write code for something that would require minimal effort on their part. | |
- Based on basic courtesy, it is good practice to let the person who created a function apply and test that function when needed. | |
- Communication is important; make sure to talk to other contributors, in these cases, in the Slack channel or in an issue/PR thread. |
Tools
LanguageTool
[uncategorized] ~69-~69: Possible missing comma found.
Context: ... an extension or in conflict with other PRs it is important to ask the author of th...(AI_HYDRA_LEO_MISSING_COMMA)
[grammar] ~69-~69: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ...tant to ask the author of the PR in the slack channel or in their PRs or issues thems...(ON_SKYPE)
[style] ~71-~71: ‘Last but not the least’ might be wordy. Consider a shorter alternative.
Context: ...y and test that function when needed. - Last but not the least, communication is important make sure t...(EN_WORDINESS_PREMIUM_LAST_BUT_NOT_THE_LEAST)
[grammar] ~71-~71: It seems that “to” is missing before the verb.
Context: ...t the least, communication is important make sure to talk to other contributors, in ...(MISSING_TO_BETWEEN_BE_AND_VB)
[grammar] ~71-~71: Did you mean the communication tool “Slack” (= proper noun, capitalized)?
Context: ... other contributors, in these cases, in slack channel or in a issue/PR thread. - As a...(ON_SKYPE)
[misspelling] ~71-~71: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ... in these cases, in slack channel or in a issue/PR thread. - As a last resort the...(EN_A_VS_AN)
- `develop`: For unstable code and bug fixing | ||
- `main`: Where the stable production ready code lies. This is our default branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use hyphen in compound adjectives.
Consider using a hyphen in "production-ready" for grammatical correctness.
- `main`: Where the stable production ready code lies.
+ `main`: Where the stable production-ready code lies.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- `develop`: For unstable code and bug fixing | |
- `main`: Where the stable production ready code lies. This is our default branch. | |
- `develop`: For unstable code and bug fixing | |
- `main`: Where the stable production-ready code lies. This is our default branch. |
Tools
LanguageTool
[uncategorized] ~62-~62: Loose punctuation mark.
Context: ...ushed to themain
branch: -develop
: For unstable code and bug fixing - `mai...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~63-~63: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...d bug fixing -main
: Where the stable production ready code lies. This is our default branch. ...(EN_COMPOUND_ADJECTIVE_INTERNAL)
1. After making changes you can add them to git locally using `git add <file_name>`(to add changes only in a particular file) or `git add .` (to add all changes). | ||
1. After adding the changes you need to commit them using `git commit -m '<commit message>'`(look at the commit guidelines below for commit messages). | ||
1. Once you have successfully commited your changes, you need to push the changes to the forked repo on github using: `git push origin <branch_name>`.(Here branch name must be name of the branch you want to push the changes to.) | ||
1. Now create a pull request to the Talawa-admin repository from your forked repo. Open an issue regarding the same and link your PR to it. | ||
1. Ensure the test suite passes, either locally or on CI once a PR has been created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add missing commas for clarity.
Add commas for better readability and grammatical correctness.
- After making changes you can add them to git locally using `git add <file_name>`(to add changes only in a particular file) or `git add .` (to add all changes).
- Once you have successfully commited your changes, you need to push the changes to the forked repo on github using: `git push origin <branch_name>`.(Here branch name must be name of the branch you want to push the changes to.)
- Ensure the test suite passes, either locally or on CI once a PR has been created.
+ After making changes, you can add them to git locally using `git add <file_name>` (to add changes only in a particular file) or `git add .` (to add all changes).
+ Once you have successfully committed your changes, you need to push the changes to the forked repo on GitHub using: `git push origin <branch_name>`. (Here, the branch name must be the name of the branch you want to push the changes to.)
+ Ensure the test suite passes, either locally or on CI, once a PR has been created.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
1. After making changes you can add them to git locally using `git add <file_name>`(to add changes only in a particular file) or `git add .` (to add all changes). | |
1. After adding the changes you need to commit them using `git commit -m '<commit message>'`(look at the commit guidelines below for commit messages). | |
1. Once you have successfully commited your changes, you need to push the changes to the forked repo on github using: `git push origin <branch_name>`.(Here branch name must be name of the branch you want to push the changes to.) | |
1. Now create a pull request to the Talawa-admin repository from your forked repo. Open an issue regarding the same and link your PR to it. | |
1. Ensure the test suite passes, either locally or on CI once a PR has been created. | |
1. After making changes, you can add them to git locally using `git add <file_name>` (to add changes only in a particular file) or `git add .` (to add all changes). | |
1. After adding the changes you need to commit them using `git commit -m '<commit message>'`(look at the commit guidelines below for commit messages). | |
1. Once you have successfully committed your changes, you need to push the changes to the forked repo on GitHub using: `git push origin <branch_name>`. (Here, the branch name must be the name of the branch you want to push the changes to.) | |
1. Now create a pull request to the Talawa-admin repository from your forked repo. Open an issue regarding the same and link your PR to it. | |
1. Ensure the test suite passes, either locally or on CI, once a PR has been created. |
Tools
LanguageTool
[uncategorized] ~157-~157: Possible missing comma found.
Context: ...odecov/results.jpg)]() 1. After making changes you can add them to git locally using `...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~159-~159: Possible missing comma found.
Context: ...using:git push origin <branch_name>
.(Here branch name must be name of the branch ...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~159-~159: Possible missing article found.
Context: ...:git push origin <branch_name>
.(Here branch name must be name of the branch you wan...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~159-~159: Possible missing article found.
Context: ...branch_name>`.(Here branch name must be name of the branch you want to push the chan...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~161-~161: Possible missing comma found.
Context: ...test suite passes, either locally or on CI once a PR has been created. 1. Review a...(AI_HYDRA_LEO_MISSING_COMMA)
There are too many files in the PR. Closing. Base your PR on the current |
Summary of changes-- update the package.json file @testing-library/user-event from 12.8.3 to 14.5.2
Issue -- #2072
Testing and Verification-- Verified the changes locally by ensuring that the new comments correctly close the linked issues. No new tests were added as the changes were related to comments and documentation.
Summary by CodeRabbit
New Features
Style
Documentation