feat: Use full XPaths for config "set" operations #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kklimonda-cl
force-pushed
the
feat-strip-entry-from-marshalled-data
branch
from
12be24f
to
ec4fec9
Compare
migara
approved these changes
Aug 1, 2024
| } | ||
|
|
||
| // Optionally remove top entry element from marshalled data to fullfill | ||
| // PAN-OS API requirements. |
There was a problem hiding this comment.
Suggested change
| // PAN-OS API requirements. | |
| // PAN-OS API requirements. | |
| // PAN-OS behaviour change: SET operations in the XML API no longer support partial XPath values. |
kklimonda-cl
force-pushed
the
feat-strip-entry-from-marshalled-data
branch
from
ec4fec9
to
ebcb1d9
Compare
Support for partial XPaths have been removed in PAN-OS 11.0.3-h3, and full XPaths are supported across all PAN-OS versions we're targetting.
kklimonda-cl
force-pushed
the
feat-strip-entry-from-marshalled-data
branch
from
ebcb1d9
to
c15b89c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When sending config "set" operations to PAN-OS, remove wrapping
<entry></entry>elements and use full XPath for the entry instead.
Motivation and Context
Support for partial XPaths has been removed in PAN-OS 11.0.3-h3, and
full XPaths are supported across all PAN-OS versions we're targetting.