Implementation of a TS Agent class for UserID #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
shinmog
reviewed
Apr 25, 2022
shinmog
requested changes
May 11, 2022
I have updated both CHILDTYPES, hopefully the acctests should now pass. |
A-Thomas-91
commented
May 23, 2022
|
Some acctests are failing. You can do |
|
Changes completed under following pull : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have implemented the ability to add TS Agent objects directly to the firewall.
https://docs.paloaltonetworks.com/compatibility-matrix/terminal-services-ts-agent
Motivation and Context
The company I work for uses Azure Virtual Desktop, we have different host pools in different regions and corresponding PA-VMs in the regions. Due to the dynamic nature of host creation, this has allowed us to add 30 hosts' (which have the TS agent installed) corresponding IP addresses and port numbers in a matter of seconds to our firewalls.
How Has This Been Tested?
We don't have a testing environment but at the time we had a spare physical PA device which the implementation was tested on, after running the tests, the TS agent objects were successfully added to the firewall. This was then tested in production and we began to instantly see users mapped to traffic on the newly added AVD hosts.
Types of changes
Checklist
Forgive me for not ticking the test tick boxes as this is my first ever pull request, I would love to work on other aspects of this project and implement different classes under guidance of understanding the API in full. Whilst I was able to read the code to implement this class I do not fully understand how I would implement decryption exlusion/decryption profile classes which I do have a need for.