Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new log settings #482

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

BatD2
Copy link

@BatD2 BatD2 commented Nov 3, 2022

Description

Created the following new classes for the missing log setting formats:

  • class LogSettingsGlobalProtect
  • class LogSettingsUserId
  • class LogSettingsIpTag
  • class LogSettingsHipMatch
  • class LogSettingsCorrelation

Added the the new class references as CHILDTYPES parameter to the following classes:

  • panos.device: class Vsys
  • panos.panorama: class TemplateStack and class Template
  • panos.firewall: class Firewall

Motivation and Context

We need to update log settings across multiple firewalls/Panorama Device groups, however as of now only System and Configuration log settings are supported in the SDIK. The following log settings types are missing:

  • Global Protect (PanOS 9.1)
  • User ID
  • IP Tag (PanOS 9.0)
  • HIP Match
  • Correlation

How Has This Been Tested?

Tested the new classes for Log Setting retrieval and configuration against Panorama.

Screenshots (if appropriate)

NA

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Dosyo.Koychev added 3 commits October 28, 2022 09:09
Created the following classes and updated the relevant CHILDTYPE references:

    class LogSettingsGlobalProtect
    class LogSettingsUserId
    class LogSettingsIpTag
    class LogSettingsHipMatch
    class LogSettingsCorrelation
Created the following classes and updated the relevant CHILDTYPE references:

    class LogSettingsGlobalProtect
    class LogSettingsUserId
    class LogSettingsIpTag
    class LogSettingsHipMatch
    class LogSettingsCorrelation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant