-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astro #112
Draft
kashike
wants to merge
56
commits into
main
Choose a base branch
from
feat/astro
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Astro #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powercasgamer
suggested changes
Aug 8, 2024
From Astro core team member on images: We might be able to abuse https://docs.astro.build/en/guides/images/#inferremotesize to check if an image exists (returns a 404) and set to a fallback image to prevent the CI / build from failing due to missing remote image (from OC / GH) Edit: This has been completed |
allows us to set a fallback to ensure builds don't fail
- Added back in astro check command to build - Fixed invalid height string on footer - Use icon instead of image on software preview component - Fix invalid html property on contribute page - Added in main download landing page - Update icon use on main and team page
TODO: Check to see if migrating from raw image to icon broke anything
fix: team social icon colors and more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀