Fixed Off hand detection regarding Necromantic Aegis #8331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed independent IF statements in CalcPerform into single if-elseif statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8288 .
Description of the problem being solved:
With KEYSTONE: Necromantic Aegis noded and equipment / effects that check for empty offhand, Shields in the offhand slot [Weapon 2] will always be considered empty handed during calculations.
Steps taken to verify a working solution:
-Load build that both allocates Necromantic Aegis, and has any shield with mods that affect player with any source that checks for an empty offhand; White Wind, Imperial Skean used in this case.
-Check Calculations for presence of White Wind Inc when shield is equiped and unequiped on any non-complex cold damage skill.
-Check Calculations for presence of White Wind Inc when shield is equiped and unequiped with no skill group active to see Minion Hit average changes.
NOTE: Freezing Pulse is set to level 1 and 0 quality for testing. Default settings applied on config section.
Link to a build that showcases this PR:
https://pobb.in/KtsIqbfE2Pxx
Before screenshot:
Freezing Pulse Before
MH Hit Damage Before
After screenshot:
Freezing Pulse After
MH Hit Damage After