refactor numeric code and handle typmod better #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Sep 22, 2024
| // This is to reverse what make_numeric_typmod of Postgres does: | ||
| // logic copied from: https://github.com/postgres/postgres/blob/c4d5cb71d229095a39fda1121a75ee40e6069a2a/src/backend/utils/adt/numeric.c#L929 | ||
| // Maps most "invalid" typmods to be unconstrained (same as -1) | ||
| func NewParsedNumericTypmod(typmod int32) *NumericTypmod { |
There was a problem hiding this comment.
Suggested change
| func NewParsedNumericTypmod(typmod int32) *NumericTypmod { | |
| func NewParsedNumericTypmod(typmod int32) NumericTypmod { |
Seems like a type best passed by value & treated as immutable. Can even fit a Valid bool without impacting struct size, but seems that's what constrained might be
There was a problem hiding this comment.
not a big fan of passing by value since we need to store this in QField which currently has no way to communicate something is only needed for numerics
basically an implicit vs explicit thing
There was a problem hiding this comment.
That'd be handled by a Valid bool
serprex
reviewed
Sep 22, 2024
| precision := int16((offsetMod >> 16) & 0x7FFF) | ||
| scale := int16(offsetMod & 0x7FFF) | ||
| return precision, scale | ||
| func (t *NumericTypmod) PrecisionAndScale() (int16, int16) { |
There was a problem hiding this comment.
Can make Precision/Scale public & remove this. No need for nil checks if you usually work with these by value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
started with numeric refactor, but discovered typmod is being handled improperly in some places
bumped BQ to BIGNUMERIC limits
added tests for typmod parsing