Merge pull request #300 from PermanentOrg/feature/VSP-1429

Fixed QA comment regarding bolded text on Goals Page and Priorities P…
PermanentOrg · Sep 2, 2024 · 3229532 · 3229532
2 parents 0fa5dd5 + dff4b9d
commit 3229532
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 5 deletions.
diff --git a/app/src/main/java/org/permanent/permanent/ui/archiveOnboarding/compose/GoalsPage.kt b/app/src/main/java/org/permanent/permanent/ui/archiveOnboarding/compose/GoalsPage.kt
@@ -120,8 +120,19 @@ private fun PhoneBody(
                 fontFamily = regularFont
             )
 
+            val descriptionText = stringResource(id = R.string.chart_your_path_description)
+            val boldedText = "My goal is to…"
+            val startIndex = descriptionText.indexOf(boldedText)
+            val styles = listOf(
+                AnnotatedString.Range(
+                    SpanStyle(fontWeight = FontWeight.Bold),
+                    start = startIndex,
+                    end = startIndex + boldedText.length
+                )
+            )
+
             Text(
-                text = stringResource(id = R.string.chart_your_path_description),
+                text = AnnotatedString(text = descriptionText, spanStyles = styles),
                 fontSize = 14.sp,
                 lineHeight = 24.sp,
                 color = Color.White,
@@ -249,8 +260,18 @@ private fun TabletBody(
             Column(
                 modifier = Modifier.weight(1f)
             ) {
+                val descriptionText = stringResource(id = R.string.chart_your_path_description)
+                val boldedText = "My goal is to…"
+                val startIndex = descriptionText.indexOf(boldedText)
+                val styles = listOf(
+                    AnnotatedString.Range(
+                        SpanStyle(fontWeight = FontWeight.Bold),
+                        start = startIndex,
+                        end = startIndex + boldedText.length
+                    )
+                )
                 Text(
-                    text = stringResource(id = R.string.chart_your_path_description),
+                    text = AnnotatedString(text = descriptionText, spanStyles = styles),
                     fontSize = 16.sp,
                     lineHeight = 24.sp,
                     color = Color.White,

diff --git a/app/src/main/java/org/permanent/permanent/ui/archiveOnboarding/compose/PrioritiesPage.kt b/app/src/main/java/org/permanent/permanent/ui/archiveOnboarding/compose/PrioritiesPage.kt
@@ -138,8 +138,19 @@ private fun PhoneBody(
                 fontFamily = regularFont
             )
 
+            val descriptionText = stringResource(id = R.string.tell_us_description)
+            val boldedText = "What brought you to Permanent.org"
+            val startIndex = descriptionText.indexOf(boldedText)
+            val styles = listOf(
+                AnnotatedString.Range(
+                    SpanStyle(fontWeight = FontWeight.Bold),
+                    start = startIndex,
+                    end = startIndex + boldedText.length
+                )
+            )
+
             Text(
-                text = stringResource(id = R.string.tell_us_description),
+                text = AnnotatedString(text = descriptionText, spanStyles = styles),
                 fontSize = 14.sp,
                 lineHeight = 24.sp,
                 color = Color.White,
@@ -263,8 +274,19 @@ private fun TabletBody(
             Column(
                 modifier = Modifier.weight(1f)
             ) {
+                val descriptionText = stringResource(id = R.string.tell_us_description)
+                val boldedText = "What brought you to Permanent.org"
+                val startIndex = descriptionText.indexOf(boldedText)
+                val styles = listOf(
+                    AnnotatedString.Range(
+                        SpanStyle(fontWeight = FontWeight.Bold),
+                        start = startIndex,
+                        end = startIndex + boldedText.length
+                    )
+                )
+
                 Text(
-                    text = stringResource(id = R.string.tell_us_description),
+                    text = AnnotatedString(text = descriptionText, spanStyles = styles),
                     fontSize = 16.sp,
                     lineHeight = 24.sp,
                     color = Color.White,

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -554,7 +554,7 @@
     <string name="chart_your_path_title">Chart your\npath to success</string>
     <string name="chart_your_path_description">Let’s set some goals. Everyone has unique goals for preserving their legacy. We want to learn more about how we can help you achieve yours.\n\nMy goal is to…</string>
     <string name="tell_us_title">Tell us what’s\nimportant to you</string>
-    <string name="tell_us_description">Finally, we’re curious — what brought you to Permanent.org?</string>
+    <string name="tell_us_description">Finally, we’re curious…\nWhat brought you to Permanent.org?</string>
     <string name="congratulations_title">Congratulations!</string>
     <string name="congratulations_description_first">Get started by uploading your first files, or learn more about your new archive by</string>
     <string name="congratulations_description_second">viewing our help articles here.</string>