Implement file upload #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slifty
force-pushed
the
48-implement-file-upload
branch
2 times, most recently
from
cb4367a to
e0a96bc
Compare
slifty
force-pushed
the
48-implement-file-upload
branch
3 times, most recently
from
306a1e0 to
aa815a7
Compare
There were a few small typos / minor issues with debug output that have no impact on functionality but are still worth correcting.
slifty
force-pushed
the
48-implement-file-upload
branch
2 times, most recently
from
5b93a15 to
fc506c5
Compare
nfebe
reviewed
Feb 22, 2023
slifty
force-pushed
the
48-implement-file-upload
branch
from
fc506c5 to
b5f1c16
Compare
nfebe
reviewed
Feb 22, 2023
This allows an sftp client to upload data to the Permanent virtual filesystem. Unfortunately the way sftp works there is no way of knowing how large a file is going to be until after the handle is closed, and unfortunately permanent requires us to know how large the file is before it will allow us to generate a presigned post. This means our solution is to write the file into temporary storage. This is a potential vulnerability and should be seen as a short term solution. Other limitations of this implementation include: 1. Lack of support for editing files 2. Lack of support for updating modtime All of these will need to be improved in future developments. Issue #48 Implement file open / write handlers
slifty
force-pushed
the
48-implement-file-upload
branch
from
b5f1c16 to
7d5f4cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality for writing files to Permanent.
It has a few known limitations (which have been captured in issues already):
mod time(see Supporting mod time #80)Resolves #48
Resolves #24