PER-9866 [back-end] Endpoint for admins to update environment configu… #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianvsp
force-pushed
the
PER-9866
branch
2 times, most recently
from
d11149e
to
285d3f2
Compare
liam-lloyd
reviewed
Oct 25, 2024
| const validation = Joi.object() | ||
| .keys({ | ||
| ...fieldsFromAdminAuthentication, | ||
| description: Joi.string(), |
There was a problem hiding this comment.
description should be required here too, per the specification
There was a problem hiding this comment.
Ok, it seemed a bit odd not to be required on creation but required on update. I thought it's a documentation mistake.
…ration New endpoint to update a feature-flag. There are validations on the globallyEnabled and description fields Unit and functional tests are covering all scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ration
New endpoint to update a feature-flag. There are validations on the globallyEnabled and description fields
Unit and functional tests are covering all scenarios