PER-9883 [back-end] Delete feature flag endpoint #140
+178
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam-lloyd
reviewed
Oct 25, 2024
| WHERE | ||
| id = :featureFlagId | ||
| RETURNING | ||
| id AS "featureFlagId"; |
There was a problem hiding this comment.
The linter is complaining about the whitespace at the end of this file.
| @@ -17,3 +17,16 @@ export function validateCreateFeatureFlagRequest( | |||
| throw validation.error; | |||
| } | |||
| } | |||
|
|
|||
| export function validateDeleteFeatureFlagParams( | |||
There was a problem hiding this comment.
This is essentially the same as the param validator for update; perhaps they should be one function?
New endpoint to delete a feature-flag Unit and functional tests are covering all scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New endpoint to delete a feature-flag
Unit and functional tests are covering all scenarios