Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump axios and @types/mailchimp__mailchimp_transactional #80

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 11, 2024

Bumps axios to 1.6.8 and updates ancestor dependency @types/mailchimp__mailchimp_transactional. These dependencies need to be updated together.

Updates axios from 0.21.4 to 1.6.8

Release notes

Sourced from axios's releases.

Release v1.6.8

Release notes:

Bug Fixes

  • AxiosHeaders: fix AxiosHeaders conversion to an object during config merging (#6243) (2656612)
  • import: use named export for EventEmitter; (7320430)
  • vulnerability: update follow-redirects to 1.15.6 (#6300) (8786e0f)

Contributors to this release

Release v1.6.7

Release notes:

Bug Fixes

  • capture async stack only for rejections with native error objects; (#6203) (1a08f90)

Contributors to this release

Release v1.6.6

Release notes:

Bug Fixes

  • fixed missed dispatchBeforeRedirect argument (#5778) (a1938ff)
  • wrap errors to improve async stack trace (#5987) (123f354)

Contributors to this release

Release v1.6.5

Release notes:

Bug Fixes

  • ci: refactor notify action as a job of publish action; (#6176) (0736f95)
  • dns: fixed lookup error handling; (#6175) (f4f2b03)

Contributors to this release

... (truncated)

Changelog

Sourced from axios's changelog.

1.6.8 (2024-03-15)

Bug Fixes

  • AxiosHeaders: fix AxiosHeaders conversion to an object during config merging (#6243) (2656612)
  • import: use named export for EventEmitter; (7320430)
  • vulnerability: update follow-redirects to 1.15.6 (#6300) (8786e0f)

Contributors to this release

1.6.7 (2024-01-25)

Bug Fixes

  • capture async stack only for rejections with native error objects; (#6203) (1a08f90)

Contributors to this release

1.6.6 (2024-01-24)

Bug Fixes

  • fixed missed dispatchBeforeRedirect argument (#5778) (a1938ff)
  • wrap errors to improve async stack trace (#5987) (123f354)

Contributors to this release

1.6.5 (2024-01-05)

Bug Fixes

  • ci: refactor notify action as a job of publish action; (#6176) (0736f95)

... (truncated)

Commits
  • ab3f0f9 chore(release): v1.6.8 (#6303)
  • 2656612 fix(AxiosHeaders): fix AxiosHeaders conversion to an object during config mer...
  • 7320430 fix(import): use named export for EventEmitter;
  • 8786e0f fix(vulnerability): update follow-redirects to 1.15.6 (#6300)
  • d844227 chore: update and bump deps (#6238)
  • caa0625 docs: update README responseEncoding types (#6194)
  • 41c4584 docs: Update README.md to point to current axios version in CDN links (#6196)
  • bf6974f chore(ci): add npm tag action; (#6231)
  • a52e4d9 chore(release): v1.6.7 (#6204)
  • 2b69888 chore: remove unnecessary check (#6186)
  • Additional commits viewable in compare view

Updates @types/mailchimp__mailchimp_transactional from 1.0.5 to 1.0.10

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [axios](https://github.com/axios/axios) to 1.6.8 and updates ancestor dependency [@types/mailchimp__mailchimp_transactional](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mailchimp__mailchimp_transactional). These dependencies need to be updated together.


Updates `axios` from 0.21.4 to 1.6.8
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v0.21.4...v1.6.8)

Updates `@types/mailchimp__mailchimp_transactional` from 1.0.5 to 1.0.10
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mailchimp__mailchimp_transactional)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
- dependency-name: "@types/mailchimp__mailchimp_transactional"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 11, 2024
@liam-lloyd
Copy link
Member

This appears to be tangled up in some Javascript/Typescript module issues. axios 1.6.8 is an ES module; @mailchimp/mailchimp_transactional is a CommonJS module. As a result, Jest objects to its importing axios, though Typescript manages to produce working code from the situation. All the possible solutions look involved to me. They are

  • Stop using Jest, in favor of Node's build-in test runner or Vitest. Jest's support of ES modules is still considered experimental, which puts it rather behind the times. If Node's test runner can work for us it would also be nice to be able to remove a dependency.
  • Start running the tests using ESM instead of CommonJS (Jest's default). This will require some updates to make our mocks keep working. We also might want to update the generated code of the module to use ESM, because currently we're in the confusing situation where we use ESM syntax in our Typescript but generate CommonJS Javascript.

I will make a pothole ticket to figure this out.

@liam-lloyd
Copy link
Member

Worth noting that writing our own Mailchimp Transactional client could also solve the problem here.

@liam-lloyd
Copy link
Member

Ticket to fix the ESM/Jest issue https://permanent.atlassian.net/browse/PER-9579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant