Add FeatureFlagModule and FeatureFlagService #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisekimiu
force-pushed
the
feature-flag-service
branch
from
cc6209a
to
edf671f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
+ Coverage 42.50% 42.60% +0.09%
==========================================
Files 354 357 +3
Lines 10956 10971 +15
Branches 1789 1790 +1
==========================================
+ Hits 4657 4674 +17
- Misses 6139 6140 +1
+ Partials 160 157 -3 ☔ View full report in Codecov by Sentry. |
liam-lloyd
approved these changes
Oct 25, 2024
meisekimiu
force-pushed
the
feature-flag-service
branch
from
edf671f
to
d65e4e9
Compare
crisnicandrei
approved these changes
Oct 25, 2024
Add a service designed to query feature flags that are fetched from the API. This behavior is implemented in two classes: one for storing and querying the currently set flags and one for initially fetching them from the API. It is designed like this so that we can test these functionalities on their own and so that the FeatureFlagService can be used in unit tests without any mocking. Any components that query FeatureFlags can just use the service directly and use the `set` method to manipulate feature flags directly in the test. PER-9735: Create service to fetch client config
meisekimiu
force-pushed
the
feature-flag-service
branch
from
d65e4e9
to
61a7d1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a service designed to query feature flags that are fetched from the API. This behavior is implemented in two classes: one for storing and querying the currently set flags and one for initially fetching them from the API.
It is designed like this so that we can test these functionalities on their own and so that the FeatureFlagService can be used in unit tests without any mocking. Any components that query FeatureFlags can just use the service directly and use the
setmethod to manipulate feature flags directly in the test.Since this is adding a service that is not currently used by any components, there is no way to manually test this in production, however the whole service is covered by unit tests. This PR will not go through a QA review; please check and run the unit tests to verify correct behavior.