SceneViewport - Add proper class disposal

PhoenixARC · Mar 13, 2024 · 0a01a4c · 0a01a4c
1 parent 29a9e4e
commit 0a01a4c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/PCK-Studio/Forms/Editor/CustomSkinEditor.cs b/PCK-Studio/Forms/Editor/CustomSkinEditor.cs
@@ -226,6 +226,7 @@ private void deleteToolStripMenuItem_Click(object sender, EventArgs e)
 
         private void CustomSkinEditor_FormClosing(object sender, FormClosingEventArgs e)
         {
+            renderer3D1.Dispose();
         }
 
         private void outlineColorButton_Click(object sender, EventArgs e)

diff --git a/PCK-Studio/Rendering/SceneViewport.cs b/PCK-Studio/Rendering/SceneViewport.cs
@@ -58,10 +58,9 @@ public int RefreshRate
         private int refreshRate = 60;
         private Timer timer;
 
+        private ShaderProgram colorShader;
         private VertexArray VAO;
-        private VertexBuffer VBO;
         private IndexBuffer IBO;
-        private ShaderProgram colorShader;
         private bool isInitialized;
 
         protected void Init()
@@ -71,9 +70,9 @@ protected void Init()
                 Debug.Fail("Already Initializted.");
                 return;
             }
+            MakeCurrent();
             colorShader = ShaderProgram.Create(Resources.plainColorVertexShader, Resources.plainColorFragmentShader);
             VAO = new VertexArray();
-            VBO = new VertexBuffer();
             IBO = IndexBuffer.Create(
                     0, 1,
                     1, 2,
@@ -92,7 +91,7 @@ protected void Init()
             VertexBufferLayout layout = new VertexBufferLayout();
             layout.Add(ShaderDataType.Float3);
             layout.Add(ShaderDataType.Float4);
-            VAO.AddBuffer(VBO, layout);
+            VAO.AddNewBuffer(layout);
             isInitialized = true;
         }
 
@@ -108,6 +107,20 @@ public SceneViewport() : base()
             isInitialized = false;
         }
 
+        protected override void Dispose(bool disposing)
+        {
+            if (disposing)
+            {
+                timer.Stop();
+                timer.Dispose();
+            }
+            MakeCurrent();
+            VAO.Dispose();
+            IBO.Dispose();
+            colorShader.Dispose();
+            base.Dispose(disposing);
+        }
+
 
         protected void DrawBoundingBox(Matrix4 transform, BoundingBox boundingBox, Color color)
         {
@@ -139,7 +152,7 @@ protected void DrawBoundingBox(Matrix4 transform, BoundingBox boundingBox, Color
             ];
 
             VAO.Bind();
-            VBO.SetData(vertices);
+            VAO.GetBuffer(0).SetData(vertices);
             IBO.Bind();
             GL.DrawElements(PrimitiveType.Lines, IBO.GetCount(), DrawElementsType.UnsignedInt, 0);
             GL.DepthFunc(DepthFunction.Less);