This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Update getting-target-data.rst #287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation is behind recent change.
mcm001
reviewed
Sep 22, 2023
| @@ -108,8 +108,7 @@ Getting Data From A Target | |||
| * double ``getArea()``/``GetArea()``: The area (how much of the camera feed the bounding box takes up) as a percent (0-100). | |||
| * double ``getSkew()``/``GetSkew()``: The skew of the target in degrees (counter-clockwise positive). | |||
| * double[] ``getCorners()``/``GetCorners()``: The 4 corners of the minimum bounding box rectangle. | |||
| * Transform2d ``getCameraToTarget()``/``GetCameraToTarget()``: The camera to target transform. See `2d transform documentation here <https://docs.wpilib.org/en/latest/docs/software/advanced-controls/geometry/transformations.html#transform2d-and-twist2d>`_. | |||
|
|
|||
| * Transform3d ``getBestCameraToTarget()``/``GetBestCameraToTarget()``: The camera to target transform. | |||
There was a problem hiding this comment.
Are there any good docs pages we can link here?
There was a problem hiding this comment.
I looked and it does not seem so.
There was a problem hiding this comment.
While we're waiting for wpilib to add transform3d docs, let's expand on this a little bit more? Maybe "The 3d transform between your camera's origin and the target's origin. It's the same as transform3d, but generalized to 3d."?
Or poke around and find some ROS docs that explain 3d geometry? IDK.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation is behind recent changes.