Test setting new invalid value

PhpGt · Jan 16, 2018 · 88f7fb7 · 88f7fb7
1 parent 1fa49d3
commit 88f7fb7
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/Validity.php b/src/Validity.php
@@ -43,6 +43,10 @@ public static function isValidName(string $name):bool {
 	public static function isValidValue(string $value):bool {
 		$valid = true;
 
+		if($value === "") {
+			return $valid;
+		}
+
 		$nameChars = str_split($value, 1);
 		$validChars = self::getValidNameCharacters();
 		foreach($nameChars as $c) {

diff --git a/test/unit/CookieTest.php b/test/unit/CookieTest.php
@@ -33,6 +33,27 @@ public function testConstructInvalidName(string $name, string $value) {
 		new Cookie($name);
 	}
 
+	/**
+	 * @dataProvider dataNameValue
+	 */
+	public function testConstructInvalidValue(string $name, string $value) {
+		$value = $this->injectInvalidCharacters($value);
+
+		self::expectException(InvalidCharactersException::class);
+		new Cookie($name, $value);
+	}
+
+	/**
+	 * @dataProvider dataNameValue
+	 */
+	public function testSetInvalidValue(string $name, string $value) {
+		$value = $this->injectInvalidCharacters($value);
+
+		$cookie = new Cookie($name);
+		self::expectException(InvalidCharactersException::class);
+		$cookie->withValue($value);
+	}
+
 	public static function dataNameValue():array {
 		$data = [];