Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] develop from decidim:develop #165

Merged
merged 55 commits into from
Aug 25, 2023
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 1, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Crashillo and others added 2 commits August 1, 2023 11:39
* hack to counteract the hover effects of the dropdown

* keep menu unreachable onload

* due to a bug in Chrome, move the inline events to script tags

more info: https://bugs.chromium.org/p/chromium/issues/detail?id=868224&q=ontransitionend&colspe[%E2%80%A6]Block%20Component%20Status%20Owner%20Summary%20OS%20Modified

* fix spelling

* extract script to separate file

* restore removed element

* fix spelling

* trigger manually dropdown controller on hover parent

* move onmouseenter only to link

* handle dropdowns only via css animation

* no longer required

* fix styles

* disable animations on page load

* fix tests

* fix syntax
@pull pull bot added the ⤵️ pull label Aug 1, 2023
RCheesley and others added 27 commits August 1, 2023 22:04
* Remove skip_unless_redesing_enabled calls in tests

* Remove redesign_helpers for tests

* Unskip and adapt REDESIGN_PENDING examples

* Remove deprecated examples

* Allow to configure the default header level of attributes titles in diff cell

* Ensure accessibility of h in collaborative draft show

* Recover accessibility tests in proposals

* Remove comments

* Unskip and adapt test

* Fix expected text of link in test

* Remove check for removed follow actions in participatory text index

* Unskip tests

* Unskip and adapt to vote proposal tests

* Remove deprecated methods

* Remove deprecations in tests

* Remove collaborative drafts and proposals deprecated m cells

* Adapt proposal m cell cache hash to l cell

* Adapt proposal m-cell specs to l-cell

* Replace use of proposal_m card

* Remove condition on redesign from test

* Rename shared examples for attachments to not use redesign term

* Remove tests for CTA behavior deprecated in processes card-g

* Avoid duplicated ids of highlighted participatory process in menu breadcrumb

* Recover skipped examples

* Recover accessibility tests in participatory processes

* Remove participatory process description specs and include expected contents with metadata content block enabled

* Unskip REDESIGN_PENDING tests

* Move common statistics cells tests to shared examples

* Remove unused process metadata item

* Remove deprecated proceses m card and add tests for l and g cards

* Remove deprecated process group m card cell

* Recover tests after redesign in initiatives

* Remove skipped deprecated tests

* Remove assemblies description page test and move examples to show page with appropriate content blocks

* Remove assembly m card and related tests

* Unskip tests after completing redesing

* Adapt sorting test to redesigned interface

* Remove deprecated sorting tests because the redesigned interface prevents incomplete sortings

* Unskip tests

* Remove post m card cell

* Remove reference to redesign from test

* Remove comment m card

* Unskip accessibility test in debates versions

* Remove deprecated test

* Remove deprecated comments about redesign

* Remove deprecated test

The proposals card-l does not show the supports count in the metadata,
so there is no difference when supports are enabled on proposals
component or not

* Remove useless reference to redesign in test

* Remove REDESIGN_PENDING comment: do not use card-l cell for media links

* Remove REDESIGN_PENDING comments

* Remove unused partial

* Unskip tests

* Remove conference m card cell

* Adapt authorizations tests to redesign

* Remove deprecated tests

* Avoid errors in upload modal when file validation fails

* Unskip tests

* Remove deprecated test

* Remove REDESIGN_PENDING comments

* Update map styles in proposals

* Uncomment tests

* Uncomment and adapt selector in tests

* Remove reference to redesign

* Fix linter offense

* Remove obsolete brakeman skip and update other in proposals

* Remove unused translations and add some wizards keys to ignore unused

* Update expected url in activity cell with comments activities

* Increase header levels in version cell to include h1

* Recover missing data attribute in hero content block

* Fix coordinates update in add_proposal js

* Hide map only if there is no address with coordinates

* Empty address field before changing it in test

* Add issue reference to skipped tests

* Display replies on deleted comments and keep then with AJAX deletion refresh

* Unskip test

* Update decidim-core/app/cells/decidim/version/show.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Use h2 tag

* Move shared examples require to core

* Replace actions with method doing the same

* Fix test

* Remove references to redesign in shared examples

---------

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
* set the scope of all functions that are initialized at startup

* scope the datepicker as well

* remove precated js stuff (testing)

* fix lint & place accordingly the initializations
* deprecate foundation-datepicker public site

* fix core tests

* fix datepicker tests

* fix lint and rubocop

* replace now with current

* fix tests

* fix more tests

* fix tests

* remove byebugs
* Column conversations fix

* suggested changes added to &__aside

* &__main updated

* Changes made to span on &__main

* test

* spacing cli test
* Added a disabler for pointer event

* Improved workaround for the tabs +1

* Indentation line 19
* Force capital starting letter for PR titles

* Force the starting character to be capitalized
* Allow disabling password expiration

NIST does not recommend expiring passwords:
https://pages.nist.gov/800-63-FAQ/#q-b05

* Add documentation about the new option

* Fix linter

* Fix linter
* Fix autocomplete user group duplication / Add system test

* Fix test
* refactor the organization colors

* typo

* remove specs about them_color input

* fix specs

* use old red for testing

* set the default redesign colors to the organization factory (color-contrast)

* replace the uses of legacy primary color
* dropdown card does not require an id

* add aria-label to progress bar

* disable dropdown for desktop navigation

* Refactor the use of filter_text_for to be in views instead of helpers

* Allow passing an id to filter_text_for method

* remove element_id (testing)

* pass the id to the label

* distinguish filters and order controls

* distinguish all uses of dropdown-menus

* rename control

* don't use a list when you need divs

* disable dropdown for desktop navigation

* update code for emoji

* remove ids from tests

* fix core tests

* fix election tests

* fix tests

* remove profile__user-role class

* remove needless aria-attribute

* remove duplicated ids

* empty merge

* Include alternative title for images when there's nothing but the title

* disable dropdown for desktop

* add alt text to default image

* user profile must not be an h5

* duplicate_id and copy button SR text

* fix odd layout for edit initiative

* redesign committee requests form

* fix a11y issue on budgets project list

* mark layout item header al role=complementary since it's outside

* do not expand elements if the page has very few contents

* fix a11y issue on debates, sortitions and forms

* fix rubocop

* fix erblint

* use the units as the aria-label

* standarize arias for progress bars

* initiatives style glitch

---------

Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
* Initial commit on bullet integration

* remove uneeded condition

* Disable failing actions

* Disable failing workflows

* Disable all the workflows

* Refactor actions

* Revert generator change
* render the comment button depending of the settings

* enhance condition: initiatives is not a component

* handle comments_blocked? in case of null

* fix offenses
* remove the item itself from nav menu

* fix i18n

* fix specs

* fix specs
* make every resource metadata equal

* remove any reference to "drawer"

* typo

* slightly different initiative layout
Crashillo and others added 26 commits August 14, 2023 14:10
* display alert when no projects

* normalize locals
* prepare assets and login page

* responsive sidebar system

* organization forms

* refactor organization forms

* password forms

* admins forms

* oauth forms

* fix typo

* fix specs and required update modal

* fix lint

* fix lint

* update test settings

* avoid aside to expand

* remove deprecated styles
* spacing for participatory_processes, proposals, collaborative drafts, participatory texts and component announcement

* spacing for sortitions, elections, meetings and fixes over proposals

* spacing for assemblies and fixes over participatory spaces

* fix tests

* spacing for core

* spacing for conferences, blogs and accountability. Fixes over conversations

* aside heading responsive and spacig for budgets

* spacing for projects, debates and initiatives

* fix initiative specs

* fix proposals specs

* fix specs

* missing space for collaborative drafts

* avoid overwritting css rule du to tailwind directive

* missing class

* avoid weird space around the span

* missing condition
* Encode non-ASCII characters on external links

* Lint

* Apply suggestions
* Fix weird behavior with votes in comments

* Fix flaky test
* Fix SEO routing issue for components index

* Add tests for the redirects

* Fix failing tests

* Fix failing specs

* Fix all failing tests

* Fix linting error
* simplify the finish create-initiative step

* restore original condition
* Fix wrong 'no activity' text on last activities page

* Fix failing spec
* replace qr code icon with another related

* change icon
* hightlight links on hover

* highlight footer links

* distinguisable link banner

* place "skip to content" the first thing of all
* include datetime semantically

* calendar a11y

* ignore missing translation
…istered (#11511)

* Show different text for the Register CTA when the user is already registered

* Change two more buttons

* Normalize i18n
)

* Don't show initiative state field instead of showing it disabled

* Don't show the field in the edit form neither

* Add tests

* Lint files

* Update decidim-initiatives/app/views/decidim/initiatives/initiatives/_form.html.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

---------

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
@fblupi fblupi merged commit ac18bd1 into Platoniq:develop Aug 25, 2023
87 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants