Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest valetudo-mapper #442

Merged
merged 6 commits into from
Jan 13, 2024
Merged

Update to latest valetudo-mapper #442

merged 6 commits into from
Jan 13, 2024

Conversation

gerard33
Copy link
Contributor

@gerard33 gerard33 commented Oct 14, 2023

Update to latest valetudo-mapper which contains some fixes for the new Home Assistant MQTT format.
It should fix the following warning which gets deprecated in 2024.2 release.

MQTT entity name starts with the device name in your config {'name': 'rockrobo_map', 'unique_id': 'rockrobo_map', 'device': {'manufacturer': 'Roborock', 'name': 'rockrobo', 'identifiers': ['rockrobo'], 'connections': []}, 'topic': 'valetudo/rockrobo/map', 'availability_mode': 'latest', 'payload_not_available': 'offline', 'encoding': 'utf-8', 'qos': 0, 'enabled_by_default': True, 'payload_available': 'online'}, this is not expected. Please correct your configuration. The device name prefix will be stripped off the entity name and becomes '_map'

Poeschl and others added 4 commits October 13, 2023 14:32
Update to latest valetudo-mapper which contains some fixes for the new Home Assistant MQTT format
@gerard33 gerard33 changed the title Update Dockerfile Update to latest valetudo-mapper Oct 14, 2023
@Poeschl Poeschl changed the base branch from main to dev October 14, 2023 16:45
Copy link
Owner

@Poeschl Poeschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will dynamically always use the master branch instead of a fixed version.
This need to be changed to the latest commit hash, if no tag can be used.

@gerard33
Copy link
Contributor Author

Changed it to the latest commit. Do you expect any issues when using the latest version on master?

@gerard33 gerard33 requested a review from Poeschl October 14, 2023 18:16
@Poeschl
Copy link
Owner

Poeschl commented Oct 14, 2023

When using master, the container content is not fixed. So the same build can produce different outputs on two different dates.
Therefore I pin all versions.

@gerard33
Copy link
Contributor Author

gerard33 commented Jan 7, 2024

@Poeschl can you have a look at this PR? The current format gets deprecated in the next Home Assistant release.

Copy link
Owner

@Poeschl Poeschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder, the changes looks good now.

I will make some time this week to go over the PRs.

@Poeschl Poeschl merged commit 8184d63 into Poeschl:dev Jan 13, 2024
@gerard33 gerard33 deleted the patch-1 branch January 13, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants