Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose engine shutdown to adapter manager and push/pushpull adapters #312

Merged
merged 13 commits into from
Jul 25, 2024
Merged

expose engine shutdown to adapter manager and push/pushpull adapters #312

merged 13 commits into from
Jul 25, 2024

Conversation

argaj
Copy link
Collaborator

@argaj argaj commented Jul 3, 2024

Closes #245

@argaj argaj added the type: enhancement Issues and PRs related to improvements to existing features label Jul 3, 2024
AdamGlustein
AdamGlustein requested changes Jul 3, 2024
View reviewed changes
cpp/csp/python/Exception.h Outdated Show resolved Hide resolved
cpp/csp/python/Exception.h Outdated Show resolved Hide resolved
cpp/csp/python/PyAdapterManager.cpp Outdated Show resolved Hide resolved
cpp/csp/python/Exception.h Outdated Show resolved Hide resolved
cpp/csp/python/PyPushInputAdapter.cpp Outdated Show resolved Hide resolved
csp/tests/impl/test_pushadapter.py Outdated Show resolved Hide resolved
csp/tests/impl/test_pushadapter.py Outdated Show resolved Hide resolved
csp/tests/impl/test_pushpulladapter.py Outdated Show resolved Hide resolved
csp/tests/impl/test_pushpulladapter.py Outdated Show resolved Hide resolved
csp/tests/test_engine.py Outdated Show resolved Hide resolved
@AdamGlustein AdamGlustein force-pushed the ag/expose-engine-shutdown branch 2 times, most recently from ec0d10f to 247f831 Compare July 8, 2024 20:09
@AdamGlustein @argaj
Expose engine shutdown method for Python push-type adapters
3f2d7b1 
Co-authored-by: Artur Gajowniczek <artur.gajowniczek@point72.com>
Signed-off-by: Adam Glustein <Adam.Glustein@Point72.com>
@AdamGlustein AdamGlustein self-requested a review July 8, 2024 20:18
@argaj argaj force-pushed the ag/expose-engine-shutdown branch from 3f2d7b1 to 35f289a Compare July 9, 2024 13:10
robambalu
robambalu requested changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@robambalu robambalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, we should update the wiki to explain this new functionality too

cpp/csp/python/PyPushInputAdapter.cpp Outdated Show resolved Hide resolved
cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved
csp/impl/adaptermanager.py Outdated Show resolved Hide resolved
@AdamGlustein @argaj @timkpaine
Expose engine shutdown method for Python push-type adapters
147133c 
Co-authored-by: Artur Gajowniczek <artur.gajowniczek@point72.com>
Signed-off-by: Adam Glustein <Adam.Glustein@Point72.com>
Signed-off-by: Gajowniczek, Artur <artur.gajowniczek@point72.com>
argaj and others added 2 commits July 11, 2024 09:12
@argaj
passing exception to engine shutdown wip
84cc40d 
Signed-off-by: Gajowniczek, Artur <artur.gajowniczek@point72.com>
@AdamGlustein
Merge branch 'ag/expose-engine-shutdown' of https://github.com/Point7…
d096a88 
…2/csp into ag/expose-engine-shutdown
@AdamGlustein
Copy link
Collaborator

One last thing, we should update the wiki to explain this new functionality too

@argaj can you make the changes to the wiki explaining this method and commit to this PR branch?

@AdamGlustein
Create PythonPassthrough exception of proper type in the shutdown_eng…
4ddc99f 
…ine method

Signed-off-by: Adam Glustein <Adam.Glustein@Point72.com>
@timkpaine timkpaine added the tag: needs squash PRs that need to be cleaned/squashed label Jul 11, 2024
robambalu
robambalu requested changes Jul 12, 2024
View reviewed changes
csp/tests/test_engine.py Show resolved Hide resolved
cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved
@argaj argaj force-pushed the ag/expose-engine-shutdown branch from 58c58b9 to 382321d Compare July 12, 2024 15:24
AdamGlustein
AdamGlustein requested changes Jul 12, 2024
View reviewed changes
docs/wiki/how-tos/Write-Realtime-Input-Adapters.md Show resolved Hide resolved
csp/tests/test_engine.py Outdated Show resolved Hide resolved
@argaj argaj force-pushed the ag/expose-engine-shutdown branch from 382321d to ddd1c3a Compare July 12, 2024 16:20
@argaj
Add a test for traceback and update wiki
34a1db1 
Signed-off-by: Gajowniczek, Artur <artur.gajowniczek@point72.com>
@argaj argaj force-pushed the ag/expose-engine-shutdown branch from ddd1c3a to 34a1db1 Compare July 12, 2024 16:26
AdamGlustein
AdamGlustein requested changes Jul 12, 2024
View reviewed changes
csp/tests/test_engine.py Outdated Show resolved Hide resolved
@argaj
assert function name in traceback, shutdown engine if not an exceptio…
6a7b202 
…n is passed

Signed-off-by: Gajowniczek, Artur <artur.gajowniczek@point72.com>
@argaj argaj force-pushed the ag/expose-engine-shutdown branch from 3da3626 to 6a7b202 Compare July 16, 2024 12:10
AdamGlustein
AdamGlustein requested changes Jul 17, 2024
View reviewed changes
cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved
@argaj
Added shutdown on wrong type to PyEngine_shutdown
b0be488 
Signed-off-by: Gajowniczek, Artur <artur.gajowniczek@point72.com>
robambalu
robambalu requested changes Jul 22, 2024
View reviewed changes
cpp/csp/python/PyAdapterManager.cpp Outdated Show resolved Hide resolved
cpp/csp/python/PyAdapterManager.cpp Outdated Show resolved Hide resolved
docs/wiki/how-tos/Write-Realtime-Input-Adapters.md Outdated Show resolved Hide resolved
@argaj
clearer error msg, move creating exception logic to separate function…
ad58a75 
…, doc fix

Signed-off-by: Gajowniczek, Artur <artur.gajowniczek@point72.com>
AdamGlustein
AdamGlustein requested changes Jul 23, 2024
View reviewed changes
cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved
cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved
cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved
cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved
@argaj
use PyObjectPtr, add space to error msg
9c89a39 
Signed-off-by: Gajowniczek, Artur <artur.gajowniczek@point72.com>
@argaj
Merge branch 'main' of https://github.com/Point72/csp into ag/expose-…
7388bff 
…engine-shutdown

Signed-off-by: Gajowniczek, Artur <artur.gajowniczek@point72.com>
robambalu
robambalu requested changes Jul 24, 2024
View reviewed changes
cpp/csp/python/PyAdapterManager.cpp Outdated Show resolved Hide resolved
cpp/csp/python/PyEngine.h Outdated Show resolved Hide resolved
@AdamGlustein
Copy link
Collaborator

AdamGlustein commented Jul 24, 2024 •
edited
Loading

When you merge make sure to select "Squash and Merge" and edit the commit message to something succinct, so that it doesn't include all the intermediate commits in the history.

Edit: didn't see Rob's comments just now, address those first.

AdamGlustein
AdamGlustein previously approved these changes Jul 24, 2024
View reviewed changes
@argaj
use METH_O in shutdown_engine
52ee0e1 
Signed-off-by: Gajowniczek, Artur <artur.gajowniczek@point72.com>
@argaj argaj force-pushed the ag/expose-engine-shutdown branch from 9de217f to 52ee0e1 Compare July 25, 2024 12:44
@argaj argaj merged commit dce7312 into main Jul 25, 2024
30 checks passed
@argaj argaj deleted the ag/expose-engine-shutdown branch July 25, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robambalu robambalu robambalu approved these changes

@AdamGlustein AdamGlustein AdamGlustein left review comments

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

Assignees
No one assigned
Labels
tag: needs squash PRs that need to be cleaned/squashed type: enhancement Issues and PRs related to improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose engine_shutdown method on PyPushInput and PyAdapterManager classes
4 participants
@argaj @AdamGlustein @robambalu @timkpaine