Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve non-GCC implementation of statistics functions Quantile/Rank #322

Closed
wants to merge 3 commits into from
Closed

Improve non-GCC implementation of statistics functions Quantile/Rank #322

wants to merge 3 commits into from

Conversation

mrchhaya
Copy link
Contributor

Implements #77

Passes all tests on
clang version 16.0.6
Target: arm64-apple-darwin23.0.0
Thread model: posix

Implemented using the boost ranked indicies which I believe should provide O(logn) find, delete, insert, rank operations.

@mrchhaya
quantile
3979a96 
Signed-off-by: Mohit Chhaya <mohitchhaya24@gmail.com>
@mrchhaya
rank
58dba81 
Signed-off-by: Mohit Chhaya <mohitchhaya24@gmail.com>
@timkpaine timkpaine added type: enhancement Issues and PRs related to improvements to existing features tag: needs squash PRs that need to be cleaned/squashed labels Jul 12, 2024
timkpaine
timkpaine requested changes Jul 12, 2024
View reviewed changes
cpp/csp/cppnodes/statsimpl.h Outdated Show resolved Hide resolved
timkpaine
timkpaine requested changes Jul 12, 2024
View reviewed changes
Copy link
Member

@timkpaine timkpaine left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

csp/cpp/csp/cppnodes/statsimpl.h:16:10: fatal error: 'boost/multi_index_container.hpp' file not found

You may need to add boost-multi-index explicitly as a separate vcpkg dep in vcpkg.json

AdamGlustein
AdamGlustein requested changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@AdamGlustein AdamGlustein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks for the contribution! The only major action item is to remove the gnu::pbds tree since your impl beats it 😄

cpp/csp/cppnodes/statsimpl.h Show resolved Hide resolved
cpp/csp/cppnodes/statsimpl.h Outdated Show resolved Hide resolved
cpp/csp/cppnodes/statsimpl.h Outdated Show resolved Hide resolved
cpp/csp/cppnodes/statsimpl.h Outdated Show resolved Hide resolved
cpp/csp/cppnodes/statsimpl.h Outdated Show resolved Hide resolved
cpp/csp/cppnodes/statsimpl.h Outdated Show resolved Hide resolved
@timkpaine timkpaine changed the title Improve non-GCC implementation of statistics functions Quantile/Rank #77 Improve non-GCC implementation of statistics functions Quantile/Rank Jul 12, 2024
@timkpaine timkpaine mentioned this pull request Jul 13, 2024
Draft
@timkpaine timkpaine marked this pull request as draft July 13, 2024 21:06
@mrchhaya
benchmark, update build, address comments
a070d86 
Signed-off-by: Mohit Chhaya <mohitchhaya24@gmail.com>
@mrchhaya mrchhaya marked this pull request as ready for review July 14, 2024 18:58
@mrchhaya mrchhaya requested a review from ptomecek as a code owner July 14, 2024 18:58
@timkpaine timkpaine mentioned this pull request Jul 15, 2024
Merged
@timkpaine timkpaine closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkpaine timkpaine timkpaine requested changes

@AdamGlustein AdamGlustein AdamGlustein requested changes

@robambalu robambalu Awaiting requested review from robambalu robambalu is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

@ptomecek ptomecek Awaiting requested review from ptomecek ptomecek is a code owner

Assignees
No one assigned
Labels
tag: needs squash PRs that need to be cleaned/squashed type: enhancement Issues and PRs related to improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrchhaya @timkpaine @AdamGlustein