Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for autogen bypass, partial fix for #264 #252 #207, ref #303 #347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow for autogen bypass, partial fix for #264 #252 #207, ref #303 #347

wants to merge 1 commit into from
+856 −67

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Jul 19, 2024 •
edited
Loading

This PR does a few things:

  • Small tweaks to autogen script to include the python command in the generated files
  • Inline the autogenerated files needed for the csp main build
    • Add tests to enforce that these dont deviate
  • Tweak cmake autogen command to look for existing autogen files

@timkpaine timkpaine added type: enhancement Issues and PRs related to improvements to existing features lang: c++ Issues and PRs related to the C++ codebase part: build Issues and PRs related to the build process labels Jul 19, 2024
@timkpaine timkpaine force-pushed the tkp/autogen branch 2 times, most recently from 460fe5a to b897318 Compare July 19, 2024 20:08
@timkpaine timkpaine marked this pull request as ready for review July 19, 2024 21:14
@timkpaine timkpaine force-pushed the tkp/autogen branch 2 times, most recently from e5639c5 to 9d3b6d0 Compare August 7, 2024 16:58
@timkpaine
Allow for autogen bypass, partial fix for #264 #252 #207, ref #303
6f2430e 
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robambalu robambalu Awaiting requested review from robambalu robambalu is a code owner

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

@ptomecek ptomecek Awaiting requested review from ptomecek ptomecek is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
lang: c++ Issues and PRs related to the C++ codebase part: build Issues and PRs related to the build process type: enhancement Issues and PRs related to improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@timkpaine