Adds burst to websocket adapter; move build to c++20 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrieg123
requested review from
robambalu,
AdamGlustein,
svatasoiu,
alexddobkin,
ptomecek and
timkpaine
as code owners
wrieg123
added
adapter: websocket
robambalu
reviewed
Aug 9, 2024
wrieg123
force-pushed
the
fix-burst-in-ws
branch
from
1ef02d2
to
7dc7edf
Compare
wrieg123
force-pushed
the
fix-burst-in-ws
branch
from
7dc7edf
to
d4ad630
Compare
Signed-off-by: Will Rieger <will.r.rieger@gmail.com>
wrieg123
force-pushed
the
fix-burst-in-ws
branch
2 times, most recently
from
52b48d7
to
e91797b
Compare
robambalu
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
csp.PushMode.BURST requires the use of
dataTypenottypewhen resolving the input adapter type