Make all public classes of CSP visible for user extension modules #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGlustein
requested review from
robambalu,
svatasoiu,
alexddobkin,
ptomecek and
timkpaine
as code owners
AdamGlustein
force-pushed
the
fix-symbol-visibility-for-user-extensions
branch
from
78e4af3
to
5cc011e
Compare
robambalu
requested changes
Oct 2, 2024
timkpaine
reviewed
Oct 2, 2024
cpp/csp/core/SRMWLockFreeQueue.h
Outdated
| @@ -14,7 +14,7 @@ namespace csp | |||
| one of the simplest! template type is required to have an intrinsic next pointer | |||
| */ | |||
| template< typename T > | |||
| class alignas(CACHELINE_SIZE) SRMWLockFreeQueue | |||
| class CSP_PUBLIC alignas(CACHELINE_SIZE) SRMWLockFreeQueue | |||
There was a problem hiding this comment.
Looks like some of these are missing the Platform.h include leading to the syntax errors in compilation
There was a problem hiding this comment.
No, the header propagates in from csp/core/TIme.h in this case. There's some weird behavior with the combination of alignas and CSP_PUBLIC, although locally it builds fine for me.
There was a problem hiding this comment.
ITs good practice to always include all of your deps directly, otherwise you can break if the header you rely on to transitively include stops including your dep.
As for the error, I havent seen which build failed but if its macos it could be the compiler
There was a problem hiding this comment.
Included all the headers btw
…cess them Signed-off-by: Adam Glustein <adam.glustein@point72.com>
AdamGlustein
force-pushed
the
fix-symbol-visibility-for-user-extensions
branch
from
5cc011e
to
49a7bfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #363