-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup CI for adapter with service dependencies #8
base: main
Are you sure you want to change the base?
Conversation
7b48be6
to
0f91511
Compare
93e5d1b
to
8693a5a
Compare
87d1023
to
95b9a53
Compare
08995d1
to
7a07db5
Compare
8627a7b
to
8562daa
Compare
ok this is finally working ok, does not appreciably increase CI/CD time and worth it until we can separate adapters. |
053e0e8
to
6909355
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two warnings from pytest that come up:
csp/tests/adapters/test_kafka.py:297
/home/runner/work/csp/csp/csp/tests/adapters/test_kafka.py:297: PytestRemovedIn9Warning: Marks applied to fixtures have no effect
See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
@pytest.mark.skipif(not os.environ.get("CSP_TEST_KAFKA"), reason="Skipping kafka adapter tests")
and
csp/tests/adapters/test_kafka.py:373
/home/runner/work/csp/csp/csp/tests/adapters/test_kafka.py:373: PytestRemovedIn9Warning: Marks applied to fixtures have no effect
See docs: https://docs.pytest.org/en/stable/deprecations.html#applying-a-mark-to-a-fixture-function
@pytest.mark.skipif(not os.environ.get("CSP_TEST_KAFKA"), reason="Skipping kafka adapter tests")
I'm not sure that it is intended for test_raw_pubsub
and test_invalid_topic
to be tagged with @pytest.fixture
. These two tests don't appear in the list of tests that were run via the action either.
There is a race condition in one of the tests it seems, wanted to note here in case it comes up. I cannot fully hammer it down, and unclear if its an actual issue with the historical->realtime switch or if the test itself has buggy assumptions. |
do you have an example link |
Based on the test and the error message it looks like whats happening is that the sub is missing the first pub. Its possible the daemon is late to register the subscriber before the first publish. One way to try and fix it is to delay the first pub a bit. Another possibility is to compare the last N msgs rather than the first N |
fc66f1e
to
8bca913
Compare
c64cb93
to
21229ed
Compare
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
e978101
to
ad2cdf0
Compare
No description provided.