-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yukon-Basic-Personal-Amount #441
Conversation
...gine_canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/amount.yaml
Outdated
Show resolved
Hide resolved
...gine_canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/amount.yaml
Outdated
Show resolved
Hide resolved
...gine_canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/tests/gov/provinces/yt/tax/income/credits/yt_basic_personal_amount.yaml
Outdated
Show resolved
Hide resolved
…dits/basic_personal_amount/amount.yaml Co-authored-by: Pavel Makarchuk <110687043+PavelMakarchuk@users.noreply.github.com>
…-canada into Yukon-Basic-Personal-Amount
…418/policyengine-canada into Yukon-Basic-Personal-Amount
…-canada into Yukon-Basic-Personal-Amount
policyengine_canada/variables/gov/provinces/yt/tax/income/yt_basic_personal_amount.py
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/gov/provinces/yt/tax/income/yt_basic_personal_amount.py
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/gov/provinces/yt/tax/income/yt_basic_personal_amount.py
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/gov/provinces/yt/tax/income/yt_basic_personal_amount.py
Show resolved
Hide resolved
...canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/base_amount.yaml
Outdated
Show resolved
Hide resolved
...canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/base_amount.yaml
Show resolved
Hide resolved
...canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/base_amount.yaml
Outdated
Show resolved
Hide resolved
...canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/base_amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/tests/gov/provinces/yt/tax/income/credits/yt_basic_personal_amount.yaml
Outdated
Show resolved
Hide resolved
...ne_canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/division.yaml
Outdated
Show resolved
Hide resolved
...ne_canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/division.yaml
Outdated
Show resolved
Hide resolved
…-canada into Yukon-Basic-Personal-Amount
.../parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/applicable_amount.yaml
Show resolved
Hide resolved
.../parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/applicable_amount.yaml
Outdated
Show resolved
Hide resolved
...canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/base_amount.yaml
Outdated
Show resolved
Hide resolved
...ine_canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/divisor.yaml
Outdated
Show resolved
Hide resolved
...ine_canada/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/divisor.yaml
Outdated
Show resolved
Hide resolved
...a/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/income_threshold.yaml
Outdated
Show resolved
Hide resolved
...a/parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/income_threshold.yaml
Outdated
Show resolved
Hide resolved
.../parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/applicable_amount.yaml
Outdated
Show resolved
Hide resolved
.../parameters/gov/provinces/yt/tax/income/credits/basic_personal_amount/applicable_amount.yaml
Outdated
Show resolved
Hide resolved
period | ||
).gov.provinces.yt.tax.income.credits.basic_personal_amount | ||
|
||
applicable_amount = p.applicable_amount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need these - just use p.
in the calculation
) | ||
additional_amount_eligible = additional_amount <= 0 | ||
|
||
return where( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
separate these into two variables yt_basic_personal_amount_{base,additional}
and then have this use adds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move these three files into a new additional
folder
@@ -0,0 +1,15 @@ | |||
description: Yukon reduces this basic personal amount, for high income filers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the amount of the additional bpa?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the phase-out width
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Max left comments, I dont see any commits resolving those
Duplicate of #490 |
Fixes #312