Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WIDOW to SURVIVING_SPOUSE filing status #4130

Merged
merged 26 commits into from
Apr 2, 2024
Merged

Rename WIDOW to SURVIVING_SPOUSE filing status #4130

merged 26 commits into from
Apr 2, 2024

Conversation

JudyZ13
Copy link
Collaborator

@JudyZ13 JudyZ13 commented Mar 11, 2024

Fixes #4094

PavelMakarchuk
PavelMakarchuk requested changes Mar 14, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
changelog.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/contrib/congress/wftca/bonus_guaranteed_deduction/amount.yaml Outdated Show resolved Hide resolved
@PavelMakarchuk
Copy link
Collaborator

also need to resolve merge conflicts

JudyZ13 added 11 commits March 14, 2024 13:36
@JudyZ13
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us
18dd28b 
 into JudyZ13/issue4094
@JudyZ13
updates
023ff0f
@JudyZ13
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us
97439f6 
 into JudyZ13/issue4094
@JudyZ13
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us
ad649fa 
 into JudyZ13/issue4094
@JudyZ13
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us
5291b08 
 into JudyZ13/issue4094
@JudyZ13
Co-authored-by: Pavel Makarchuk <PavelMakarchuk@users.noreply.github.…
0fda3d9 
…com>
@JudyZ13
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us
c863139 
 into JudyZ13/issue4094
@JudyZ13
updates
5d8ea34
@JudyZ13
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us
d051bc1 
 into JudyZ13/issue4094
@JudyZ13
fixed errors
bee6070
@JudyZ13
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us
4126e00 
 into JudyZ13/issue4094
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (dbe2554) to head (b109c18).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4130   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files        2406     2406           
  Lines       34827    34827           
  Branches      163      163           
=======================================
  Hits        34538    34538           
  Misses        259      259           
  Partials       30       30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JudyZ13 JudyZ13 requested a review from PavelMakarchuk March 28, 2024 19:26
PavelMakarchuk
PavelMakarchuk requested changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please double check that we didnt delete any lines or changed the dates

policyengine_us/parameters/gov/states/ca/tax/income/credits/renter/amount.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/ca/tax/income/credits/renter/amount.yaml Outdated Show resolved Hide resolved
...cyengine_us/parameters/gov/states/ca/tax/income/deductions/itemized/limit/agi_threshold.yaml Show resolved Hide resolved
policyengine_us/parameters/gov/states/ca/tax/income/deductions/standard/amount.yaml Show resolved Hide resolved
policyengine_us/parameters/gov/states/ca/tax/income/exemptions/phase_out/increment.yaml Outdated Show resolved Hide resolved
policyengine_us/parameters/gov/states/ca/tax/income/exemptions/phase_out/start.yaml Show resolved Hide resolved
...rameters/gov/states/ma/tax/income/credits/senior_circuit_breaker/eligibility/max_income.yaml Show resolved Hide resolved
@JudyZ13 JudyZ13 requested a review from PavelMakarchuk April 2, 2024 15:14
@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review April 2, 2024 17:05
@PavelMakarchuk
Copy link
Collaborator

@MaxGhenis the basic rules PR is done but do we need to change anything in the cps etc.? No tests fail currently

@PavelMakarchuk PavelMakarchuk requested a review from MaxGhenis April 2, 2024 17:06
MaxGhenis
MaxGhenis approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after this. No need to amend anything on the microdata side, we're already grabbing widow status and using it in filing_status, and the calibration data for SS is logged as joint.

CHANGELOG.md Outdated Show resolved Hide resolved
@MaxGhenis MaxGhenis merged commit 1dc9003 into PolicyEngine:master Apr 2, 2024
6 checks passed
@abhcs abhcs mentioned this pull request Apr 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelMakarchuk PavelMakarchuk PavelMakarchuk approved these changes

@MaxGhenis MaxGhenis MaxGhenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename WIDOW to SURVIVING_SPOUSE filing status
3 participants
@JudyZ13 @PavelMakarchuk @MaxGhenis