Fix New Mexico Low Income Comprehensive Tax Rebate calculations

[xianxinzhu]

Fixes #4319

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (63e0693) to head (31a83ef).

❗ Current head 31a83ef differs from pull request most recent head c0391da. Consider uploading reports for the commit c0391da to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4346   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files        2408     2408           
  Lines       34854    34854           
  Branches      163      163           
=======================================
  Hits        34565    34565           
  Misses        259      259           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MaxGhenis]

Can you describe the issue this is addressing? I don't see why we'd have to deviate from the law by adding a dollar to the thresholds.

[martinholmer]

@MaxGhenis said:

Can you describe the issue this is addressing? I don't see why we'd have to deviate from the law by adding a dollar to the thresholds.

Agreed. You are just undoing what was done in PR #4300 rather than figuring out the source of the problem in issue #4319.

[PavelMakarchuk]

I see what happened, the right=True function also applies to the first threshold value which in this case is 0. In rhis case, if AGI is 0, it seems to fall outside the range of the brackets and is returned as 0.
To overcome this we can set the first threshold value to "-1" for all yaml files

[MaxGhenis]

if it's single_amount the left endpoint should be -.inf

[martinholmer]

@MaxGhenis said in PR #4346:

if it's single_amount the left endpoint should be -.inf

I agree. I don't see why a filer with NM AGI of -$100 would be ineligible for the rebate.

[PavelMakarchuk]

@MaxGhenis makes sense, adjusted.