Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Missouri income tax parameter structure #5255

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

leehengpan
Copy link
Collaborator

@leehengpan leehengpan commented Oct 19, 2024

New PR to replace PR #5236

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (cb92a56) to head (45353f0).
Report is 207 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5255      +/-   ##
==========================================
- Coverage   99.12%   99.00%   -0.13%     
==========================================
  Files        2592     2627      +35     
  Lines       37707    38224     +517     
  Branches      162      168       +6     
==========================================
+ Hits        37378    37843     +465     
- Misses        297      347      +50     
- Partials       32       34       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leehengpan leehengpan self-assigned this Oct 20, 2024
changelog.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename all of these parameter files to remove the mo_
Also please structure them into folders based on program

this will have an effect on the variables - please run the MO tests when adjustments are made and adjust code as needed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make a folder for joint and name the tow files
owner.yaml
renter.yaml

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to income_threshold.yaml

@PavelMakarchuk PavelMakarchuk marked this pull request as draft October 22, 2024 05:16
@PavelMakarchuk
Copy link
Collaborator

Please make sure that the variable structure is adjusted

Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description: Missouri limits the property tax credit to filers of this age or older.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description: Missouri limits the property tax credit to filers receiving social security survivor benefits who are at least this age.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description: Missouri caps the property tax credit for a rented property to this amount.

@hua7450
Copy link
Collaborator

hua7450 commented Oct 29, 2024

For all parameter files, if there is a "MO" in description, replace it with "Missouri", and rephrase the description.
Under the references section, I would keep the MO in things like 2023 Form MO-1040, because that is the tax form's name.

leehengpan and others added 4 commits October 29, 2024 11:01
…operty_tax/age_threshold.yaml

Co-authored-by: hua7450 <113824411+hua7450@users.noreply.github.com>
…operty_tax/income_offset/joint/owner.yaml

Co-authored-by: hua7450 <113824411+hua7450@users.noreply.github.com>
…operty_tax/aged_survivor_min_age.yaml

Co-authored-by: hua7450 <113824411+hua7450@users.noreply.github.com>
@hua7450
Copy link
Collaborator

hua7450 commented Oct 31, 2024

Can you add the specific legal code section to all parameter references?

@leehengpan
Copy link
Collaborator Author

Can you add the specific legal code section to all parameter references?

Could you give an example of how to do this since I have little idea of where I should look for these section codes. Thanks

@leehengpan leehengpan requested a review from hua7450 November 1, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants