-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Missouri income tax parameter structure #5255
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5255 +/- ##
==========================================
- Coverage 99.12% 99.00% -0.13%
==========================================
Files 2592 2627 +35
Lines 37707 38224 +517
Branches 162 168 +6
==========================================
+ Hits 37378 37843 +465
- Misses 297 347 +50
- Partials 32 34 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename all of these parameter files to remove the mo_
Also please structure them into folders based on program
this will have an effect on the variables - please run the MO tests when adjustments are made and adjust code as needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make a folder for joint and name the tow files
owner.yaml
renter.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to income_threshold.yaml
Please make sure that the variable structure is adjusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes
...ine_us/parameters/gov/states/mo/tax/income/credits/property_tax/rent_property_tax_limit.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mo/tax/income/deductions/federal_income_tax/cap.yaml
Outdated
Show resolved
Hide resolved
...rameters/gov/states/mo/tax/income/deductions/pension/public_pension_deduction_allowance.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/mo/tax/income/credits/property_tax/age_threshold.yaml
Outdated
Show resolved
Hide resolved
...e_us/parameters/gov/states/mo/tax/income/credits/property_tax/income_offset/joint/owner.yaml
Outdated
Show resolved
Hide resolved
...ngine_us/parameters/gov/states/mo/tax/income/credits/property_tax/aged_survivor_min_age.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Missouri limits the property tax credit to filers of this age or older.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Missouri limits the property tax credit to filers receiving social security survivor benefits who are at least this age.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Missouri caps the property tax credit for a rented property to this amount.
For all parameter files, if there is a "MO" in description, replace it with "Missouri", and rephrase the description. |
…operty_tax/age_threshold.yaml Co-authored-by: hua7450 <113824411+hua7450@users.noreply.github.com>
…operty_tax/income_offset/joint/owner.yaml Co-authored-by: hua7450 <113824411+hua7450@users.noreply.github.com>
…operty_tax/aged_survivor_min_age.yaml Co-authored-by: hua7450 <113824411+hua7450@users.noreply.github.com>
Can you add the specific legal code section to all parameter references? |
Could you give an example of how to do this since I have little idea of where I should look for these section codes. Thanks |
New PR to replace PR #5236