feat: 책 기능을 추가했습니다. #9
Conversation
WalkthroughThe changes in this pull request involve significant enhancements to the book management functionality within the application. Key modifications include the introduction of new classes and methods for book creation, updating, borrowing, and returning. A new interface and its implementation have been created to streamline these operations. Additionally, a new configuration for integrating with the Naver Book API has been added, along with improvements to the README documentation for setup instructions. The overall structure has been refined to provide clearer data transfer objects and better error handling. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 14
🧹 Outside diff range and nitpick comments (18)
src/main/java/org/poolc/api/book/client/NaverBookClient.java (4)
49-49: Use a logging framework instead ofSystem.out.printlnUsing
System.out.printlnfor output is not recommended in production code. Consider using a logging framework like SLF4J or Log4j for better control over logging levels and outputs.
56-56: Use logging instead ofe.printStackTrace()Printing stack traces directly is not suitable for production environments. Use a logging framework to log exceptions, which allows for better log management and severity levels.
57-57: Define a custom exception or use an appropriate existing oneThrowing
XMLParseExceptionfromjavax.management.modelmbeanmay not be appropriate here. Consider creating a custom exception (e.g.,XmlParsingException) or usingDataFormatExceptionto represent XML parsing errors more accurately.
61-61: Specify precise exceptions in the method signatureInstead of
throws Exception, specify the exact exceptions thatparseBooksmight throw, such asJsonProcessingExceptionorIOException, to improve clarity and exception handling.src/main/java/org/poolc/api/book/service/BookServiceImpl.java (1)
101-103: Use a more appropriate exception for authorization failuresThrowing an
IllegalArgumentExceptionwhen access is denied may not be semantically correct. Consider usingAccessDeniedExceptionor creating a custom exception to represent unauthorized access appropriately.src/main/java/org/poolc/api/book/controller/BookController.java (1)
36-36: Specify response types explicitly inResponseEntityUsing raw types like
ResponseEntity<?>can reduce type safety. Specify the response type explicitly, such asResponseEntity<Page<BookResponse>>orResponseEntity<BookResponse>, to improve code clarity and maintainability.Also applies to: 45-45, 54-54, 65-65, 75-75, 86-86, 96-96
src/main/java/org/poolc/api/book/client/BookClient.java (1)
5-5: Use an appropriate exception class for XML parsing errorsThe
XMLParseExceptionfromjavax.management.modelmbeanis intended for JMX use and may not be suitable here. Consider usingXmlParseExceptionfrom a more relevant package or define a custom exception to accurately represent parsing errors.Also applies to: 10-10
src/main/java/org/poolc/api/book/repository/BookRepository.java (1)
11-14: Consider adding index hints for query optimizationThe
findAllByOrderByCreatedAtDescmethod would benefit from an index on thecreatedAtcolumn. Add the following index to theBookentity:@Entity public class Book { + @Index(name = "idx_book_created_at") private LocalDateTime createdAt;src/main/java/org/poolc/api/book/dto/request/UpdateBookRequest.java (1)
7-21: Add field documentationConsider adding Javadoc to describe the purpose and constraints of each field.
@Getter @AllArgsConstructor @NoArgsConstructor public class UpdateBookRequest { + /** + * The title of the book. + * Must not be blank and maximum length is 255 characters. + */ private String title; + + /** + * The author of the book. + * Must not be blank and maximum length is 255 characters. + */ private String author; // Add similar documentation for other fields }src/main/resources/application.yml (1)
35-39: Document the new environment variablesThe configuration for Naver Book API follows good security practices by using environment variables. However, these new environment variables need to be documented.
Please update the README or environment setup documentation to include:
NAVER_BOOK_API_URLNAVER_BOOK_CLIENT_IDNAVER_BOOK_CLIENT_SECRETsrc/main/java/org/poolc/api/book/dto/request/CreateBookRequest.java (1)
27-28: Add maximum length constraint for descriptionWhile descriptions can be long, having no maximum length could lead to potential issues.
- @Length(min = 1) + @Length(min = 1, max = 4000) private String description;src/main/java/org/poolc/api/book/dto/response/BookApiResponse.java (2)
10-38: Add class-level documentation and null handlingThe response DTO could benefit from better documentation and null handling:
- Add class-level documentation explaining the XML structure
- Consider using
@JsonIncludeto handle null values+import com.fasterxml.jackson.annotation.JsonInclude; + +/** + * Response DTO for Naver Book API XML response. + * Maps to the following XML structure: + * <item> + * <title>Book Title</title> + * <link>Book URL</link> + * ... + * </item> + */ +@JsonInclude(JsonInclude.Include.NON_NULL) @Getter @Builder @AllArgsConstructor @NoArgsConstructor public class BookApiResponse {
24-25: Handle potential null discount valuesThe discount field is an Integer which could be null from the API response. Consider using an Optional or providing a default value.
@JacksonXmlProperty(localName = "discount") - private Integer discount; + private Integer discount = 0;src/test/java/org/poolc/api/book/BookDataLoader.java (1)
Test data setup needs to be maintained
The acceptance tests in
BookAcceptanceTest.javaare currently commented out and theBookDataLoaderhas been disabled. This is problematic because:
- The acceptance tests expect 7 books to exist (
assertThat(response.body().jsonPath().getList("data")).hasSize(7))- Tests reference specific book IDs (1L through 7L) and data ("형철이의 삶", "풀씨")
- No alternative test data setup mechanism (SQL files or test properties) is present
Either:
- Restore the
BookDataLoaderimplementation- Or replace it with an alternative test data setup mechanism that provides the expected test data
🔗 Analysis chain
Line range hint
14-39: Reconsider commenting out test data setupThe entire test data loader functionality has been commented out. While this might be intentional as part of the book feature refactoring, we should ensure that:
- Test coverage is maintained with alternative test data setup
- Integration tests that might have depended on this data loader are updated accordingly
Let's check for any existing test dependencies:
Would you like help creating an updated version of the test data loader that aligns with the new book features?
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for tests that might reference BookDataLoader rg -l "BookDataLoader|@Profile.*bookTest" "src/test" # Check for potentially affected test files rg -l "형철이의 삶|풀씨" "src/test"Length of output: 717
Script:
#!/bin/bash # Let's check the content of BookAcceptanceTest to see if it depends on the commented data cat src/test/java/org/poolc/api/book/BookAcceptanceTest.java # Also check if there are other data loaders or setup methods for book tests rg -l "class.*Test.*Book|@Test.*Book" src/testLength of output: 12759
Script:
#!/bin/bash # Let's check if there are any other active test data setup mechanisms rg -A 5 "@Profile.*bookTest" src/test # Check for any SQL data setup files fd -e sql . src/test # Check for any other test configuration files fd -e yaml -e properties . src/test/resourcesLength of output: 588
src/main/java/org/poolc/api/book/dto/response/NaverApiResponse.java (2)
27-38: Consider adding validation annotationsThe Channel class fields (lastBuildDate, total, start, display) lack validation annotations. Consider adding:
@NotNullfor required fields@Min(0)for numeric fields that should be non-negative@Sizeconstraints for the items listExample implementation:
+import javax.validation.constraints.Min; +import javax.validation.constraints.NotNull; @JacksonXmlProperty(localName="total") + @NotNull + @Min(0) private Integer total; @JacksonXmlProperty(localName="start") + @NotNull + @Min(0) private Integer start; @JacksonXmlProperty(localName="display") + @NotNull + @Min(0) private Integer display;
39-41: Add documentation for XML wrapper configurationThe
@JacksonXmlElementWrapper(useWrapping = false)configuration is crucial for correct XML parsing. Consider adding a comment explaining why this configuration is needed.+ // Disable XML wrapping since Naver API returns items directly under channel + // without an additional wrapper element @JacksonXmlProperty(localName = "item") @JacksonXmlElementWrapper(useWrapping = false) private List<BookApiResponse> items;src/main/java/org/poolc/api/book/dto/response/BookResponse.java (1)
18-29: Consider adding validation annotations for response fieldsTo ensure data integrity, consider adding validation annotations to the fields. This is especially important for fields that should never be null in the response.
+import javax.validation.constraints.NotNull; +import javax.validation.constraints.NotBlank; + @NotNull private Long id; + @NotBlank private String title; private String link; private String imageURL; + @NotBlank private String author; private String description; private Integer discount; private String isbn; private String publisher; private String publishedDate; private LocalDate borrowDate; + @NotNull private BookStatus status;src/main/java/org/poolc/api/book/domain/Book.java (1)
35-45: Consider adding validation constraints for title and authorWhile nullable constraints are set correctly, consider adding length constraints to prevent extremely long titles or author names that might cause display issues.
- @Column(name = "title", nullable = false) + @Column(name = "title", nullable = false) + @Size(max = 255) private String title; - @Column(name = "author", nullable = false) + @Column(name = "author", nullable = false) + @Size(max = 255) private String author;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (27)
README.md(0 hunks)build.gradle(1 hunks)src/main/java/org/poolc/api/activity/domain/Session.java(1 hunks)src/main/java/org/poolc/api/badge/service/BadgeService.java(1 hunks)src/main/java/org/poolc/api/book/client/BookClient.java(1 hunks)src/main/java/org/poolc/api/book/client/NaverBookClient.java(1 hunks)src/main/java/org/poolc/api/book/controller/BookController.java(1 hunks)src/main/java/org/poolc/api/book/domain/Book.java(4 hunks)src/main/java/org/poolc/api/book/domain/BookBorrower.java(1 hunks)src/main/java/org/poolc/api/book/domain/BorrowStatus.java(1 hunks)src/main/java/org/poolc/api/book/dto/BookRequest.java(0 hunks)src/main/java/org/poolc/api/book/dto/BookResponse.java(0 hunks)src/main/java/org/poolc/api/book/dto/request/CreateBookRequest.java(1 hunks)src/main/java/org/poolc/api/book/dto/request/UpdateBookRequest.java(1 hunks)src/main/java/org/poolc/api/book/dto/response/BookApiResponse.java(1 hunks)src/main/java/org/poolc/api/book/dto/response/BookResponse.java(1 hunks)src/main/java/org/poolc/api/book/dto/response/NaverApiResponse.java(1 hunks)src/main/java/org/poolc/api/book/repository/BookRepository.java(1 hunks)src/main/java/org/poolc/api/book/service/BookService.java(1 hunks)src/main/java/org/poolc/api/book/service/BookServiceImpl.java(1 hunks)src/main/java/org/poolc/api/book/vo/BookCreateValues.java(0 hunks)src/main/java/org/poolc/api/book/vo/BookUpdateValues.java(0 hunks)src/main/java/org/poolc/api/book/vo/BorrowerValues.java(0 hunks)src/main/java/org/poolc/api/configuration/RestTemplateConfig.java(1 hunks)src/main/resources/application.yml(1 hunks)src/test/java/org/poolc/api/book/BookAcceptanceTest.java(2 hunks)src/test/java/org/poolc/api/book/BookDataLoader.java(2 hunks)
💤 Files with no reviewable changes (6)
- src/main/java/org/poolc/api/book/vo/BookUpdateValues.java
- src/main/java/org/poolc/api/book/vo/BorrowerValues.java
- src/main/java/org/poolc/api/book/dto/BookRequest.java
- README.md
- src/main/java/org/poolc/api/book/vo/BookCreateValues.java
- src/main/java/org/poolc/api/book/dto/BookResponse.java
✅ Files skipped from review due to trivial changes (4)
- src/main/java/org/poolc/api/activity/domain/Session.java
- src/main/java/org/poolc/api/book/domain/BorrowStatus.java
- src/main/java/org/poolc/api/book/domain/BookBorrower.java
- src/test/java/org/poolc/api/book/BookAcceptanceTest.java
🔇 Additional comments (2)
src/main/java/org/poolc/api/book/domain/Book.java (1)
4-5: LGTM: Entity annotations are well-structured
The addition of @AllArgsConstructor and @Builder annotations facilitates clean object creation, especially useful for the book registration feature.
Also applies to: 21-21, 23-23
src/main/java/org/poolc/api/badge/service/BadgeService.java (1)
142-151: LGTM: Transaction management properly implemented
The addition of @transactional and the duplicate check logic ensures data consistency when giving badges.
| void deleteBook(Member member, Long id) throws Exception; | ||
| void updateBook(Member member, Long id, UpdateBookRequest request) throws Exception; | ||
| void borrow(Member member, Long id) throws Exception; | ||
| void returnBook(Member member, Long id) throws Exception; |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Specify more specific exceptions instead of 'throws Exception'
Using throws Exception in method declarations is too broad and can obscure the exact nature of exceptions that might be thrown. It's better to declare specific exceptions to improve code clarity and error handling.
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| throw new XMLParseException("Failed to parse XML response"); | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Avoid catching generic Exception; catch specific exceptions
Catching a generic Exception can make debugging harder and may catch exceptions you didn't intend to handle. Catch specific exceptions like IOException, HttpClientErrorException, or XmlMappingException to handle known error cases.
| public void deleteBook(Member member, Long id) throws Exception { | ||
| checkAdmin(member); | ||
| Book book = bookRepository.findById(id) | ||
| .orElseThrow(() -> new Exception("책을 찾을 없습니다. id: " + id)); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Avoid throwing generic Exception; use specific exception classes
Throwing generic exceptions reduces the specificity of error handling. Use more specific exceptions like NoSuchElementException, IllegalStateException, or define custom exceptions to provide clearer context and improve maintainability.
Also applies to: 65-65, 73-75, 85-89
| return new ResponseEntity<>(bookClient.searchBooks(query, page), HttpStatus.OK); | ||
| } catch (Exception e) { | ||
| return new ResponseEntity<>(e.getMessage(), HttpStatus.INTERNAL_SERVER_ERROR); | ||
| } |
There was a problem hiding this comment.
Avoid returning exception messages directly in API responses
Returning e.getMessage() to the client can expose sensitive information and is a security risk. Instead, return user-friendly error messages and use appropriate HTTP status codes like BAD_REQUEST, NOT_FOUND, or FORBIDDEN based on the error type.
Also applies to: 38-41, 47-50, 57-61, 67-71, 78-82, 88-92, 98-102
| @Bean | ||
| public RestTemplate restTemplate() { | ||
| return new RestTemplate(); | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Enhance RestTemplate configuration for production readiness
The current RestTemplate configuration lacks essential production-ready features. Consider adding:
- Connection/read timeout settings
- Error handling
- SSL configuration
- Retry mechanism for transient failures
@Bean
public RestTemplate restTemplate() {
- return new RestTemplate();
+ HttpComponentsClientHttpRequestFactory factory = new HttpComponentsClientHttpRequestFactory();
+ factory.setConnectTimeout(5000);
+ factory.setReadTimeout(5000);
+
+ RestTemplate restTemplate = new RestTemplate(factory);
+
+ restTemplate.setErrorHandler(new ResponseErrorHandler() {
+ @Override
+ public boolean hasError(ClientHttpResponse response) throws IOException {
+ return response.getStatusCode().series() == HttpStatus.Series.CLIENT_ERROR
+ || response.getStatusCode().series() == HttpStatus.Series.SERVER_ERROR;
+ }
+
+ @Override
+ public void handleError(ClientHttpResponse response) throws IOException {
+ throw new RestClientException("API call failed: " + response.getStatusCode());
+ }
+ });
+
+ return restTemplate;Committable suggestion skipped: line range outside the PR's diff.
| @Length(min = 1, max = 100) | ||
| private String isbn; |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Strengthen ISBN validation
The current validation only checks length. Consider adding a pattern validation for ISBN format.
- @Length(min = 1, max = 100)
+ @Length(min = 10, max = 13)
+ @Pattern(regexp = "^(?:ISBN(?:-1[03])?:? )?(?=[0-9X]{10}$|(?=(?:[0-9]+[- ]){3})[- 0-9X]{13}$|97[89][0-9]{10}$|(?=(?:[0-9]+[- ]){4})[- 0-9]{17}$)(?:97[89][- ]?)?[0-9]{1,5}[- ]?[0-9]+[- ]?[0-9]+[- ]?[0-9X]$")
private String isbn;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| @Length(min = 1, max = 100) | |
| private String isbn; | |
| @Length(min = 10, max = 13) | |
| @Pattern(regexp = "^(?:ISBN(?:-1[03])?:? )?(?=[0-9X]{10}$|(?=(?:[0-9]+[- ]){3})[- 0-9X]{13}$|97[89][0-9]{10}$|(?=(?:[0-9]+[- ]){4})[- 0-9]{17}$)(?:97[89][- ]?)?[0-9]{1,5}[- ]?[0-9]+[- ]?[0-9]+[- ]?[0-9X]$") | |
| private String isbn; |
| public static BookResponse of(Book book) { | ||
| return BookResponse.builder() | ||
| .id(book.getId()) | ||
| .title(book.getTitle()) | ||
| .link(book.getLink()) | ||
| .imageURL(book.getImageURL()) | ||
| .author(book.getAuthor()) | ||
| .description(book.getDescription()) | ||
| .discount(book.getDiscount()) | ||
| .isbn(book.getIsbn()) | ||
| .publisher(book.getPublisher()) | ||
| .publishedDate(book.getPublishedDate()) | ||
| .borrowDate(book.getBorrowDate()) | ||
| .status(book.getStatus()) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add null checks and documentation to factory method
The of method should handle null values gracefully and include documentation for maintainability.
Consider adding:
- Null check for the input parameter
- JavaDoc explaining the method's purpose
- Null-safe getters
+ /**
+ * Creates a BookResponse DTO from a Book domain object.
+ *
+ * @param book the source Book object
+ * @return a new BookResponse instance
+ * @throws IllegalArgumentException if book is null
+ */
public static BookResponse of(Book book) {
+ if (book == null) {
+ throw new IllegalArgumentException("Book cannot be null");
+ }
return BookResponse.builder()
.id(book.getId())
.title(book.getTitle())
.link(book.getLink())
.imageURL(book.getImageURL())
.author(book.getAuthor())
.description(book.getDescription())
.discount(book.getDiscount())
.isbn(book.getIsbn())
.publisher(book.getPublisher())
.publishedDate(book.getPublishedDate())
.borrowDate(book.getBorrowDate())
.status(book.getStatus())
.build();
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| public static BookResponse of(Book book) { | |
| return BookResponse.builder() | |
| .id(book.getId()) | |
| .title(book.getTitle()) | |
| .link(book.getLink()) | |
| .imageURL(book.getImageURL()) | |
| .author(book.getAuthor()) | |
| .description(book.getDescription()) | |
| .discount(book.getDiscount()) | |
| .isbn(book.getIsbn()) | |
| .publisher(book.getPublisher()) | |
| .publishedDate(book.getPublishedDate()) | |
| .borrowDate(book.getBorrowDate()) | |
| .status(book.getStatus()) | |
| .build(); | |
| } | |
| /** | |
| * Creates a BookResponse DTO from a Book domain object. | |
| * | |
| * @param book the source Book object | |
| * @return a new BookResponse instance | |
| * @throws IllegalArgumentException if book is null | |
| */ | |
| public static BookResponse of(Book book) { | |
| if (book == null) { | |
| throw new IllegalArgumentException("Book cannot be null"); | |
| } | |
| return BookResponse.builder() | |
| .id(book.getId()) | |
| .title(book.getTitle()) | |
| .link(book.getLink()) | |
| .imageURL(book.getImageURL()) | |
| .author(book.getAuthor()) | |
| .description(book.getDescription()) | |
| .discount(book.getDiscount()) | |
| .isbn(book.getIsbn()) | |
| .publisher(book.getPublisher()) | |
| .publishedDate(book.getPublishedDate()) | |
| .borrowDate(book.getBorrowDate()) | |
| .status(book.getStatus()) | |
| .build(); | |
| } |
| public void update(UpdateBookRequest request) { | ||
| if (request.getTitle() != null) this.title = request.getTitle(); | ||
| if (request.getLink() != null) this.link = request.getLink(); | ||
| if (request.getImage() != null) this.imageURL = request.getImage(); | ||
| if (request.getAuthor() != null) this.author = request.getAuthor(); | ||
| if (request.getDescription() != null) this.description = request.getDescription(); | ||
| if (request.getDiscount() != null) this.discount = request.getDiscount(); | ||
| if (request.getIsbn() != null) this.isbn = request.getIsbn(); | ||
| if (request.getPublisher() != null) this.publisher = request.getPublisher(); | ||
| if (request.getPubdate() != null) this.publishedDate = request.getPubdate(); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Enhance update method with validation and audit logging
The current implementation should validate input values before updating and consider logging changes for audit purposes.
public void update(UpdateBookRequest request) {
+ validateUpdateRequest(request);
+ logBookChanges(request);
if (request.getTitle() != null) this.title = request.getTitle();
if (request.getLink() != null) this.link = request.getLink();
if (request.getImage() != null) this.imageURL = request.getImage();
if (request.getAuthor() != null) this.author = request.getAuthor();
if (request.getDescription() != null) this.description = request.getDescription();
if (request.getDiscount() != null) this.discount = request.getDiscount();
if (request.getIsbn() != null) this.isbn = request.getIsbn();
if (request.getPublisher() != null) this.publisher = request.getPublisher();
if (request.getPubdate() != null) this.publishedDate = request.getPubdate();
}
+
+ private void validateUpdateRequest(UpdateBookRequest request) {
+ if (request.getDiscount() != null && request.getDiscount() < 0) {
+ throw new IllegalArgumentException("Discount cannot be negative");
+ }
+ // Add more validations as needed
+ }Committable suggestion skipped: line range outside the PR's diff.
| @Column(name = "isbn") | ||
| private String isbn; | ||
|
|
||
| @Column(name = "publisher") | ||
| private String publisher; | ||
|
|
||
| @Column(name = "published_date") | ||
| private String publishedDate; |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add validation for ISBN and publishedDate fields
The ISBN field should validate against standard formats, and publishedDate should follow a consistent date format.
- @Column(name = "isbn")
+ @Column(name = "isbn")
+ @Pattern(regexp = "^(?:ISBN(?:-1[03])?:? )?(?=[0-9X]{10}$|(?=(?:[0-9]+[- ]){3})[- 0-9X]{13}$|97[89][0-9]{10}$|(?=(?:[0-9]+[- ]){4})[- 0-9]{17}$)(?:97[89][- ]?)?[0-9]{1,5}[- ]?[0-9]+[- ]?[0-9]+[- ]?[0-9X]$")
private String isbn;
- @Column(name = "published_date")
+ @Column(name = "published_date")
+ @Pattern(regexp = "^\\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[01])$")
private String publishedDate;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| @Column(name = "isbn") | |
| private String isbn; | |
| @Column(name = "publisher") | |
| private String publisher; | |
| @Column(name = "published_date") | |
| private String publishedDate; | |
| @Column(name = "isbn") | |
| @Pattern(regexp = "^(?:ISBN(?:-1[03])?:? )?(?=[0-9X]{10}$|(?=(?:[0-9]+[- ]){3})[- 0-9X]{13}$|97[89][0-9]{10}$|(?=(?:[0-9]+[- ]){4})[- 0-9]{17}$)(?:97[89][- ]?)?[0-9]{1,5}[- ]?[0-9]+[- ]?[0-9]+[- ]?[0-9X]$") | |
| private String isbn; | |
| @Column(name = "publisher") | |
| private String publisher; | |
| @Column(name = "published_date") | |
| @Pattern(regexp = "^\\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[01])$") | |
| private String publishedDate; |
| implementation group: 'com.fasterxml.jackson.dataformat', name: 'jackson-dataformat-xml', version: '2.18.1' | ||
| implementation group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.18.1' | ||
| implementation group: 'com.fasterxml.jackson.core', name: 'jackson-annotations', version: '2.18.1' | ||
| implementation group: 'com.fasterxml.jackson.core', name: 'jackson-core', version: '2.18.1' |
There was a problem hiding this comment.
💡 Codebase verification
Update Jackson dependencies from 2.18.1 to 2.18.2
The current version 2.18.1 is outdated. Version 2.18.2 is available with bug fixes and improvements. Update all Jackson dependencies to maintain version consistency:
com.fasterxml.jackson.dataformat:jackson-dataformat-xml:2.18.2com.fasterxml.jackson.core:jackson-databind:2.18.2com.fasterxml.jackson.core:jackson-annotations:2.18.2com.fasterxml.jackson.core:jackson-core:2.18.2
🔗 Analysis chain
Update Jackson dependencies to latest stable version
The current version 2.18.1 is not the latest stable version. Consider updating to the latest version for security patches and improvements.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check latest Jackson version from Maven Central
curl -s https://search.maven.org/solrsearch/select\?q\=g:%22com.fasterxml.jackson.core%22+AND+a:%22jackson-core%22\&rows\=1\&wt\=json | jq -r '.response.docs[0].latestVersion'
Length of output: 180
📕 Issue Number
Closes #8
📙 작업 내역
📘 작업 유형
📋 체크리스트
📝 PR 특이 사항
Summary by CodeRabbit
Release Notes
New Features
BookClientinterface for searching books via an API.NaverBookClientimplementation for book searches using the Naver API.BookControllerfor searching, adding, updating, and managing books.Improvements
BadgeService.Bookclass with additional fields for better data representation.Bug Fixes
BookAcceptanceTestfor clarity.Chores
application.yml.RestTemplateConfigfor HTTP request management.