Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of my ledger-load-only heap profiles the cloning of the
Program
(ProgramCore<N, Instruction<N>, Command<N>>
) was quite prominent, meaning it could be a good candidate forArc
ing; such a change would also make theBox
ing of the relatedDeployment
superfluous, which would also contribute to a reduction in clones.The clones of the
Program
are apparently also quite slow; even in a ledger where this change only results in a tiny change to the number of allocations, this speeds up its loading (viaLedger::load
) by ~8%.I'm filing this PR as a draft for 2 reasons:
Map
-related type changes; while those would be an additional win for in-memory storage, I'm not convinced about the persistent one