[Perf] Use SmallVec for additional temporary allocations #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
commented
May 30, 2024
| /// Writes `self` into the given vector as a boolean array in little-endian order. | ||
| fn write_bits_le(&self, vec: &mut Vec<bool>); | ||
| fn write_bits_le<T: VecLike>(&self, vec: &mut T); | ||
|
|
||
| /// Writes `self` into the given vector as a boolean array in big-endian order. | ||
| fn write_bits_be(&self, vec: &mut Vec<bool>); |
There was a problem hiding this comment.
note: this wasn't extended to write_bits_be, as those haven't been showing up in heap profiles, and the implementation of indexing that it would have to involve is a little bit tricky
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #3 which includes the same approach, but in scenarios that require some additional setup.
The first commit introduces a new trait,
VecLike, which applies to bothVec<bool>andSmallVec<[bool; N]>, and allows us to use the latter inToBitsoperations that are currently restricted to the former.While the new trait is quite trivial, it does require a bit of boilerplate (the
Extend::extend,VecLike::extend_from_sliceetc.) for disambiguation. The upside is that together with the other linked PR, there are clear performance benefits to doing so:(measured in a
--devnode in 15-minute local runs from scratch)