-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution Quality Evaluator #106
Conversation
…om/ProvideQ/toolbox-server into feature/solution-quality-evaluator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just needs a few tweaks :)
src/main/java/edu/kit/provideq/toolbox/demonstrators/DemonstratorConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/kit/provideq/toolbox/qubo/QuboConfiguration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final tweaks that would be good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little change and then we're good to go. Thank you for working in the feedback!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two final tweaks needed :)
@zaibod Just the change needed to use a float instead of String for Bounds as we talked about then it's good to merge! :) |
SonarQube just complains over an unused import for Optional in ProblemDto, everything else seems good! Thanks a lot for your work on the many iterations. |
Quality Gate passedIssues Measures |
Implements endpoint for getting a lower bound for a problem, see #81