Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution Quality Evaluator #106

Merged
merged 22 commits into from
Nov 27, 2024
Merged

Conversation

zaibod
Copy link
Contributor

@zaibod zaibod commented Nov 18, 2024

Implements endpoint for getting a lower bound for a problem, see #81

Copy link
Member

@Elscrux Elscrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just needs a few tweaks :)

Copy link
Member

@Elscrux Elscrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final tweaks that would be good :)

src/main/java/edu/kit/provideq/toolbox/meta/Problem.java Outdated Show resolved Hide resolved
src/main/java/edu/kit/provideq/toolbox/meta/Problem.java Outdated Show resolved Hide resolved
Copy link
Member

@Elscrux Elscrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little change and then we're good to go. Thank you for working in the feedback!

src/main/java/edu/kit/provideq/toolbox/api/ProblemDto.java Outdated Show resolved Hide resolved
Copy link
Member

@Elscrux Elscrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two final tweaks needed :)

@Elscrux
Copy link
Member

Elscrux commented Nov 25, 2024

@zaibod Just the change needed to use a float instead of String for Bounds as we talked about then it's good to merge! :)

@Elscrux
Copy link
Member

Elscrux commented Nov 25, 2024

SonarQube just complains over an unused import for Optional in ProblemDto, everything else seems good! Thanks a lot for your work on the many iterations.

@Elscrux Elscrux merged commit aefaba6 into develop Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants