Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtab Improvements #596

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

httpsnet
Copy link
Contributor

@httpsnet httpsnet commented May 31, 2024

Fixed an issue where subtab reset was not reset properly.
For example, if an unlocked subtab was displayed and a subtab was locked by import, the locked subtab could be displayed.

Subtab display state is now updated when the main tab is changed.

The argument of tabSwitcher() has been changed from a number to subTabID.
This function is used to update the visual of the subtab.

The ID name of the element of the singularity subtab has been changed to prevent the recurrence of bug #594.
Singularity has a lot of WIP, so this is to reduce the risk of index movement due to future tab movements or changes.

The tab switching function has been changed from an element style to a class.
The tab container is left as it is to avoid issues.

Fixed a case where elements in the Rune subtab were not updated.

Fixed some minor bugs in subtabs.

The tab switching function that was hooked to tabSwitcher() has been reorganized and moved to updateSubTab().

The challenge display is now updated when the C15 score is updated.
Since there were cases where the C15 score continued to be updated, a small amount of score amount required for score update was added.

@httpsnet
Copy link
Contributor Author

httpsnet commented Jun 14, 2024

tab improvements again

Subtab functionality has been incorporated into TabRow and $Tab

Reworked hideStuff() tab switching functionality and moved it to $Tab.updateTab()

Active tab buttons now have .tabActive and inline styles changed to CSS. This allows tab buttons to be themed

Fixed some bugs

@httpsnet
Copy link
Contributor Author

Fixes

Tab reset in resetGame() has been removed. It is executed by importSynergism()

changeTabColor(), which was only used on tab clicks, has been moved to changeTab()

Opera has been updated to fix the bug, so the workaround code has been removed

console.error(), which was used for debugging, has been removed

TabRow.constructor has been removed
this.style.cssText is already used in CSS
id declaration has been added to instant

This completes my work. If there is anything I can do, I will respond immediately.
If possible, please merge before the zod update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant