Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signature #124

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Update signature #124

merged 4 commits into from
Jul 5, 2023

Conversation

HanslettTheDev
Copy link
Collaborator

Summary

This pull requests aims to improve the work done in #113. Updating the cryptography module, fixing the broken tests and libraries

Checklist

  • Classes, Variables, function and methods logic ok
  • Comments written explaining what the code does
  • Test coverage with pytest implemented

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
NicolasSandoval
NicolasSandoval previously approved these changes Jul 3, 2023
Copy link
Member

@NicolasSandoval NicolasSandoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @HanslettTheDev!!! Thanks for your contribution.

Copy link
Member

@reingart reingart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HanslettTheDev for the contribution.

In further PR, please do not rewrite the history nor rebase/squash.
I have to merge #113 and fix conflicts with your branch.

I will suggest to split sign_tra() in 3 different functions:

  • one for legacy python 2 cryptography version
  • other for new python 3 cryptography version
  • another for the openssl executable workaround

Those should have separate Unit Tests so we can see if they are running ok.

Signed-off-by: Mariano Reingart <reingart@gmail.com>
@reingart reingart closed this Jul 5, 2023
@reingart reingart reopened this Jul 5, 2023
@reingart reingart merged commit 6d786a3 into PyAr:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants