bug: switch to integer for the skip flag #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re #498 It appears that defaults are ignored for boolean SEM parameters. Even though the parameter was set to true in https://github.com/QIICR/dcmqi/blob/2990dbd01d1fa61c16777950732ff19dc87318e3/apps/seg/itkimage2segimage.xml#L58-L65, the default reported by the executable was 0. Local tests show that integer parameters do not have this problem. Also switch to the most recent has for SlicerExecutionModel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #498
It appears that defaults are ignored for boolean SEM parameters. Even though the parameter was set to true in
dcmqi/apps/seg/itkimage2segimage.xml
Lines 58 to 65 in 2990dbd
Local tests show that integer parameters do not have this problem.
Also switch to the most recent has for SlicerExecutionModel.