-
Notifications
You must be signed in to change notification settings - Fork 108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned on the issue, we are using the useSchemaOrg composable, could you use it here, please?
With the last update, google finds 20 valid elements (the correct amount): https://search.google.com/test/rich-results/result/r%2Fevents?id=z99Wo6f5cTegIPkGur1EGA&hl=es |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @paaragon, this is very good progress!
I added some specific comments, but also, generally, I believe that there is an issue with the current approach.
We shouldn't add the list of events to every page but only to the pages where they are listed. And also, for individual event pages, we should add the data for the individual event.
…it.org into feat-event-schemaorg
You are right, the events list should be referenced only on the event/index page (I have changed it). I will also add the schema on |
The issue wasn't about the package but with some bug in the code. If you look at unhead's documentation on how to integrate with nuxt, it says to use the nuxt-schema-org package |
But on that page if you click on the GitHub icon on top, you land in the new repo https://github.com/harlan-zw/unhead-schema-org, which is I believe they just haven't updated their documentation. But, to be fair, it's unclear either way. I've opened an issue on their repo to ask about that: harlan-zw/nuxt-schema-org#24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @paaragon! I added a couple of comments 🙂
components/EventsFallFest/EventsFallFestUniversityDirectory.vue
Outdated
Show resolved
Hide resolved
…it.org into feat-event-schemaorg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @paaragon! I just checked the rich results in the tool linked as well and it looks great.
Changes
Fixes #3252
Implementation details
Add an
application/ld+json
script in the head ofevents/index.html
page o add the events information.How to read this PR
Run the page in dev mode and look for the script created within the HTML head tag. The correctness of the content can be tested with this page: https://search.google.com/test/rich-results?hl=es