This repository has been archived by the owner on May 17, 2024. It is now read-only.
fix(code-snippet): preserve empty lines #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jack O'Connor <134723582+jackoconnordev@users.noreply.github.com>
|
Oh that's nicer alright having <br> instead of whitespace inside <pre>. Having a space did feel unnecessarily hacky |
techtolentino
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
I'm good with this solution @eddybrando and @jackoconnordev (thank you).
🚀
jackoconnordev
approved these changes
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #3174
Co-authored-By: @jackoconnordev
Implementation details
We use
brto create the empty lines and have them preserved in the UI.We also simplify the computed property
codeLines.Finally, we add some syntax fixes in the
content/providers/list/5.multi-platforms.yaml, pointed out by @jackoconnordev in #3445.How to read this PR
Screenshots