Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

fix: image rendering with Nuxt Image RC #3458

Closed
wants to merge 3 commits into from
Closed

Conversation

eddybrando
Copy link
Collaborator

@eddybrando eddybrando commented Jul 28, 2023

Changes

This PR updates Nuxt Image to the newest RC version and makes some changes to try and use Nuxt Image everywhere in our codebase.

Closes #3226

How to read this PR

Last time we had some issues in the production build although the preview build worked fine.

We'll have to check this time again in local (works on my computer), preview (the preview generated here) and production once we merge this, and revert if this PR if there is any issue again.

@@ -30,17 +30,12 @@
</div>
<div v-if="activeCourse" class="learn-course-pages__content__preview">
<UiLink :url="activeCourse.url">
<!-- TODO: investigate why this particular img is not being populated -->
<!-- <nuxt-img
<nuxt-img
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't working for me @eddybrando

  • checked branch preview, no image
  • ran npm install, npm run generate, and nuxt start locally to mimic the production environment, and no images

please let me know if I'm doing it incorrectly.. .
Screenshot 2023-07-28 at 7 49 54 AM (2)

@eddybrando eddybrando marked this pull request as draft July 28, 2023 15:37
@eddybrando
Copy link
Collaborator Author

This is no longer a priority.

@eddybrando eddybrando closed this Jan 12, 2024
@y4izus y4izus deleted the fix/3226-nuxt-img-rc branch January 15, 2024 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: images are not rendering
2 participants