This repository has been archived by the owner on May 17, 2024. It is now read-only.
feat: page transitions #3461
Closed
feat: page transitions #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I love the page transitions, it gives the experience an interesting touch, and makes it more smooth as users navigate between pages and gives an sped up page load effect...
Not sure if we need to get approval before implementing to production; just commenting that I support this PR ✋🏼
y4izus
added
needs information
Closed
|
Per offline conversation, we decided to not merge this PRs, so I close it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds page transitions.
Closes #2107
Implementation details
We're implementing simple page transitions as explained in the Nuxt 3 docs: https://nuxt.com/docs/getting-started/transitions
Only internal links with NuxtLink are expected to work. The top header, since it's a web component with regular links, won't trigger animations.