This repository has been archived by the owner on May 17, 2024. It is now read-only.
feat(ecosystem): add tier project count to feature cards #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y4izus
suggested changes
Aug 2, 2023
Co-authored-by: Yaiza <yaiza.garcia.mm@gmail.com>
eddybrando
suggested changes
Aug 2, 2023
There was a problem hiding this comment.
Thank you very much @techtolentino, it looks very good!
I left a couple of comments.
y4izus
suggested changes
Aug 3, 2023
eddybrando
suggested changes
Aug 3, 2023
…skit/qiskit.org into feat/ecosystem-add-tier-project-count
eddybrando
approved these changes
Aug 4, 2023
y4izus
approved these changes
Aug 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #3472
Implementation details
getTierProjectCountjoinSectionCardsto be used as adetailpropdetailprop to feature card, and conditionally render if existsPreview link
https://qiskit-org-pr-3477.dcq4xc5i083.us-south.codeengine.appdomain.cloud/ecosystem
How to read this PR
Please review
card.detailprop addedScreenshots
Screen.Recording.2023-08-01.at.10.58.15.AM.mov