Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export unsafe_apply as the overload interface #380

Merged
merged 6 commits into from
May 4, 2022

Conversation

Roger-luo
Copy link
Member

@Roger-luo Roger-luo commented May 2, 2022

as we discussed last week, I want to have this before fixing QuEraComputing/Bloqade.jl#323

@Roger-luo Roger-luo requested a review from GiggleLiu May 2, 2022 23:04
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #380 (8809451) into master (4b72e43) will increase coverage by 0.13%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   87.45%   87.58%   +0.13%     
==========================================
  Files          72       72              
  Lines        3849     3891      +42     
==========================================
+ Hits         3366     3408      +42     
  Misses        483      483              
Impacted Files Coverage Δ
lib/YaoBlocks/src/composite/tag/cache.jl 60.25% <75.00%> (ø)
lib/YaoBlocks/src/abstract_block.jl 86.62% <100.00%> (ø)
lib/YaoBlocks/src/composite/chain.jl 93.15% <100.00%> (ø)
lib/YaoBlocks/src/composite/control.jl 97.77% <100.00%> (ø)
lib/YaoBlocks/src/composite/kron.jl 94.80% <100.00%> (ø)
lib/YaoBlocks/src/composite/put_block.jl 100.00% <100.00%> (ø)
lib/YaoBlocks/src/composite/reduce.jl 95.55% <100.00%> (ø)
lib/YaoBlocks/src/composite/repeated.jl 100.00% <100.00%> (ø)
lib/YaoBlocks/src/composite/subroutine.jl 96.87% <100.00%> (ø)
lib/YaoBlocks/src/composite/tag/scale.jl 96.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b72e43...8809451. Read the comment docs.

@Roger-luo
Copy link
Member Author

oops I thought #375 was merged

Copy link
Member

@GiggleLiu GiggleLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

@GiggleLiu GiggleLiu merged commit fc3046e into master May 4, 2022
@GiggleLiu GiggleLiu deleted the roger/apply-overload-interface branch May 4, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants