Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Pull Request #74

Open
wants to merge 424 commits into
base: main
Choose a base branch
from
Open

Final Pull Request #74

wants to merge 424 commits into from

Conversation

Quiddlee
Copy link
Owner

@Quiddlee Quiddlee commented Jan 6, 2024

  1. Task: click

  2. Screenshot:
    Welcome
    image
    image
    image
    image
    image

  3. Deploy: click

  4. Done 07.01.2024 / deadline 08.01.2024

  5. Score: 350 / 350

Welcome route - max 50 points 😍

  • The welcome page should contain general information about the developers, project, and course 10 points
  • In the upper right corner there are 2 buttons: Sign In and Sign Up 10 points
  • If the login token is valid and unexpired, the Sign In and Sign Up buttons are replaced with the "Main Page" button 10 points
  • When the token expires - the user should be redirected to the "Welcome page" automatically 10 points
  • Pressing the Sign In / Sign up button redirects a user to the route with the Sign In / Sign up form 10 points

Sign In / Sign Up - max 50 points 👋

  • Buttons for Sign In / Sign Up / Sign Out are everywhere where they should be 10 points
  • Client-side validation is implemented 20 points
  • Upon successful login, the user is redirected to the Main page 10 points
  • If the user is already logged in and tries to reach these routes, they should be redirected to the Main page 10 points

GraphiQL route - max 200 points ⚛️

  • Functional editor enabling query editing and prettifying 60 points
  • Operational documentation explorer, visible only upon successful SDL request 50 points
  • Variables section that can shown or hidden, specified variables are sent to the server 30 points
  • Header section that can be shown or hidden, user-added headers are sent to the server 20 points
  • Response section with an editor in read-only as a JSON viewer 40 points

General requirements - max 50 points 🥑

  • Localization 30 points
  • Sticky header 10 points
  • Errors from API side are displayed in the user friendly format 10 points

Penalties 👎

  • React default favicon -50 points
  • The presence of errors and warnings in the console -20 points for each
  • The presence in the console of the results of the console.log execution -20 points for each
  • @ts-ignore or any usage (search through GitHub repo) -20 points for each
  • The presence of code-smells (God-object, chunks of duplicate code), commented code sections: -10 points per each
  • Making commits after the deadline -100 points
  • Absence of tests -250 points
  • Test coverage below 80% -100 points
  • Absence of linting -150 points
  • Absence of prettier -100 points
  • Absence of husky git hooks -100 points
  • Usage 3rd party / open source libraries for prettifying, i18n -150 points
  • Pull Request doesn't follow guideline (including checkboxes in Score) PR example: -10 points
  • The administration reserves the right to apply penalties for the use of incorrect repository or branch names

Quiddlee and others added 30 commits December 26, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants