Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle case where error is present in json #22

Merged
merged 1 commit into from
Feb 12, 2024
Merged

handle case where error is present in json #22

merged 1 commit into from
Feb 12, 2024

Conversation

JosiahParry
Copy link
Collaborator

This PR adjusts the parse_esri_json() function. When the json it encounters is an error, the error itself is reported. Then an empty data.frame is returned.

This PR duplicates the detect_errors() function and calls rlang::warn() instead of rlang::abort(). I don't like this implementation, but in lieu of a rust-based JSON parsing library with consistent error handling, this will suffice.

Related: R-ArcGIS/arcgislayers#138

@JosiahParry JosiahParry merged commit 720f1b5 into main Feb 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant