Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a ground up rewrite of the geometry serialization from sf objects to EsriJSON. The current implementation using Rcpp and jsonify is too prone to errors and has been causing a number of headaches. The intent behind this is to use Rust and serde definitions to create geometries in a way that we know will always adhere to the format required. And if not, we will get a (messy) error.
This PR is massive with a lot of duplicative code but its the best I can do for now. It could potentially be simplified using a number of macros.
Additionally the functions
as_featureset()
,as_esri_featureset()
andas_features()
andas_esri_features()
have a lot of duplicative checking that can probably be simplified into a couple of helpers.This closes R-ArcGIS/arcgislayers#184
TODO:
as_features()
andas_esri_features()
as_featureset()
andas_esri_featureset()
CC @mmachir @elipousson