Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry #51

Merged
merged 3 commits into from
May 7, 2024
Merged

Geometry #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb1af70
Increment version number to 0.3.0
JosiahParry May 7, 2024
8060739
uhm? idk why it didn't work
JosiahParry May 7, 2024
fccef7e
update makevars
JosiahParry May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .Rbuildignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@
^CRAN-SUBMISSION$
^src/\.cargo$
^src/rust/vendor$
^src/vendor$
^README\.*$
1 change: 0 additions & 1 deletion .github/workflows/R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ jobs:
- {os: ubuntu-latest, r: 'release'}
- {os: ubuntu-latest, r: 'oldrel-1'}
- {os: ubuntu-latest, r: 'oldrel-2'}
- {os: ubuntu-latest, r: 'oldrel-3'}

env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
Expand Down
3 changes: 3 additions & 0 deletions CRAN-SUBMISSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Version: 0.3.0
Date: 2024-05-07 16:02:32 UTC
SHA: eb1af70478abdbf5e860c23dc65c6bf6ff339736
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: arcgisutils
Title: ArcGIS Utility Functions
Version: 0.2.0.9002
Version: 0.3.0
Authors@R: c(
person("Josiah", "Parry", , "josiah.parry@gmail.com", role = c("aut", "cre"),
comment = c(ORCID = "0000-0001-9910-865X")),
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# arcgisutils (development version)
# arcgisutils 0.3.0


- All geometry conversion functions: `as_esri_geometry()`, `as_esri_features()`, `as_esri_featureset()`, `as_features()` and `as_featureset()` have been rewritten from the ground up using Rust and extendr.
Expand Down
4 changes: 3 additions & 1 deletion cran-comments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@

0 errors | 0 warnings | 1 note

* arcgisbinding is not available via CRAN repository which is noted in the DESCRIPTION
* Cannot replicate check note for src/vendor/chrono/CITATION, _however_ I have added an step in Makevars to remove the vendor directorys
* The install size is < 2mb however the vendored dependencies are ~18mb making the source larger than the installation size.
* This is a new release.
4 changes: 2 additions & 2 deletions src/Makevars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ $(STATLIB):
fi

C_clean:
rm -Rf $(SHLIB) $(STATLIB) $(OBJECTS)
rm -Rf $(SHLIB) $(STATLIB) $(OBJECTS) $(TARGET_DIR) $(VENDOR_DIR)

clean:
rm -Rf $(SHLIB) $(STATLIB) $(OBJECTS) rust/target
rm -Rf $(SHLIB) $(STATLIB) $(OBJECTS) $(TARGET_DIR) $(VENDOR_DIR)
2 changes: 1 addition & 1 deletion src/Makevars.win
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ C_clean:
rm -Rf $(SHLIB) $(STATLIB) $(OBJECTS)

clean:
rm -Rf $(SHLIB) $(STATLIB) $(OBJECTS) $(TARGET_DIR)
rm -Rf $(SHLIB) $(STATLIB) $(OBJECTS) $(TARGET_DIR) $(VENDOR_DIR)
Loading