refactor: Bump libthermite #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And update broken code in FlightCore accordingly
And update broken code in FlightCore accordingly
Instead of reading `mod.json`, we now build Thunderstore mod string using `manifest.json` and `thunderstore_author.txt`. The old method for reading is still supported for now but will likely be replaced by a converted function in the future. See also discussion in 0neGal/viper#165
Alystrasz
reviewed
Jan 12, 2023
Alystrasz
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to version
0.4.0oflibthermite.In the process, we now also no longer write the Thunderstore mod string to the Northstar mod's
mod.jsonbut rather copy themanifest.jsonfrom the Thunderstore mod into the Northstar mod and add a file calledthunderstore_author.txtthat contains the author name of the Thunderstore mod to uniquely map a Northstar mod to a Thunderstore mod.This is done to increase compatibility with Viper and VTOL. See also the discussion here: 0neGal/viper#165
Reading
mod.jsonfor Thunderstore string is still supported for the time being. In the future it will be changed to a "converter" and then later will be fully deprecated.