feat: Allow installing plugins #267

catornot · 2023-04-16T05:34:53Z

not sure about the whole thing.

also I merged #266 because I can't wait

GeckoEidechse · 2023-04-18T01:19:42Z

Is there a plugin on Thunderstore yet to test this against? ^^

catornot · 2023-04-18T01:40:41Z

Is there a plugin on Thunderstore yet to test this against? ^^

kyurid

GeckoEidechse · 2023-04-19T13:14:22Z

As @ASpoonPlaysGames said here, a warning whenever a plugin is installed would be nice.

So like when you install a mod with plugin, it should show some pop-up requiring install confirmation (next to limiting plugin install to dev mode for now)

EDIT: @EladNLG had a good idea of adding an unskippable 5sec timer to the pop-up to prevent accidental confirms etc.

Thing is, I have no idea how to go Vue/TS -> Rust -> Vue/TS -> Rust without getting super ugly, so not sure if I can help you on that part :/

(Still haven't gotten around to testing btw, sorry about that).

src-tauri/src/mod_management/mod.rs

src-tauri/src/plugin_management/mod.rs

…Core into plugins-download

catornot · 2023-04-19T22:22:00Z

this will be the first and last time I work on the frontend

catornot · 2023-04-20T00:32:33Z

added a warning to the installing process with an option to cancel the install

GeckoEidechse

Hmm, so from quick testing trying to install kyurid I noticed that:

There was a second pop-up after some delay when installing plugin which is a bit confusing. Better would be to disable/enable the OK button (UI development is pain)
Because the Thunderstore mod only ships a plugin but no Northstar mod, FlightCore is unable to detect it as installed. Not sure how to solve that. Maybe we need to rework something in FlightCore, maybe we should rework plugin spec a bit
Plugins detection and displaying #294
Enable plugin install, going to another view, and going back to DevView, shows it as disabled again. To resolve, you can add a new variable to FlightCoreStore tracking the state (https://github.com/R2NorthstarTools/FlightCore/blob/main/src-vue/src/plugins/store.ts#L61-L87).
Might even wanna persist it but don't worry to much about that part, we can look at that together later ^^

catornot · 2023-04-20T20:59:08Z

so now

the warning popups don't overlay but I did remove the 5 second wait since I have no idea how to implement properly.
the disabled/enabled text in DevView updates correctly now

for the plugins not showing up as installed. I am not sure what would be the best way but I have some ideas.

install a dummy mod in mods with data about plugins that came with it
add a file to plugins folder to keep track of plugins's origin

GeckoEidechse · 2023-04-20T23:20:09Z

CI failure on Windows is likely unrelated to this PR and cause by Rust toolchain update, see also #280

GeckoEidechse

Another quick skim.

As for forced timer on popup, I might poke Alystrasz to implement it later... :>

src-vue/src/plugins/store.ts

src-tauri/src/main.rs

GeckoEidechse · 2023-04-21T14:54:50Z

I fixed CI issue on main now btw, so just update with main to get it resolved ^^

GeckoEidechse

Looks like something broke when merging recent main ._.

catornot · 2023-05-15T00:01:43Z

Looks like something broke when merging recent main ._.

should be fixed now

Alystrasz

Plugins don't appear as "installed" on online mods view, while they correctly appear as Thunderstore mods on local view:

Otherwise, features seems to be working correctly, I could install the Furnace plugin on my Ubuntu 23.04.

I however couldn't launch the game:


[SCRIPT UI] [errr] [SCRIPT UI] [error] COMPILE ERROR Undefined variable "FurnaceGetGrid"
[SCRIPT UI] [errr] [SCRIPT UI] [error] ui_furnace.nut line [11] column [48]

(you probably should add the mod repository URL to your plugin readme)

src-tauri/src/mod_management/mod.rs

src-vue/src/i18n/lang/en.json

src-vue/src/plugins/store.ts

catornot · 2023-05-15T19:02:14Z

Plugins don't appear as "installed" on online mods view, while they correctly appear as Thunderstore mods on local view:

yes, this pr doesn't cover that
#294 does

Otherwise, features seems to be working correctly, I could install the Furnace plugin on my Ubuntu 23.04.

uh should work on main

this prs installs plugins into subdirs and since 1.14.2 plugins v2 can't load plugins from subdirs Furnace doesn't work :(

catornot · 2023-05-26T18:14:11Z

more conflicts >:(
and also it would quite not pog if this doesn't get merged before soon:tm: plugins v3 pr

GeckoEidechse · 2023-05-26T18:26:22Z

more conflicts >:(

Had quite some code refactoring going on the last week or so but should be better now ^^
Just resolve merge conflicts and we can do another round of review

src-tauri/Cargo.lock

GeckoEidechse · 2023-05-29T23:32:34Z

src-tauri/src/plugin_management/download.rs

+        .join(&game_install.game_path)
+        .join("R2Northstar")
+        .join("plugins");
+    let temp_dir = TempDir::create(plugins_directory.join("___flightcore-temp-plugin-dir"))?;


This is still open ig

src-tauri/src/plugin_management/download.rs

catornot · 2023-06-12T16:18:39Z

I don't want to deal with this anymore

catornot added 3 commits April 15, 2023 12:34

use pass by reference where possible

e36d6df

installing plugins

c0ff70e

Merge branch 'R2NorthstarTools:main' into plugins-download

6719997

catornot marked this pull request as ready for review April 17, 2023 17:05

GeckoEidechse changed the title ~~Install Plugins~~ feat: Allow installing plugins Apr 17, 2023

GeckoEidechse reviewed Apr 19, 2023

View reviewed changes

src-tauri/src/mod_management/mod.rs Outdated Show resolved Hide resolved

GeckoEidechse reviewed Apr 19, 2023

View reviewed changes

src-tauri/src/plugin_management/mod.rs Outdated Show resolved Hide resolved

catornot added 3 commits April 19, 2023 17:10

Merge branch 'R2NorthstarTools:main' into plugins-download

c132668

move plugins install state to frontend

3ef92f7

Merge branch 'plugins-download' of https://github.com/catornot/Flight…

9af7a8e

…Core into plugins-download

catornot added 4 commits April 19, 2023 18:33

fix silly mistake

a707a38

huh

5812a55

no more mistakes in frontend

73ccb92

add a popup warning to plugin installing

822202f

catornot requested a review from GeckoEidechse April 20, 2023 00:31

GeckoEidechse requested changes Apr 20, 2023

View reviewed changes

catornot added 2 commits April 20, 2023 16:54

fix issues with frontend

190a390

formating

5fb2107

catornot requested a review from GeckoEidechse April 20, 2023 21:00

GeckoEidechse requested changes Apr 21, 2023

View reviewed changes

src-vue/src/plugins/store.ts Outdated Show resolved Hide resolved

src-vue/src/plugins/store.ts Outdated Show resolved Hide resolved

src-vue/src/plugins/store.ts Outdated Show resolved Hide resolved

src-tauri/src/main.rs Show resolved Hide resolved

catornot added 2 commits April 22, 2023 17:04

localization lol

3ba35f4

Merge branch 'main' into plugins-download

87f5dbb

catornot added 3 commits April 30, 2023 20:58

fix compile errors

606645d

prioritize plugins when installing

738d040

Merge branch 'main' into plugins-download

a369544

catornot mentioned this pull request May 5, 2023

refactor: Always remove zip files #304

Merged

catornot added 5 commits May 9, 2023 14:43

Merge branch 'main' into plugins-download

d6bef58

fix compile errors

36fdd10

fmt

57ca3df

Merge branch 'main' into plugins-download

a673823

eh fix

e7984e1

GeckoEidechse requested changes May 14, 2023

View reviewed changes

fixed broken invoke call

be2bf88

Alystrasz requested changes May 15, 2023

View reviewed changes

src-tauri/src/mod_management/mod.rs Outdated Show resolved Hide resolved

src-vue/src/i18n/lang/en.json Outdated Show resolved Hide resolved

src-vue/src/plugins/store.ts Outdated Show resolved Hide resolved

things

f268590

catornot added 2 commits May 16, 2023 18:31

grammar thingy

65c8997

Merge branch 'main' into plugins-download

9d8c4ca

catornot requested review from Alystrasz and GeckoEidechse May 16, 2023 22:33

catornot added 3 commits May 27, 2023 16:54

Merge branch 'main' into plugins-download

459f6d0

inspect_err is not in stable :(

eedefce

fmt

da010ce

GeckoEidechse reviewed May 29, 2023

View reviewed changes

documenting things

14f4805

catornot closed this Jun 12, 2023

GeckoEidechse mentioned this pull request Jul 21, 2023

feat: Prevent mods with plugins to be installed #438

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Allow installing plugins #267

feat: Allow installing plugins #267

catornot commented Apr 16, 2023

GeckoEidechse commented Apr 18, 2023

catornot commented Apr 18, 2023

GeckoEidechse commented Apr 19, 2023 •

edited

Loading

catornot commented Apr 19, 2023

catornot commented Apr 20, 2023

GeckoEidechse left a comment •

edited

Loading

catornot commented Apr 20, 2023

GeckoEidechse commented Apr 20, 2023

GeckoEidechse left a comment

GeckoEidechse commented Apr 21, 2023

GeckoEidechse left a comment

catornot commented May 15, 2023

Alystrasz left a comment

catornot commented May 15, 2023 •

edited by GeckoEidechse

Loading

catornot commented May 26, 2023

GeckoEidechse commented May 26, 2023

GeckoEidechse May 29, 2023

catornot commented Jun 12, 2023

feat: Allow installing plugins #267

feat: Allow installing plugins #267

Conversation

catornot commented Apr 16, 2023

GeckoEidechse commented Apr 18, 2023

catornot commented Apr 18, 2023

GeckoEidechse commented Apr 19, 2023 • edited Loading

catornot commented Apr 19, 2023

catornot commented Apr 20, 2023

GeckoEidechse left a comment • edited Loading

Choose a reason for hiding this comment

catornot commented Apr 20, 2023

GeckoEidechse commented Apr 20, 2023

GeckoEidechse left a comment

Choose a reason for hiding this comment

GeckoEidechse commented Apr 21, 2023

GeckoEidechse left a comment

Choose a reason for hiding this comment

catornot commented May 15, 2023

Alystrasz left a comment

Choose a reason for hiding this comment

catornot commented May 15, 2023 • edited by GeckoEidechse Loading

catornot commented May 26, 2023

GeckoEidechse commented May 26, 2023

GeckoEidechse May 29, 2023

Choose a reason for hiding this comment

catornot commented Jun 12, 2023

GeckoEidechse commented Apr 19, 2023 •

edited

Loading

GeckoEidechse left a comment •

edited

Loading

catornot commented May 15, 2023 •

edited by GeckoEidechse

Loading