Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helmfile dependency management #241

Closed
wants to merge 8 commits into from
Closed

Use helmfile dependency management #241

wants to merge 8 commits into from

Conversation

keyvaann
Copy link
Collaborator

Apparently you can use helmfile to manage dependencies so we don't have to use --concurrency 1 flag anymore. However right now this assumes that all dependencies like Kafka, S3 and Postgresql are all installed on the cluster, this needs to be fixed before the PR is ready. However it's still possible to ignore dependency management system with --skip-needs flag.

Continued from #221

@blootsvoets
Copy link
Member

Perhaps just add a line in README like However it's still possible to ignore dependency management system with --skip-needs flag.

Copy link

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a very nice addition. I tested it myself and it works. However, I think it would be good to review the helmfiles again. I think that, for instance, in 20-dashboard.yaml the timescaledb is not covered by the 'needs:' sections.

@keyvaann
Copy link
Collaborator Author

keyvaann commented Aug 7, 2024

Changes applied in #306

@keyvaann keyvaann closed this Aug 7, 2024
@keyvaann keyvaann deleted the needs2 branch August 7, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants