-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use helmfile dependency management #241
Conversation
Perhaps just add a line in README like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a very nice addition. I tested it myself and it works. However, I think it would be good to review the helmfiles again. I think that, for instance, in 20-dashboard.yaml the timescaledb is not covered by the 'needs:' sections.
Changes applied in #306 |
Apparently you can use helmfile to manage dependencies so we don't have to use --concurrency 1 flag anymore. However right now this assumes that all dependencies like Kafka, S3 and Postgresql are all installed on the cluster, this needs to be fixed before the PR is ready. However it's still possible to ignore dependency management system with --skip-needs flag.
Continued from #221